[INFO] fetching crate mutable_derive 0.3.3... [INFO] checking mutable_derive-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mutable_derive 0.3.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mutable_derive 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mutable_derive 0.3.3 [INFO] finished tweaking crates.io crate mutable_derive 0.3.3 [INFO] tweaked toml for crates.io crate mutable_derive 0.3.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] [stderr] Adding convert_case v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9171e6c902b9ce4d424b99d87d1b0073793d7a9fc3e6b99b74e2ab9af7461c42 [INFO] running `Command { std: "docker" "start" "-a" "9171e6c902b9ce4d424b99d87d1b0073793d7a9fc3e6b99b74e2ab9af7461c42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9171e6c902b9ce4d424b99d87d1b0073793d7a9fc3e6b99b74e2ab9af7461c42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9171e6c902b9ce4d424b99d87d1b0073793d7a9fc3e6b99b74e2ab9af7461c42", kill_on_drop: false }` [INFO] [stdout] 9171e6c902b9ce4d424b99d87d1b0073793d7a9fc3e6b99b74e2ab9af7461c42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cf6a762fd63ce8f1d461e652add6a80a07e780ad7caa9bddb528b00fc405f0c [INFO] running `Command { std: "docker" "start" "-a" "2cf6a762fd63ce8f1d461e652add6a80a07e780ad7caa9bddb528b00fc405f0c", kill_on_drop: false }` [INFO] [stderr] Checking convert_case v0.5.0 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking proc-macro-error v1.0.4 [INFO] [stderr] Checking mutable_derive v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_mutable.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | fn generate_from_fields<'r, I>(fields: I) -> (Vec, Vec) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | / fields.map(|(ty, name, convert_case)| { [INFO] [stdout] 12 | | let pascal_name = if convert_case {name.to_case(Case::Pascal)} else {name.clone()}; [INFO] [stdout] 13 | | (format!(r#"updates.append(&mut <{field_type} as mutable::Mutable>::cmp(&self.{field_name}, &new_value.{field_name}).into_iter().... [INFO] [stdout] 14 | | field_type = ty.to_token_stream(), [INFO] [stdout] ... | [INFO] [stdout] 20 | | )) [INFO] [stdout] 21 | | }).collect::>().into_iter().unzip() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_mutable.rs:34:38 [INFO] [stdout] | [INFO] [stdout] 34 | .map(|f| (&f.ty, f.ident.to_token_stream().to_string(), true)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_softeq.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) fn try_(item: TokenStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let item = syn::parse::(item).map_err(|_| abort!(Span::call_site(), "Could not parse item"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | [INFO] [stdout] 9 | let struct_ = match item { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Item::Struct(struct_) => struct_, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(format!(r#" [INFO] [stdout] | ________^ [INFO] [stdout] 38 | | impl SoftEq for {}{{ [INFO] [stdout] 39 | | type Uid = ({}); [INFO] [stdout] 40 | | fn uid(&self) -> Self::Uid{{ [INFO] [stdout] ... | [INFO] [stdout] 47 | | uid_names.iter().map(|n| format!("self.{n}.clone()")).collect::>().join(", ") [INFO] [stdout] 48 | | ).parse().unwrap()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_softeq.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|field| (field.ty.to_token_stream().to_string(), field.ident.as_ref().unwrap().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_mutable.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | fn generate_from_fields<'r, I>(fields: I) -> (Vec, Vec) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | / fields.map(|(ty, name, convert_case)| { [INFO] [stdout] 12 | | let pascal_name = if convert_case {name.to_case(Case::Pascal)} else {name.clone()}; [INFO] [stdout] 13 | | (format!(r#"updates.append(&mut <{field_type} as mutable::Mutable>::cmp(&self.{field_name}, &new_value.{field_name}).into_iter().... [INFO] [stdout] 14 | | field_type = ty.to_token_stream(), [INFO] [stdout] ... | [INFO] [stdout] 20 | | )) [INFO] [stdout] 21 | | }).collect::>().into_iter().unzip() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mutable_derive` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_mutable.rs:34:38 [INFO] [stdout] | [INFO] [stdout] 34 | .map(|f| (&f.ty, f.ident.to_token_stream().to_string(), true)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_softeq.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) fn try_(item: TokenStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let item = syn::parse::(item).map_err(|_| abort!(Span::call_site(), "Could not parse item"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | [INFO] [stdout] 9 | let struct_ = match item { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Item::Struct(struct_) => struct_, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(format!(r#" [INFO] [stdout] | ________^ [INFO] [stdout] 38 | | impl SoftEq for {}{{ [INFO] [stdout] 39 | | type Uid = ({}); [INFO] [stdout] 40 | | fn uid(&self) -> Self::Uid{{ [INFO] [stdout] ... | [INFO] [stdout] 47 | | uid_names.iter().map(|n| format!("self.{n}.clone()")).collect::>().join(", ") [INFO] [stdout] 48 | | ).parse().unwrap()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_softeq.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|field| (field.ty.to_token_stream().to_string(), field.ident.as_ref().unwrap().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mutable_derive` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "2cf6a762fd63ce8f1d461e652add6a80a07e780ad7caa9bddb528b00fc405f0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cf6a762fd63ce8f1d461e652add6a80a07e780ad7caa9bddb528b00fc405f0c", kill_on_drop: false }` [INFO] [stdout] 2cf6a762fd63ce8f1d461e652add6a80a07e780ad7caa9bddb528b00fc405f0c