[INFO] fetching crate musli-utils 0.0.117... [INFO] checking musli-utils-0.0.117 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate musli-utils 0.0.117 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate musli-utils 0.0.117 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate musli-utils 0.0.117 [INFO] finished tweaking crates.io crate musli-utils 0.0.117 [INFO] tweaked toml for crates.io crate musli-utils 0.0.117 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding musli v0.0.117 (latest: v0.0.123) [INFO] [stderr] Adding musli-macros v0.0.117 (latest: v0.0.123) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8639b7de91f92c5b67f50d9d4cf9f2656fcf75276b774231f4ad86af976a9d91 [INFO] running `Command { std: "docker" "start" "-a" "8639b7de91f92c5b67f50d9d4cf9f2656fcf75276b774231f4ad86af976a9d91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8639b7de91f92c5b67f50d9d4cf9f2656fcf75276b774231f4ad86af976a9d91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8639b7de91f92c5b67f50d9d4cf9f2656fcf75276b774231f4ad86af976a9d91", kill_on_drop: false }` [INFO] [stdout] 8639b7de91f92c5b67f50d9d4cf9f2656fcf75276b774231f4ad86af976a9d91 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55a2206a4acdce55ff364d081dccdc7d7872eecf2aa1f719f0ad11d100f93adf [INFO] running `Command { std: "docker" "start" "-a" "55a2206a4acdce55ff364d081dccdc7d7872eecf2aa1f719f0ad11d100f93adf", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling musli-macros v0.0.117 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking musli v0.0.117 [INFO] [stderr] Checking musli-allocator v0.0.117 [INFO] [stderr] Checking musli-utils v0.0.117 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `doc_cfg` [INFO] [stdout] --> src/lib.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | #![cfg_attr(doc_cfg, feature(doc_cfg))] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(doc_cfg)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(doc_cfg)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simdutf8` [INFO] [stdout] --> src/str.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(not(feature = "simdutf8"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, and `std` [INFO] [stdout] = help: consider adding `simdutf8` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simdutf8` [INFO] [stdout] --> src/str.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | #[cfg(feature = "simdutf8")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, and `std` [INFO] [stdout] = help: consider adding `simdutf8` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simdutf8` [INFO] [stdout] --> src/str.rs:38:34 [INFO] [stdout] | [INFO] [stdout] 38 | #[cfg(all(feature = "alloc", not(feature = "simdutf8")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, and `std` [INFO] [stdout] = help: consider adding `simdutf8` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simdutf8` [INFO] [stdout] --> src/str.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | #[cfg(all(feature = "alloc", feature = "simdutf8"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, and `std` [INFO] [stdout] = help: consider adding `simdutf8` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `doc_cfg` [INFO] [stdout] --> src/lib.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | #![cfg_attr(doc_cfg, feature(doc_cfg))] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(doc_cfg)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(doc_cfg)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simdutf8` [INFO] [stdout] --> src/str.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(not(feature = "simdutf8"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, and `std` [INFO] [stdout] = help: consider adding `simdutf8` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simdutf8` [INFO] [stdout] --> src/str.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | #[cfg(feature = "simdutf8")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, and `std` [INFO] [stdout] = help: consider adding `simdutf8` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simdutf8` [INFO] [stdout] --> src/str.rs:38:34 [INFO] [stdout] | [INFO] [stdout] 38 | #[cfg(all(feature = "alloc", not(feature = "simdutf8")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, and `std` [INFO] [stdout] = help: consider adding `simdutf8` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simdutf8` [INFO] [stdout] --> src/str.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | #[cfg(all(feature = "alloc", feature = "simdutf8"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, and `std` [INFO] [stdout] = help: consider adding `simdutf8` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/int/encoding.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | / let Ok(value) = [INFO] [stdout] 140 | | usize::try_from(<$ty as UnsignedOps>::read_bytes(cx, reader, bo)?) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 149 | crate::width_arm!(crate::options::length_width::(), fixed) [INFO] [stdout] | --------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fixed` which comes from the expansion of the macro `crate::width_arm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/int/encoding.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | / let Ok(value) = [INFO] [stdout] 140 | | usize::try_from(<$ty as UnsignedOps>::read_bytes(cx, reader, bo)?) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 149 | crate::width_arm!(crate::options::length_width::(), fixed) [INFO] [stdout] | --------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] = note: this warning originates in the macro `fixed` which comes from the expansion of the macro `crate::width_arm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context/mod.rs:230:20 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn new(alloc: A) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | error: UnsafeCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `musli-utils` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/int/encoding.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | / let Ok(value) = [INFO] [stdout] 140 | | usize::try_from(<$ty as UnsignedOps>::read_bytes(cx, reader, bo)?) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 149 | crate::width_arm!(crate::options::length_width::(), fixed) [INFO] [stdout] | --------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fixed` which comes from the expansion of the macro `crate::width_arm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/int/encoding.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | / let Ok(value) = [INFO] [stdout] 140 | | usize::try_from(<$ty as UnsignedOps>::read_bytes(cx, reader, bo)?) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 149 | crate::width_arm!(crate::options::length_width::(), fixed) [INFO] [stdout] | --------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] = note: this warning originates in the macro `fixed` which comes from the expansion of the macro `crate::width_arm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context/mod.rs:230:20 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn new(alloc: A) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | error: UnsafeCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `musli-utils` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "55a2206a4acdce55ff364d081dccdc7d7872eecf2aa1f719f0ad11d100f93adf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55a2206a4acdce55ff364d081dccdc7d7872eecf2aa1f719f0ad11d100f93adf", kill_on_drop: false }` [INFO] [stdout] 55a2206a4acdce55ff364d081dccdc7d7872eecf2aa1f719f0ad11d100f93adf