[INFO] fetching crate music-metadata 0.3.0... [INFO] checking music-metadata-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate music-metadata 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate music-metadata 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate music-metadata 0.3.0 [INFO] finished tweaking crates.io crate music-metadata 0.3.0 [INFO] tweaked toml for crates.io crate music-metadata 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate music-metadata 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 956c4ce4603139cf8b4fab908d806ab6173deb8e9081721c95ba565edec3c7f8 [INFO] running `Command { std: "docker" "start" "-a" "956c4ce4603139cf8b4fab908d806ab6173deb8e9081721c95ba565edec3c7f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "956c4ce4603139cf8b4fab908d806ab6173deb8e9081721c95ba565edec3c7f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "956c4ce4603139cf8b4fab908d806ab6173deb8e9081721c95ba565edec3c7f8", kill_on_drop: false }` [INFO] [stdout] 956c4ce4603139cf8b4fab908d806ab6173deb8e9081721c95ba565edec3c7f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] afe2ba68cada3c8f94c334129157f4dee12d5241445fea132b03df9439fa8b17 [INFO] running `Command { std: "docker" "start" "-a" "afe2ba68cada3c8f94c334129157f4dee12d5241445fea132b03df9439fa8b17", kill_on_drop: false }` [INFO] [stderr] Checking music-metadata v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `version` is never read [INFO] [stdout] --> src/id3/frames/header.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct FrameHeader { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub version: Version, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `version` is never read [INFO] [stdout] --> src/id3/frames/header.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct FrameHeader { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub version: Version, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `comment_body` is never read [INFO] [stdout] --> src/ogg/ogg_vorbis_comment.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct CommentHeader { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | pub comment_body: CommentBody, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommentHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `comment_body` is never read [INFO] [stdout] --> src/ogg/ogg_vorbis_comment.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct CommentHeader { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | pub comment_body: CommentBody, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommentHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(fp: T) -> io::Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let file_size = File::open(&fp)?.metadata()?.len(); [INFO] [stdout] 81 | Ok(ID3Parser { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | fp, [INFO] [stdout] 83 | | hm: HashMap::default(), [INFO] [stdout] 84 | | frames: Vec::default(), [INFO] [stdout] ... | [INFO] [stdout] 90 | | file_size, [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(fp: T) -> io::Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let file_size = File::open(&fp)?.metadata()?.len(); [INFO] [stdout] 81 | Ok(ID3Parser { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | fp, [INFO] [stdout] 83 | | hm: HashMap::default(), [INFO] [stdout] 84 | | frames: Vec::default(), [INFO] [stdout] ... | [INFO] [stdout] 90 | | file_size, [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | pub fn new(fp: T) -> io::Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Ok(FlacParser { [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | fp, [INFO] [stdout] 308 | | stream_info: BlockStreamInfo::default(), [INFO] [stdout] 309 | | application: BlockApplication::default(), [INFO] [stdout] ... | [INFO] [stdout] 314 | | padding_length: u32::default(), [INFO] [stdout] 315 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | pub fn new(fp: T) -> io::Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Ok(FlacParser { [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | fp, [INFO] [stdout] 308 | | stream_info: BlockStreamInfo::default(), [INFO] [stdout] 309 | | application: BlockApplication::default(), [INFO] [stdout] ... | [INFO] [stdout] 314 | | padding_length: u32::default(), [INFO] [stdout] 315 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flac/flac_buffer_reader.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new>(f: T) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(FlacBufferReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 12 | | file: File::open(f)?, [INFO] [stdout] 13 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flac/flac_buffer_reader.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new>(f: T) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(FlacBufferReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 12 | | file: File::open(f)?, [INFO] [stdout] 13 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/id3/id3_buffer_reader.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new>(f: T) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(ID3BufferReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | file: File::open(f)?, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ogg/ogg_buffer_reader.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new>(f: T) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Ok(OggBufferReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 11 | | file: File::open(f)?, [INFO] [stdout] 12 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/id3/id3_buffer_reader.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new>(f: T) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(ID3BufferReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | file: File::open(f)?, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ogg/ogg_buffer_reader.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new>(f: T) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Ok(OggBufferReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 11 | | file: File::open(f)?, [INFO] [stdout] 12 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `music-metadata` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `music-metadata` (lib) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "afe2ba68cada3c8f94c334129157f4dee12d5241445fea132b03df9439fa8b17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afe2ba68cada3c8f94c334129157f4dee12d5241445fea132b03df9439fa8b17", kill_on_drop: false }` [INFO] [stdout] afe2ba68cada3c8f94c334129157f4dee12d5241445fea132b03df9439fa8b17