[INFO] fetching crate mun_project 0.4.0... [INFO] checking mun_project-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mun_project 0.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate mun_project 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mun_project 0.4.0 [INFO] finished tweaking crates.io crate mun_project 0.4.0 [INFO] tweaked toml for crates.io crate mun_project 0.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98384c3521acff9ac31a14530e5c2da4ea0a0f4092f282461a3afd6ea54eeafc [INFO] running `Command { std: "docker" "start" "-a" "98384c3521acff9ac31a14530e5c2da4ea0a0f4092f282461a3afd6ea54eeafc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98384c3521acff9ac31a14530e5c2da4ea0a0f4092f282461a3afd6ea54eeafc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98384c3521acff9ac31a14530e5c2da4ea0a0f4092f282461a3afd6ea54eeafc", kill_on_drop: false }` [INFO] [stdout] 98384c3521acff9ac31a14530e5c2da4ea0a0f4092f282461a3afd6ea54eeafc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aea01e1173bb9b48da223ed55cf0a2a6c92732cd1e877078939728e4f79c4bf7 [INFO] running `Command { std: "docker" "start" "-a" "aea01e1173bb9b48da223ed55cf0a2a6c92732cd1e877078939728e4f79c4bf7", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking relative-path v1.9.3 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking mun_paths v0.4.0 [INFO] [stderr] Checking mun_project v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest/toml.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn into_real_manifest(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(Manifest { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | package_id: PackageId { [INFO] [stdout] 29 | | name: name.to_owned(), [INFO] [stdout] 30 | | version: self.package.version, [INFO] [stdout] ... | [INFO] [stdout] 34 | | }, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/package.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_file>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let path = path.as_ref(); [INFO] [stdout] 26 | let manifest = Manifest::from_file(path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(Self::new(manifest, path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/project_manifest.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn discover(path: impl AsRef) -> io::Result> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(read_dir(path.as_ref())? [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | .filter_map(Result::ok) [INFO] [stdout] 34 | | .map(|entry| entry.path()) [INFO] [stdout] 35 | | .filter(|path| { [INFO] [stdout] ... | [INFO] [stdout] 45 | | ), [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/project_manifest.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | .filter_map(|path| ProjectManifest::discover(path).ok()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mun_project` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest/toml.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn into_real_manifest(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(Manifest { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | package_id: PackageId { [INFO] [stdout] 29 | | name: name.to_owned(), [INFO] [stdout] 30 | | version: self.package.version, [INFO] [stdout] ... | [INFO] [stdout] 34 | | }, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/package.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_file>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let path = path.as_ref(); [INFO] [stdout] 26 | let manifest = Manifest::from_file(path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(Self::new(manifest, path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/project_manifest.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn discover(path: impl AsRef) -> io::Result> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(read_dir(path.as_ref())? [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | .filter_map(Result::ok) [INFO] [stdout] 34 | | .map(|entry| entry.path()) [INFO] [stdout] 35 | | .filter(|path| { [INFO] [stdout] ... | [INFO] [stdout] 45 | | ), [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/project_manifest.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | .filter_map(|path| ProjectManifest::discover(path).ok()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mun_project` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "aea01e1173bb9b48da223ed55cf0a2a6c92732cd1e877078939728e4f79c4bf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aea01e1173bb9b48da223ed55cf0a2a6c92732cd1e877078939728e4f79c4bf7", kill_on_drop: false }` [INFO] [stdout] aea01e1173bb9b48da223ed55cf0a2a6c92732cd1e877078939728e4f79c4bf7