[INFO] fetching crate mugle_p2p 5.2.0-alpha.5... [INFO] checking mugle_p2p-5.2.0-alpha.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mugle_p2p 5.2.0-alpha.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mugle_p2p 5.2.0-alpha.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mugle_p2p 5.2.0-alpha.5 [INFO] finished tweaking crates.io crate mugle_p2p 5.2.0-alpha.5 [INFO] tweaked toml for crates.io crate mugle_p2p 5.2.0-alpha.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 196 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arc-swap v0.4.8 (latest: v1.7.1) [INFO] [stderr] Adding arrayvec v0.3.25 (latest: v0.7.6) [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding base64 v0.12.3 (latest: v0.22.1) [INFO] [stderr] Adding bindgen v0.56.0 (latest: v0.70.1) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v0.9.1 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cexpr v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding croaring v0.4.6 (latest: v2.0.3) [INFO] [stderr] Adding croaring-sys v0.4.6 (latest: v4.1.1) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hmac v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding log4rs v0.12.0 (latest: v1.3.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] [stderr] Adding num v0.2.1 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.2.6 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.2.4 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.2.4 (latest: v0.4.2) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding odds v0.2.26 (latest: v0.4.0) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding parking_lot v0.10.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.7.3 (latest: v0.9.10) [INFO] [stderr] Adding password-hash v0.2.3 (latest: v0.5.0) [INFO] [stderr] Adding pbkdf2 v0.8.0 (latest: v0.12.2) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding ripemd160 v0.9.1 (latest: v0.10.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding serde-value v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding shlex v0.1.1 (latest: v1.3.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding subtle v2.4.1 (latest: v2.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding thread-id v3.3.0 (latest: v4.2.2) [INFO] [stderr] Adding which v3.1.1 (latest: v6.0.3) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zip v0.5.13 (latest: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a44f5c0afb23d1dbc39006f459b529c2a024b0f3f8554dbba5444fd66dbe7bfd [INFO] running `Command { std: "docker" "start" "-a" "a44f5c0afb23d1dbc39006f459b529c2a024b0f3f8554dbba5444fd66dbe7bfd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a44f5c0afb23d1dbc39006f459b529c2a024b0f3f8554dbba5444fd66dbe7bfd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a44f5c0afb23d1dbc39006f459b529c2a024b0f3f8554dbba5444fd66dbe7bfd", kill_on_drop: false }` [INFO] [stdout] a44f5c0afb23d1dbc39006f459b529c2a024b0f3f8554dbba5444fd66dbe7bfd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] acff4666ae3d06064667d28f36a014d246386006447ad6a6da082de2d11ba38f [INFO] running `Command { std: "docker" "start" "-a" "acff4666ae3d06064667d28f36a014d246386006447ad6a6da082de2d11ba38f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling bindgen v0.56.0 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Compiling mugle_secp256k1zkp v0.7.12 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking odds v0.2.26 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking arrayvec v0.3.25 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking arc-swap v0.4.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking password-hash v0.2.3 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling liblmdb-sys v0.2.2 [INFO] [stderr] Checking blake2-rfc v0.2.18 [INFO] [stderr] Checking pbkdf2 v0.8.0 [INFO] [stderr] Checking ripemd160 v0.9.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking supercow v0.1.0 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking lmdb-zero v0.4.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde-value v0.6.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling env_logger v0.8.4 [INFO] [stderr] Checking log4rs v0.12.0 [INFO] [stderr] Checking mugle_util v5.2.0-alpha.5 [INFO] [stderr] Checking mugle_keychain v5.2.0-alpha.5 [INFO] [stderr] Compiling croaring-sys v0.4.6 [INFO] [stderr] Checking croaring v0.4.6 [INFO] [stderr] Checking mugle_core v5.2.0-alpha.5 [INFO] [stderr] Checking mugle_store v5.2.0-alpha.5 [INFO] [stderr] Checking mugle_pool v5.2.0-alpha.5 [INFO] [stderr] Checking mugle_chain v5.2.0-alpha.5 [INFO] [stderr] Checking mugle_p2p v5.2.0-alpha.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead [INFO] [stdout] --> src/peers.rs:440:25 [INFO] [stdout] | [INFO] [stdout] 440 | let diff = now - Utc.timestamp(peer.last_connected, 0); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead [INFO] [stdout] --> src/peers.rs:440:25 [INFO] [stdout] | [INFO] [stdout] 440 | let diff = now - Utc.timestamp(peer.last_connected, 0); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(version: ProtocolVersion, stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | buffer: BytesMut::with_capacity(8 * 1024), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:80:11 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(version: ProtocolVersion, stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | state: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn send(&self, msg: Msg) -> Result<(), Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | match self.send_channel.try_send(msg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 175 | stream: TcpStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | version: ProtocolVersion, [INFO] [stdout] 177 | tracker: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let (send_tx, send_rx) = mpsc::sync_channel(SEND_CHANNEL_CAP); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | [INFO] [stdout] 185 | let stopped = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | [INFO] [stdout] 187 | let conn_handle = ConnHandle { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let (reader_thread, writer_thread) = poll( [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 202 | | conn_handle, [INFO] [stdout] 203 | | StopHandle { [INFO] [stdout] 204 | | stopped, [INFO] [stdout] ... | [INFO] [stdout] 207 | | }, [INFO] [stdout] 208 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 212 | conn: TcpStream, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | conn_handle: ConnHandle, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | version: ProtocolVersion, [INFO] [stdout] 215 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | send_rx: mpsc::Receiver, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | stopped: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | tracker: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let reader = conn.try_clone().expect("clone conn for reader failed"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let mut writer = conn.try_clone().expect("clone conn for writer failed"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let reader_stopped = stopped.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | [INFO] [stdout] 228 | let reader_tracker = tracker.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let writer_tracker = tracker; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | [INFO] [stdout] 231 | let reader_thread = thread::Builder::new() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | let writer_thread = thread::Builder::new() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | Ok((reader_thread, writer_thread)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg.rs:156:6 [INFO] [stdout] | [INFO] [stdout] 152 | msg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Ok(Msg { [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | header: MsgHeader::new(msg_type, body.len() as u64), [INFO] [stdout] 158 | | body, [INFO] [stdout] 159 | | attachment: None, [INFO] [stdout] 160 | | version, [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 194 | let res = T::read(&mut reader)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | Ok((res, reader.total_bytes_read())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg.rs:818:6 [INFO] [stdout] | [INFO] [stdout] 817 | let segment = Readable::read(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 818 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 819 | | block_hash, [INFO] [stdout] 820 | | segment, [INFO] [stdout] 821 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:93:6 [INFO] [stdout] | [INFO] [stdout] 80 | fn new(info: PeerInfo, conn: TcpStream, adapter: Arc) -> std::io::Result { [INFO] [stdout] | -------------- --------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let state = Arc::new(RwLock::new(State::Connected)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let state_sync_requested = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let tracking_adapter = TrackingAdapter::new(adapter); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let handler = Protocol::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let tracker = Arc::new(conn::Tracker::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (sendh, stoph) = conn::listen(conn, info.version, tracker.clone(), handler)?; [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let send_handle = Mutex::new(sendh); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let stop_handle = Mutex::new(stoph); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Ok(Peer { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | info, [INFO] [stdout] 95 | | state, [INFO] [stdout] 96 | | tracking_adapter, [INFO] [stdout] ... | [INFO] [stdout] 100 | | state_sync_requested, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:227:3 [INFO] [stdout] | [INFO] [stdout] 225 | fn send(&self, msg: T, msg_type: Type) -> Result<(), Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let msg = Msg::new(msg_type, msg, self.info.version)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | self.send_handle.lock().send(msg) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:465:14 [INFO] [stdout] | [INFO] [stdout] 462 | fn new(adapter: Arc) -> TrackingAdapter { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 465 | received: Arc::new(RwLock::new(LruCache::new(MAX_TRACK_SIZE))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:466:15 [INFO] [stdout] | [INFO] [stdout] 462 | fn new(adapter: Arc) -> TrackingAdapter { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 466 | requested: Arc::new(RwLock::new(LruCache::new(MAX_TRACK_SIZE))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(store: PeerStore, adapter: Arc, config: P2PConfig) -> Peers { [INFO] [stdout] | ---------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | peers: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:129:10 [INFO] [stdout] | [INFO] [stdout] 121 | let peers = match self.peers.try_read_for(LOCK_TIMEOUT) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Some(peers) => peers.values().cloned().collect(), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | iter: peers.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:368:27 [INFO] [stdout] | [INFO] [stdout] 368 | let outbound_peers = || self.iter().outbound().connected().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:389:26 [INFO] [stdout] | [INFO] [stdout] 389 | let inbound_peers = || self.iter().inbound().connected().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:779:10 [INFO] [stdout] | [INFO] [stdout] 777 | pub fn connected(self) -> PeersIter>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 778 | PeersIter { [INFO] [stdout] 779 | iter: self.iter.filter(|p| p.is_connected()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:786:10 [INFO] [stdout] | [INFO] [stdout] 784 | pub fn inbound(self) -> PeersIter>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 785 | PeersIter { [INFO] [stdout] 786 | iter: self.iter.filter(|p| p.info.is_inbound()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:793:10 [INFO] [stdout] | [INFO] [stdout] 791 | pub fn outbound(self) -> PeersIter>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 792 | PeersIter { [INFO] [stdout] 793 | iter: self.iter.filter(|p| p.info.is_outbound()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:808:10 [INFO] [stdout] | [INFO] [stdout] 803 | pub fn with_difficulty(self, f: F) -> PeersIter>> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 808 | iter: self.iter.filter(move |p| f(p.info.total_difficulty())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:818:10 [INFO] [stdout] | [INFO] [stdout] 814 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 818 | iter: self.iter.filter(move |p| p.info.capabilities.contains(cap)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:834:3 [INFO] [stdout] | [INFO] [stdout] 833 | pub fn max_difficulty(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 834 | self.iter.map(|p| p.info.total_difficulty()).max() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serv.rs:63:6 [INFO] [stdout] | [INFO] [stdout] 59 | adapter: Arc, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | genesis: Hash, [INFO] [stdout] 61 | stop_state: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> Result { [INFO] [stdout] 63 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | config: config.clone(), [INFO] [stdout] 65 | | capabilities, [INFO] [stdout] 66 | | handshake: Arc::new(Handshake::new(genesis, config.clone())), [INFO] [stdout] 67 | | peers: Arc::new(Peers::new(PeerStore::new(db_root)?, adapter, config)), [INFO] [stdout] 68 | | stop_state, [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:119:6 [INFO] [stdout] | [INFO] [stdout] 118 | let db = mugle_store::Store::new(db_root, Some(DB_NAME), Some(STORE_SUBPATH), None)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | Ok(PeerStore { db: db }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mugle_p2p` (lib test) due to 25 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(version: ProtocolVersion, stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | buffer: BytesMut::with_capacity(8 * 1024), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:80:11 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(version: ProtocolVersion, stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | state: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn send(&self, msg: Msg) -> Result<(), Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | match self.send_channel.try_send(msg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 175 | stream: TcpStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | version: ProtocolVersion, [INFO] [stdout] 177 | tracker: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let (send_tx, send_rx) = mpsc::sync_channel(SEND_CHANNEL_CAP); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | [INFO] [stdout] 185 | let stopped = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | [INFO] [stdout] 187 | let conn_handle = ConnHandle { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let (reader_thread, writer_thread) = poll( [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 202 | | conn_handle, [INFO] [stdout] 203 | | StopHandle { [INFO] [stdout] 204 | | stopped, [INFO] [stdout] ... | [INFO] [stdout] 207 | | }, [INFO] [stdout] 208 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 212 | conn: TcpStream, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | conn_handle: ConnHandle, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | version: ProtocolVersion, [INFO] [stdout] 215 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | send_rx: mpsc::Receiver, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | stopped: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | tracker: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let reader = conn.try_clone().expect("clone conn for reader failed"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let mut writer = conn.try_clone().expect("clone conn for writer failed"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let reader_stopped = stopped.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | [INFO] [stdout] 228 | let reader_tracker = tracker.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let writer_tracker = tracker; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | [INFO] [stdout] 231 | let reader_thread = thread::Builder::new() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | let writer_thread = thread::Builder::new() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | Ok((reader_thread, writer_thread)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg.rs:156:6 [INFO] [stdout] | [INFO] [stdout] 152 | msg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Ok(Msg { [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | header: MsgHeader::new(msg_type, body.len() as u64), [INFO] [stdout] 158 | | body, [INFO] [stdout] 159 | | attachment: None, [INFO] [stdout] 160 | | version, [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 194 | let res = T::read(&mut reader)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | Ok((res, reader.total_bytes_read())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg.rs:818:6 [INFO] [stdout] | [INFO] [stdout] 817 | let segment = Readable::read(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 818 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 819 | | block_hash, [INFO] [stdout] 820 | | segment, [INFO] [stdout] 821 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:93:6 [INFO] [stdout] | [INFO] [stdout] 80 | fn new(info: PeerInfo, conn: TcpStream, adapter: Arc) -> std::io::Result { [INFO] [stdout] | -------------- --------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let state = Arc::new(RwLock::new(State::Connected)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let state_sync_requested = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let tracking_adapter = TrackingAdapter::new(adapter); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let handler = Protocol::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let tracker = Arc::new(conn::Tracker::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (sendh, stoph) = conn::listen(conn, info.version, tracker.clone(), handler)?; [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let send_handle = Mutex::new(sendh); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let stop_handle = Mutex::new(stoph); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Ok(Peer { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | info, [INFO] [stdout] 95 | | state, [INFO] [stdout] 96 | | tracking_adapter, [INFO] [stdout] ... | [INFO] [stdout] 100 | | state_sync_requested, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:227:3 [INFO] [stdout] | [INFO] [stdout] 225 | fn send(&self, msg: T, msg_type: Type) -> Result<(), Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let msg = Msg::new(msg_type, msg, self.info.version)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | self.send_handle.lock().send(msg) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:465:14 [INFO] [stdout] | [INFO] [stdout] 462 | fn new(adapter: Arc) -> TrackingAdapter { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 465 | received: Arc::new(RwLock::new(LruCache::new(MAX_TRACK_SIZE))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:466:15 [INFO] [stdout] | [INFO] [stdout] 462 | fn new(adapter: Arc) -> TrackingAdapter { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 466 | requested: Arc::new(RwLock::new(LruCache::new(MAX_TRACK_SIZE))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(store: PeerStore, adapter: Arc, config: P2PConfig) -> Peers { [INFO] [stdout] | ---------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | peers: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:129:10 [INFO] [stdout] | [INFO] [stdout] 121 | let peers = match self.peers.try_read_for(LOCK_TIMEOUT) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Some(peers) => peers.values().cloned().collect(), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | iter: peers.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:368:27 [INFO] [stdout] | [INFO] [stdout] 368 | let outbound_peers = || self.iter().outbound().connected().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:389:26 [INFO] [stdout] | [INFO] [stdout] 389 | let inbound_peers = || self.iter().inbound().connected().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:779:10 [INFO] [stdout] | [INFO] [stdout] 777 | pub fn connected(self) -> PeersIter>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 778 | PeersIter { [INFO] [stdout] 779 | iter: self.iter.filter(|p| p.is_connected()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:786:10 [INFO] [stdout] | [INFO] [stdout] 784 | pub fn inbound(self) -> PeersIter>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 785 | PeersIter { [INFO] [stdout] 786 | iter: self.iter.filter(|p| p.info.is_inbound()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:793:10 [INFO] [stdout] | [INFO] [stdout] 791 | pub fn outbound(self) -> PeersIter>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 792 | PeersIter { [INFO] [stdout] 793 | iter: self.iter.filter(|p| p.info.is_outbound()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:808:10 [INFO] [stdout] | [INFO] [stdout] 803 | pub fn with_difficulty(self, f: F) -> PeersIter>> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 808 | iter: self.iter.filter(move |p| f(p.info.total_difficulty())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:818:10 [INFO] [stdout] | [INFO] [stdout] 814 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 818 | iter: self.iter.filter(move |p| p.info.capabilities.contains(cap)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peers.rs:834:3 [INFO] [stdout] | [INFO] [stdout] 833 | pub fn max_difficulty(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 834 | self.iter.map(|p| p.info.total_difficulty()).max() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serv.rs:63:6 [INFO] [stdout] | [INFO] [stdout] 59 | adapter: Arc, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | genesis: Hash, [INFO] [stdout] 61 | stop_state: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> Result { [INFO] [stdout] 63 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | config: config.clone(), [INFO] [stdout] 65 | | capabilities, [INFO] [stdout] 66 | | handshake: Arc::new(Handshake::new(genesis, config.clone())), [INFO] [stdout] 67 | | peers: Arc::new(Peers::new(PeerStore::new(db_root)?, adapter, config)), [INFO] [stdout] 68 | | stop_state, [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:119:6 [INFO] [stdout] | [INFO] [stdout] 118 | let db = mugle_store::Store::new(db_root, Some(DB_NAME), Some(STORE_SUBPATH), None)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | Ok(PeerStore { db: db }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mugle_p2p` (lib) due to 25 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "acff4666ae3d06064667d28f36a014d246386006447ad6a6da082de2d11ba38f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acff4666ae3d06064667d28f36a014d246386006447ad6a6da082de2d11ba38f", kill_on_drop: false }` [INFO] [stdout] acff4666ae3d06064667d28f36a014d246386006447ad6a6da082de2d11ba38f