[INFO] fetching crate mtzip 3.0.2... [INFO] checking mtzip-3.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mtzip 3.0.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mtzip 3.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mtzip 3.0.2 [INFO] finished tweaking crates.io crate mtzip 3.0.2 [INFO] tweaked toml for crates.io crate mtzip 3.0.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a48a66ba3feeb17a23efdb2c2a102a0a302696926362387be55978914b20aec [INFO] running `Command { std: "docker" "start" "-a" "1a48a66ba3feeb17a23efdb2c2a102a0a302696926362387be55978914b20aec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a48a66ba3feeb17a23efdb2c2a102a0a302696926362387be55978914b20aec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a48a66ba3feeb17a23efdb2c2a102a0a302696926362387be55978914b20aec", kill_on_drop: false }` [INFO] [stdout] 1a48a66ba3feeb17a23efdb2c2a102a0a302696926362387be55978914b20aec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe25ba40633c6d6dd0cce6e1a20f56e4ada2bfa21fc205ae89aa0efb081aca94 [INFO] running `Command { std: "docker" "start" "-a" "fe25ba40633c6d6dd0cce6e1a20f56e4ada2bfa21fc205ae89aa0efb081aca94", kill_on_drop: false }` [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking mtzip v3.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `unix` [INFO] [stdout] --> src/zip_archive_parts/job.rs:114:29 [INFO] [stdout] | [INFO] [stdout] 114 | } else if #[cfg(target_os = "unix")] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, `vxworks`, and `wasi` and 4 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `unix` [INFO] [stdout] --> src/zip_archive_parts/job.rs:114:29 [INFO] [stdout] | [INFO] [stdout] 114 | } else if #[cfg(target_os = "unix")] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, `vxworks`, and `wasi` and 4 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:28 [INFO] [stdout] | [INFO] [stdout] 340 | fn compress_with_consumer(&mut self, threads: usize, consumer: F) -> T [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let jobs_drain = Mutex::new(self.jobs_queue.drain(..)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let jobs_drain_ref = &jobs_drain; [INFO] [stdout] 346 | std::thread::scope(|s| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 347 | | let rx = { [INFO] [stdout] 348 | | let (tx, rx) = mpsc::channel(); [INFO] [stdout] 349 | | for _ in 0..threads { [INFO] [stdout] ... | [INFO] [stdout] 362 | | consumer(&mut self.data, rx) [INFO] [stdout] 363 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_archive_parts/data.rs:72:36 [INFO] [stdout] | [INFO] [stdout] 69 | zip_files_iter: I, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | self.write_files_iter(buf, zip_files.into_iter().chain(zip_files_iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_archive_parts/data.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 92 | zip_files: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | ) -> std::io::Result> { [INFO] [stdout] 94 | / zip_files [INFO] [stdout] 95 | | .into_iter() [INFO] [stdout] 96 | | .map(|zipfile| zipfile.write_local_file_header_with_data_consuming(buf)) [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_archive_parts/data.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 117 | zip_files: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / zip_files [INFO] [stdout] 121 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_archive_parts/extra_field.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 24 | pub unsafe fn new(fields: I) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | values: fields.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mtzip` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:28 [INFO] [stdout] | [INFO] [stdout] 340 | fn compress_with_consumer(&mut self, threads: usize, consumer: F) -> T [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let jobs_drain = Mutex::new(self.jobs_queue.drain(..)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let jobs_drain_ref = &jobs_drain; [INFO] [stdout] 346 | std::thread::scope(|s| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 347 | | let rx = { [INFO] [stdout] 348 | | let (tx, rx) = mpsc::channel(); [INFO] [stdout] 349 | | for _ in 0..threads { [INFO] [stdout] ... | [INFO] [stdout] 362 | | consumer(&mut self.data, rx) [INFO] [stdout] 363 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_archive_parts/data.rs:72:36 [INFO] [stdout] | [INFO] [stdout] 69 | zip_files_iter: I, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | self.write_files_iter(buf, zip_files.into_iter().chain(zip_files_iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_archive_parts/data.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 92 | zip_files: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | ) -> std::io::Result> { [INFO] [stdout] 94 | / zip_files [INFO] [stdout] 95 | | .into_iter() [INFO] [stdout] 96 | | .map(|zipfile| zipfile.write_local_file_header_with_data_consuming(buf)) [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_archive_parts/data.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 117 | zip_files: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / zip_files [INFO] [stdout] 121 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_archive_parts/extra_field.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 24 | pub unsafe fn new(fields: I) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | values: fields.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mtzip` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "fe25ba40633c6d6dd0cce6e1a20f56e4ada2bfa21fc205ae89aa0efb081aca94", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe25ba40633c6d6dd0cce6e1a20f56e4ada2bfa21fc205ae89aa0efb081aca94", kill_on_drop: false }` [INFO] [stdout] fe25ba40633c6d6dd0cce6e1a20f56e4ada2bfa21fc205ae89aa0efb081aca94