[INFO] fetching crate mtrack 0.1.3... [INFO] checking mtrack-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mtrack 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate mtrack 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mtrack 0.1.3 [INFO] finished tweaking crates.io crate mtrack 0.1.3 [INFO] tweaked toml for crates.io crate mtrack 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate mtrack 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eda625a126a7e33058f1e86c0c478a1a98cba4fe80c4f2d6514ed389eaa59297 [INFO] running `Command { std: "docker" "start" "-a" "eda625a126a7e33058f1e86c0c478a1a98cba4fe80c4f2d6514ed389eaa59297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eda625a126a7e33058f1e86c0c478a1a98cba4fe80c4f2d6514ed389eaa59297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eda625a126a7e33058f1e86c0c478a1a98cba4fe80c4f2d6514ed389eaa59297", kill_on_drop: false }` [INFO] [stdout] eda625a126a7e33058f1e86c0c478a1a98cba4fe80c4f2d6514ed389eaa59297 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6088a49f6c71668ee793da518be5f11bf9a2eed5e0a7c2f37de1011a1abe85c0 [INFO] running `Command { std: "docker" "start" "-a" "6088a49f6c71668ee793da518be5f11bf9a2eed5e0a7c2f37de1011a1abe85c0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking termion v3.0.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking shh v1.0.1 [INFO] [stderr] Checking ringbuf v0.3.3 [INFO] [stderr] Checking midir v0.9.1 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking midly v0.5.3 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking nodi v1.0.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking serde_yaml v0.9.21 [INFO] [stderr] Checking mtrack v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 57 | let mut songs: HashMap> = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Arc::new(crate::songs::Songs::new(songs))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 114 | songs: Arc, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok(Arc::new(crate::playlist::Playlist::new( [INFO] [stdout] | ________^ [INFO] [stdout] 118 | | playlist.songs, [INFO] [stdout] 119 | | songs, [INFO] [stdout] 120 | | )?)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(player: Player, driver: Arc) -> Result> { [INFO] [stdout] | -------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(Controller { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | handle: tokio::spawn(async move { Controller::trigger_events(player, driver).await }), [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:65:90 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(player: Player, driver: Arc) -> Result> { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(Controller { [INFO] [stdout] 65 | handle: tokio::spawn(async move { Controller::trigger_events(player, driver).await }), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/keyboard.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 31 | fn monitor_events(&self, events_tx: Sender) -> JoinHandle> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 33 | | let span = span!(Level::INFO, "keyboard driver"); [INFO] [stdout] 34 | | let _enter = span.enter(); [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:77:37 [INFO] [stdout] | [INFO] [stdout] 67 | fn monitor_events(&self, events_tx: Sender) -> JoinHandle> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let (midi_events_tx, mut midi_events_rx) = mpsc::channel::>(10); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let device = self.device.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 78 | | let span = span!(Level::INFO, "MIDI driver"); [INFO] [stdout] 79 | | let _enter = span.enter(); [INFO] [stdout] ... | [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi/midir.rs:296:8 [INFO] [stdout] | [INFO] [stdout] 275 | let mut matches = list_midir_devices()? [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | Ok(matches.swap_remove(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(song_names: Vec, registry: Arc) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Playlist { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | songs: song_names, [INFO] [stdout] 57 | | position: Arc::new(RwLock::new(0)), [INFO] [stdout] 58 | | registry: Arc::clone(®istry), [INFO] [stdout] 59 | | span: span!(Level::INFO, "playlist"), [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn from_songs(songs: Arc) -> Result, Box> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(Arc::new(Playlist::new(sorted, songs)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 123 | let position = self.position.read().expect("unable to get lock"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Arc::clone( [INFO] [stdout] 125 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | .registry [INFO] [stdout] 127 | | .get(&self.songs[*position]) [INFO] [stdout] 128 | | .expect("unable to find song in the registry"), [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/songs.rs:384:23 [INFO] [stdout] | [INFO] [stdout] 380 | mut decoder_and_mappings: Vec, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | mut prod: HeapProducer, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | finished: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | ) -> JoinHandle<()> { [INFO] [stdout] 384 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 385 | | // The number of frames to read at a time from the source. We'll make it one quarter of the total capacity. [INFO] [stdout] 386 | | let num_frames = prod.capacity() / num_channels / 2; [INFO] [stdout] 387 | | let num_sources = decoder_and_mappings.len(); [INFO] [stdout] ... | [INFO] [stdout] 466 | | } [INFO] [stdout] 467 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mtrack` (bin "mtrack") due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 57 | let mut songs: HashMap> = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Arc::new(crate::songs::Songs::new(songs))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 114 | songs: Arc, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok(Arc::new(crate::playlist::Playlist::new( [INFO] [stdout] | ________^ [INFO] [stdout] 118 | | playlist.songs, [INFO] [stdout] 119 | | songs, [INFO] [stdout] 120 | | )?)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(player: Player, driver: Arc) -> Result> { [INFO] [stdout] | -------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(Controller { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | handle: tokio::spawn(async move { Controller::trigger_events(player, driver).await }), [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:65:90 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new(player: Player, driver: Arc) -> Result> { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(Controller { [INFO] [stdout] 65 | handle: tokio::spawn(async move { Controller::trigger_events(player, driver).await }), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/keyboard.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 31 | fn monitor_events(&self, events_tx: Sender) -> JoinHandle> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 33 | | let span = span!(Level::INFO, "keyboard driver"); [INFO] [stdout] 34 | | let _enter = span.enter(); [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:77:37 [INFO] [stdout] | [INFO] [stdout] 67 | fn monitor_events(&self, events_tx: Sender) -> JoinHandle> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let (midi_events_tx, mut midi_events_rx) = mpsc::channel::>(10); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let device = self.device.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 78 | | let span = span!(Level::INFO, "MIDI driver"); [INFO] [stdout] 79 | | let _enter = span.enter(); [INFO] [stdout] ... | [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | || playlist.current().name == "Song 1", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:237:16 [INFO] [stdout] | [INFO] [stdout] 237 | || playlist.current().name == "Song 3", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:243:16 [INFO] [stdout] | [INFO] [stdout] 243 | || playlist.current().name == "Song 5", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:249:16 [INFO] [stdout] | [INFO] [stdout] 249 | || playlist.current().name == "Song 7", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:255:16 [INFO] [stdout] | [INFO] [stdout] 255 | || playlist.current().name == "Song 5", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:261:16 [INFO] [stdout] | [INFO] [stdout] 261 | || all_songs_playlist.current().name == "Song 1", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:267:16 [INFO] [stdout] | [INFO] [stdout] 267 | || all_songs_playlist.current().name == "Song 10", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:273:16 [INFO] [stdout] | [INFO] [stdout] 273 | || all_songs_playlist.current().name == "Song 2", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:279:16 [INFO] [stdout] | [INFO] [stdout] 279 | || all_songs_playlist.current().name == "Song 10", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:285:16 [INFO] [stdout] | [INFO] [stdout] 285 | || playlist.current().name == "Song 5", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/midi.rs:291:16 [INFO] [stdout] | [INFO] [stdout] 291 | || playlist.current().name == "Song 7", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:245:16 [INFO] [stdout] | [INFO] [stdout] 245 | || playlist.current().name == "Song 1", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:251:16 [INFO] [stdout] | [INFO] [stdout] 251 | || playlist.current().name == "Song 3", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:257:16 [INFO] [stdout] | [INFO] [stdout] 257 | || playlist.current().name == "Song 5", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:263:16 [INFO] [stdout] | [INFO] [stdout] 263 | || playlist.current().name == "Song 7", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:269:16 [INFO] [stdout] | [INFO] [stdout] 269 | || playlist.current().name == "Song 5", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:275:16 [INFO] [stdout] | [INFO] [stdout] 275 | || all_songs_playlist.current().name == "Song 1", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:281:16 [INFO] [stdout] | [INFO] [stdout] 281 | || all_songs_playlist.current().name == "Song 10", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:287:16 [INFO] [stdout] | [INFO] [stdout] 287 | || all_songs_playlist.current().name == "Song 2", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:293:16 [INFO] [stdout] | [INFO] [stdout] 293 | || all_songs_playlist.current().name == "Song 10", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 299 | || playlist.current().name == "Song 5", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:305:16 [INFO] [stdout] | [INFO] [stdout] 305 | || playlist.current().name == "Song 7", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi/midir.rs:296:8 [INFO] [stdout] | [INFO] [stdout] 275 | let mut matches = list_midir_devices()? [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | Ok(matches.swap_remove(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:464:16 [INFO] [stdout] | [INFO] [stdout] 464 | || player.get_playlist().current().name == "Song 5", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(song_names: Vec, registry: Arc) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Playlist { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | songs: song_names, [INFO] [stdout] 57 | | position: Arc::new(RwLock::new(0)), [INFO] [stdout] 58 | | registry: Arc::clone(®istry), [INFO] [stdout] 59 | | span: span!(Level::INFO, "playlist"), [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn from_songs(songs: Arc) -> Result, Box> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(Arc::new(Playlist::new(sorted, songs)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 123 | let position = self.position.read().expect("unable to get lock"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Arc::clone( [INFO] [stdout] 125 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | .registry [INFO] [stdout] 127 | | .get(&self.songs[*position]) [INFO] [stdout] 128 | | .expect("unable to find song in the registry"), [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/songs.rs:384:23 [INFO] [stdout] | [INFO] [stdout] 380 | mut decoder_and_mappings: Vec, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | mut prod: HeapProducer, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | finished: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | ) -> JoinHandle<()> { [INFO] [stdout] 384 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 385 | | // The number of frames to read at a time from the source. We'll make it one quarter of the total capacity. [INFO] [stdout] 386 | | let num_frames = prod.capacity() / num_channels / 2; [INFO] [stdout] 387 | | let num_sources = decoder_and_mappings.len(); [INFO] [stdout] ... | [INFO] [stdout] 466 | | } [INFO] [stdout] 467 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 34 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mtrack` (bin "mtrack" test) due to 35 previous errors [INFO] running `Command { std: "docker" "inspect" "6088a49f6c71668ee793da518be5f11bf9a2eed5e0a7c2f37de1011a1abe85c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6088a49f6c71668ee793da518be5f11bf9a2eed5e0a7c2f37de1011a1abe85c0", kill_on_drop: false }` [INFO] [stdout] 6088a49f6c71668ee793da518be5f11bf9a2eed5e0a7c2f37de1011a1abe85c0