[INFO] fetching crate mtgapi-client 0.2.0... [INFO] checking mtgapi-client-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mtgapi-client 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mtgapi-client 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mtgapi-client 0.2.0 [INFO] finished tweaking crates.io crate mtgapi-client 0.2.0 [INFO] tweaked toml for crates.io crate mtgapi-client 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 168 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.11.0 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.12.3 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding core-foundation v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding core-foundation-sys v0.7.0 (latest: v0.8.7) [INFO] [stderr] Adding ct-logs v0.6.0 (latest: v0.9.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.2.7 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.3.1 (latest: v1.0.1) [INFO] [stderr] Adding httpdate v0.3.2 (latest: v1.0.3) [INFO] [stderr] Adding hyper v0.13.10 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.20.0 (latest: v0.27.2) [INFO] [stderr] Adding hyper-rustls v0.21.0 (latest: v0.27.2) [INFO] [stderr] Adding hyper-tls v0.4.3 (latest: v0.6.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.9.0 (latest: v0.13.0) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding reqwest v0.10.10 (latest: v0.12.7) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.17.0 (latest: v0.23.12) [INFO] [stderr] Adding rustls v0.18.1 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.3.0 (latest: v0.8.0) [INFO] [stderr] Adding sct v0.6.1 (latest: v0.7.1) [INFO] [stderr] Adding security-framework v0.4.4 (latest: v2.11.1) [INFO] [stderr] Adding security-framework-sys v0.4.3 (latest: v2.11.1) [INFO] [stderr] Adding socket2 v0.3.19 (latest: v0.5.7) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-rustls v0.13.1 (latest: v0.26.0) [INFO] [stderr] Adding tokio-rustls v0.14.1 (latest: v0.26.0) [INFO] [stderr] Adding tokio-util v0.3.1 (latest: v0.7.11) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding webpki v0.21.4 (latest: v0.22.4) [INFO] [stderr] Adding webpki-roots v0.20.0 (latest: v0.26.5) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winreg v0.7.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa156ebef08fd875afffa4e5f054a23545074ec73c00aceb3fa353a17e3b5b0f [INFO] running `Command { std: "docker" "start" "-a" "aa156ebef08fd875afffa4e5f054a23545074ec73c00aceb3fa353a17e3b5b0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa156ebef08fd875afffa4e5f054a23545074ec73c00aceb3fa353a17e3b5b0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa156ebef08fd875afffa4e5f054a23545074ec73c00aceb3fa353a17e3b5b0f", kill_on_drop: false }` [INFO] [stdout] aa156ebef08fd875afffa4e5f054a23545074ec73c00aceb3fa353a17e3b5b0f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 247ebe54f1f2f85accd418c06c27e39483fa3e216864173bf50a089e8672d205 [INFO] running `Command { std: "docker" "start" "-a" "247ebe54f1f2f85accd418c06c27e39483fa3e216864173bf50a089e8672d205", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking openssl-sys v0.9.103 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking ct-logs v0.6.0 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking rustls v0.18.1 [INFO] [stderr] Checking rustls v0.17.0 [INFO] [stderr] Checking webpki-roots v0.20.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking rustls-native-certs v0.3.0 [INFO] [stderr] Checking tokio-rustls v0.13.1 [INFO] [stderr] Checking tokio-rustls v0.14.1 [INFO] [stderr] Checking h2 v0.2.7 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking tokio-tls v0.3.1 [INFO] [stderr] Checking hyper v0.13.10 [INFO] [stderr] Checking hyper-tls v0.4.3 [INFO] [stderr] Checking hyper-rustls v0.21.0 [INFO] [stderr] Checking hyper-rustls v0.20.0 [INFO] [stderr] Checking reqwest v0.10.10 [INFO] [stderr] Checking mtgapi-client v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/card/card_api.rs:62:18 [INFO] [stdout] | [INFO] [stdout] 60 | fn new(client: Weak, api_url: &str, page_size: u32) -> Box { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let url = [api_url, "cards"].join("/"); [INFO] [stdout] 62 | Box::new(AllCardsRequest { [INFO] [stdout] | __________________^ [INFO] [stdout] 63 | | page: 1, [INFO] [stdout] 64 | | client, [INFO] [stdout] 65 | | url, [INFO] [stdout] ... | [INFO] [stdout] 68 | | order_by: CardResponseField::Name, [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/card/card_api.rs:79:18 [INFO] [stdout] | [INFO] [stdout] 73 | client: Weak, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Box::new(AllCardsRequest { [INFO] [stdout] | __________________^ [INFO] [stdout] 80 | | page: 1, [INFO] [stdout] 81 | | client, [INFO] [stdout] 82 | | url, [INFO] [stdout] ... | [INFO] [stdout] 85 | | order_by: CardResponseField::Name, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/card/card_api.rs:62:18 [INFO] [stdout] | [INFO] [stdout] 60 | fn new(client: Weak, api_url: &str, page_size: u32) -> Box { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let url = [api_url, "cards"].join("/"); [INFO] [stdout] 62 | Box::new(AllCardsRequest { [INFO] [stdout] | __________________^ [INFO] [stdout] 63 | | page: 1, [INFO] [stdout] 64 | | client, [INFO] [stdout] 65 | | url, [INFO] [stdout] ... | [INFO] [stdout] 68 | | order_by: CardResponseField::Name, [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/card/card_api.rs:79:18 [INFO] [stdout] | [INFO] [stdout] 73 | client: Weak, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Box::new(AllCardsRequest { [INFO] [stdout] | __________________^ [INFO] [stdout] 80 | | page: 1, [INFO] [stdout] 81 | | client, [INFO] [stdout] 82 | | url, [INFO] [stdout] ... | [INFO] [stdout] 85 | | order_by: CardResponseField::Name, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mtgapi-client` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mtgapi-client` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "247ebe54f1f2f85accd418c06c27e39483fa3e216864173bf50a089e8672d205", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "247ebe54f1f2f85accd418c06c27e39483fa3e216864173bf50a089e8672d205", kill_on_drop: false }` [INFO] [stdout] 247ebe54f1f2f85accd418c06c27e39483fa3e216864173bf50a089e8672d205