[INFO] fetching crate msrs 0.1.31... [INFO] checking msrs-0.1.31 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate msrs 0.1.31 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate msrs 0.1.31 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate msrs 0.1.31 [INFO] finished tweaking crates.io crate msrs 0.1.31 [INFO] tweaked toml for crates.io crate msrs 0.1.31 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 99 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num_enum v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding rdkafka v0.32.2 (latest: v0.36.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2262a3a39a3f36d26fd9aacfb9c4f2ea1dc32c39e0f4bee68727820b668392b9 [INFO] running `Command { std: "docker" "start" "-a" "2262a3a39a3f36d26fd9aacfb9c4f2ea1dc32c39e0f4bee68727820b668392b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2262a3a39a3f36d26fd9aacfb9c4f2ea1dc32c39e0f4bee68727820b668392b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2262a3a39a3f36d26fd9aacfb9c4f2ea1dc32c39e0f4bee68727820b668392b9", kill_on_drop: false }` [INFO] [stdout] 2262a3a39a3f36d26fd9aacfb9c4f2ea1dc32c39e0f4bee68727820b668392b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65dc4b3b0c815afda30963f4b1754ee945c58006e5cc309439a174277beed7f0 [INFO] running `Command { std: "docker" "start" "-a" "65dc4b3b0c815afda30963f4b1754ee945c58006e5cc309439a174277beed7f0", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling rdkafka-sys v4.7.0+2.3.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking rdkafka v0.32.2 [INFO] [stderr] Checking msrs v0.1.31 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication/client.rs:193:39 [INFO] [stdout] | [INFO] [stdout] 192 | _predicate: Box bool + Send + Sync>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 194 | | let data_read = self.sent_data.read().unwrap(); [INFO] [stdout] 195 | | Ok(MsMessage(None, data_read[0].clone())) [INFO] [stdout] 196 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/kafka/kafka.rs:177:39 [INFO] [stdout] | [INFO] [stdout] 176 | predicate: Box bool + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 178 | | let event_reply = format!("{}.reply", event.to_string().clone()); [INFO] [stdout] 179 | | self.create_topic_if_not_exists(&event_reply).await; [INFO] [stdout] ... | [INFO] [stdout] 284 | | } [INFO] [stdout] 285 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/mock_transport.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 36 | predicate: Box bool + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 38 | | let data = self.data.read().unwrap().clone(); [INFO] [stdout] 39 | | if predicate(MsMessage(None, data)) { [INFO] [stdout] 40 | | Ok(MsMessage(None, self.data.read().unwrap().clone())) [INFO] [stdout] ... | [INFO] [stdout] 43 | | } [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transportv2/kafka.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 173 | async fn send_event(&self, event_name: String, event: Event) -> Result<(), MsRsError> [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | / { [INFO] [stdout] 177 | | let mut client = ClientConfig::new(); [INFO] [stdout] 178 | | client = client [INFO] [stdout] 179 | | .set("bootstrap.servers", &self.kafka_brokers) [INFO] [stdout] ... | [INFO] [stdout] 198 | | Ok(()) [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transportv2/kafka.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 204 | req: Request, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | / { [INFO] [stdout] 210 | | let reply_topic = format!("{method}.reply"); [INFO] [stdout] 211 | | let request_id: String = thread_rng() [INFO] [stdout] 212 | | .sample_iter(&Alphanumeric) [INFO] [stdout] ... | [INFO] [stdout] 308 | | Ok(response) [INFO] [stdout] 309 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transportv2/kafka.rs:319:5 [INFO] [stdout] | [INFO] [stdout] 314 | channel: RequestResponseChannel, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | / { [INFO] [stdout] 320 | | let reply_topic = format!("{method}.reply"); [INFO] [stdout] 321 | | let mut client = ClientConfig::new(); [INFO] [stdout] 322 | | client = client [INFO] [stdout] ... | [INFO] [stdout] 497 | | } [INFO] [stdout] 498 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `msrs` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication/client.rs:193:39 [INFO] [stdout] | [INFO] [stdout] 192 | _predicate: Box bool + Send + Sync>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 194 | | let data_read = self.sent_data.read().unwrap(); [INFO] [stdout] 195 | | Ok(MsMessage(None, data_read[0].clone())) [INFO] [stdout] 196 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication/client.rs:240:16 [INFO] [stdout] | [INFO] [stdout] 222 | let transport = Arc::new(MockTransport::_new()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let event = Client::new(transport.clone(), true); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | assert_eq!(transport.clone().reply_results.read().unwrap().len(), 1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/kafka/kafka.rs:177:39 [INFO] [stdout] | [INFO] [stdout] 176 | predicate: Box bool + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 178 | | let event_reply = format!("{}.reply", event.to_string().clone()); [INFO] [stdout] 179 | | self.create_topic_if_not_exists(&event_reply).await; [INFO] [stdout] ... | [INFO] [stdout] 284 | | } [INFO] [stdout] 285 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/mock_transport.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 36 | predicate: Box bool + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 38 | | let data = self.data.read().unwrap().clone(); [INFO] [stdout] 39 | | if predicate(MsMessage(None, data)) { [INFO] [stdout] 40 | | Ok(MsMessage(None, self.data.read().unwrap().clone())) [INFO] [stdout] ... | [INFO] [stdout] 43 | | } [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transportv2/kafka.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 173 | async fn send_event(&self, event_name: String, event: Event) -> Result<(), MsRsError> [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | / { [INFO] [stdout] 177 | | let mut client = ClientConfig::new(); [INFO] [stdout] 178 | | client = client [INFO] [stdout] 179 | | .set("bootstrap.servers", &self.kafka_brokers) [INFO] [stdout] ... | [INFO] [stdout] 198 | | Ok(()) [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transportv2/kafka.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 204 | req: Request, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | / { [INFO] [stdout] 210 | | let reply_topic = format!("{method}.reply"); [INFO] [stdout] 211 | | let request_id: String = thread_rng() [INFO] [stdout] 212 | | .sample_iter(&Alphanumeric) [INFO] [stdout] ... | [INFO] [stdout] 308 | | Ok(response) [INFO] [stdout] 309 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transportv2/kafka.rs:319:5 [INFO] [stdout] | [INFO] [stdout] 314 | channel: RequestResponseChannel, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | / { [INFO] [stdout] 320 | | let reply_topic = format!("{method}.reply"); [INFO] [stdout] 321 | | let mut client = ClientConfig::new(); [INFO] [stdout] 322 | | client = client [INFO] [stdout] ... | [INFO] [stdout] 497 | | } [INFO] [stdout] 498 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `msrs` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "65dc4b3b0c815afda30963f4b1754ee945c58006e5cc309439a174277beed7f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65dc4b3b0c815afda30963f4b1754ee945c58006e5cc309439a174277beed7f0", kill_on_drop: false }` [INFO] [stdout] 65dc4b3b0c815afda30963f4b1754ee945c58006e5cc309439a174277beed7f0