[INFO] fetching crate mser_macro 1.0.10... [INFO] checking mser_macro-1.0.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mser_macro 1.0.10 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate mser_macro 1.0.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mser_macro 1.0.10 [INFO] finished tweaking crates.io crate mser_macro 1.0.10 [INFO] tweaked toml for crates.io crate mser_macro 1.0.10 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64acc3de5832aa343db44545945c21b4b20a2ed0c56b474690b0497090463764 [INFO] running `Command { std: "docker" "start" "-a" "64acc3de5832aa343db44545945c21b4b20a2ed0c56b474690b0497090463764", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64acc3de5832aa343db44545945c21b4b20a2ed0c56b474690b0497090463764", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64acc3de5832aa343db44545945c21b4b20a2ed0c56b474690b0497090463764", kill_on_drop: false }` [INFO] [stdout] 64acc3de5832aa343db44545945c21b4b20a2ed0c56b474690b0497090463764 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 275f7eedaf30714165b33ec3b23d8d14bf9ec99da7a0e04cc39e556b0901171e [INFO] running `Command { std: "docker" "start" "-a" "275f7eedaf30714165b33ec3b23d8d14bf9ec99da7a0e04cc39e556b0901171e", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking mser v1.1.4 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking mser_macro v1.0.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:421:23 [INFO] [stdout] | [INFO] [stdout] 421 | } else if let Some(attr) = parse_struct_attribute(&input, &lookahead)? { [INFO] [stdout] | ^^^^^^^^^^ matches no values because `StructAttribute` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:450:16 [INFO] [stdout] | [INFO] [stdout] 450 | if let Some(attr) = parse_struct_attribute(&input, &lookahead)? { [INFO] [stdout] | ^^^^^^^^^^ matches no values because `StructAttribute` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:421:23 [INFO] [stdout] | [INFO] [stdout] 421 | } else if let Some(attr) = parse_struct_attribute(&input, &lookahead)? { [INFO] [stdout] | ^^^^^^^^^^ matches no values because `StructAttribute` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:506:9 [INFO] [stdout] | [INFO] [stdout] 506 | for _attr in attrs {} [INFO] [stdout] | ^^^^^ matches no values because `StructAttribute` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:525:13 [INFO] [stdout] | [INFO] [stdout] 525 | ToplevelStructAttribute::StructAttribute(attr) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `StructAttribute` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:450:16 [INFO] [stdout] | [INFO] [stdout] 450 | if let Some(attr) = parse_struct_attribute(&input, &lookahead)? { [INFO] [stdout] | ^^^^^^^^^^ matches no values because `StructAttribute` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:506:9 [INFO] [stdout] | [INFO] [stdout] 506 | for _attr in attrs {} [INFO] [stdout] | ^^^^^ matches no values because `StructAttribute` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:525:13 [INFO] [stdout] | [INFO] [stdout] 525 | ToplevelStructAttribute::StructAttribute(attr) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `StructAttribute` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn compound(token: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut data = format!("{{{token}}}"); [INFO] [stdout] 22 | let output = mser::nbt::StringifyCompound::decode(&data).expect("Invalid SNBT compound").0; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | core::str::FromStr::from_str(&datastr).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:479:16 [INFO] [stdout] | [INFO] [stdout] 477 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | parenthesized!(content in input); [INFO] [stdout] 479 | Ok(RawAttributes( [INFO] [stdout] | ________________^ [INFO] [stdout] 480 | | content.parse_terminated(T::parse, Token![,])?, [INFO] [stdout] 481 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:532:8 [INFO] [stdout] | [INFO] [stdout] 512 | attrs: Vec, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let mut prefix = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | Ok(ToplevelStructAttributes { [INFO] [stdout] | ________^ [INFO] [stdout] 533 | | prefix, [INFO] [stdout] 534 | | struct_attributes, [INFO] [stdout] 535 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:838:53 [INFO] [stdout] | [INFO] [stdout] 838 | parse_special_ty(ty).unwrap_or_else(|| Ty::Type(ty.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1086:8 [INFO] [stdout] | [INFO] [stdout] 1022 | let mut add = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1063 | let ty = if let Some(ty) = extract_option_inner_ty(&field.ty) { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1086 | Ok(Field { [INFO] [stdout] | ________^ [INFO] [stdout] 1087 | | index, [INFO] [stdout] 1088 | | name: field.ident.as_ref(), [INFO] [stdout] 1089 | | raw_ty: &field.ty, [INFO] [stdout] ... | [INFO] [stdout] 1095 | | add, [INFO] [stdout] 1096 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn compound(token: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut data = format!("{{{token}}}"); [INFO] [stdout] 22 | let output = mser::nbt::StringifyCompound::decode(&data).expect("Invalid SNBT compound").0; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | core::str::FromStr::from_str(&datastr).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:479:16 [INFO] [stdout] | [INFO] [stdout] 477 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | parenthesized!(content in input); [INFO] [stdout] 479 | Ok(RawAttributes( [INFO] [stdout] | ________________^ [INFO] [stdout] 480 | | content.parse_terminated(T::parse, Token![,])?, [INFO] [stdout] 481 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:532:8 [INFO] [stdout] | [INFO] [stdout] 512 | attrs: Vec, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let mut prefix = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | Ok(ToplevelStructAttributes { [INFO] [stdout] | ________^ [INFO] [stdout] 533 | | prefix, [INFO] [stdout] 534 | | struct_attributes, [INFO] [stdout] 535 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:838:53 [INFO] [stdout] | [INFO] [stdout] 838 | parse_special_ty(ty).unwrap_or_else(|| Ty::Type(ty.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1086:8 [INFO] [stdout] | [INFO] [stdout] 1022 | let mut add = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1063 | let ty = if let Some(ty) = extract_option_inner_ty(&field.ty) { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1086 | Ok(Field { [INFO] [stdout] | ________^ [INFO] [stdout] 1087 | | index, [INFO] [stdout] 1088 | | name: field.ident.as_ref(), [INFO] [stdout] 1089 | | raw_ty: &field.ty, [INFO] [stdout] ... | [INFO] [stdout] 1095 | | add, [INFO] [stdout] 1096 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mser_macro` (lib test) due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `mser_macro` (lib) due to 6 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "275f7eedaf30714165b33ec3b23d8d14bf9ec99da7a0e04cc39e556b0901171e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "275f7eedaf30714165b33ec3b23d8d14bf9ec99da7a0e04cc39e556b0901171e", kill_on_drop: false }` [INFO] [stdout] 275f7eedaf30714165b33ec3b23d8d14bf9ec99da7a0e04cc39e556b0901171e