[INFO] fetching crate mry 0.8.0... [INFO] checking mry-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mry 0.8.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mry 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mry 0.8.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate mry 0.8.0 [INFO] tweaked toml for crates.io crate mry 0.8.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 112 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64c23b95728bef949945ab3399a401afc6333cc398b241af693f175d51fcddd5 [INFO] running `Command { std: "docker" "start" "-a" "64c23b95728bef949945ab3399a401afc6333cc398b241af693f175d51fcddd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64c23b95728bef949945ab3399a401afc6333cc398b241af693f175d51fcddd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64c23b95728bef949945ab3399a401afc6333cc398b241af693f175d51fcddd5", kill_on_drop: false }` [INFO] [stdout] 64c23b95728bef949945ab3399a401afc6333cc398b241af693f175d51fcddd5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a996a9469360452cff2c3ce2cd50ea74832223a71eeca2391c23cffaf71afc5e [INFO] running `Command { std: "docker" "start" "-a" "a996a9469360452cff2c3ce2cd50ea74832223a71eeca2391c23cffaf71afc5e", kill_on_drop: false }` [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling mry_macros v0.8.0 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling trait-variant v0.1.2 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking mry v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock/mod.rs:36:36 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) fn returns_once(&mut self, matcher: Arc>>, ret: O) { [INFO] [stdout] | ------------------------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | self.returns_with(matcher, Behavior::Once(Mutex::new(Some(ret)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock/mod.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 39 | pub(crate) fn calls_real_impl(&mut self, matcher: Arc>>) { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | self.rules.push(Rule { [INFO] [stdout] | _________________________^ [INFO] [stdout] 41 | | matcher, [INFO] [stdout] 42 | | behavior: Behavior::CallsRealImpl, [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock/mod.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 80 | pub(crate) fn returns(&mut self, matcher: Arc>>, ret: O) { [INFO] [stdout] | ------------------------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.returns_with(matcher, Behavior::Const(Mutex::new(Box::new(repeat(ret))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock/log.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | .filter(|log| matcher.matches(&log.lock())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock_locator.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 26 | mocks: Arc>>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | matcher: Matcher, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | matcher: Arc::new(Mutex::new(matcher)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mry.rs:58:38 [INFO] [stdout] | [INFO] [stdout] 56 | input: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | ) -> Option { [INFO] [stdout] 58 | self.mocks.as_ref().and_then(|mocks| { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 59 | | mocks [INFO] [stdout] 60 | | .lock() [INFO] [stdout] 61 | | .record_call_and_find_mock_output(key, name, input) [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mry.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 56 | input: I, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | / mocks [INFO] [stdout] 60 | | .lock() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule/matcher.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) fn new_eq(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | ArgMatcher::Fn(Box::new(move |input| *input == value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/static_mocks.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 27 | input: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | ) -> Option { [INFO] [stdout] 29 | STATIC_MOCKS.with(|mocks| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 30 | | mocks [INFO] [stdout] 31 | | .lock() [INFO] [stdout] 32 | | .record_call_and_find_mock_output(key, name, input) [INFO] [stdout] 33 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/static_mocks.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 27 | input: I, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | / mocks [INFO] [stdout] 31 | | .lock() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/static_mocks.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|lock| lock.try_lock().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/static_mocks.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | mutex: STATIC_MOCK_LOCKS.with(|locks| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 122 | | locks [INFO] [stdout] 123 | | .lock() [INFO] [stdout] 124 | | .entry(key) [INFO] [stdout] 125 | | .or_insert(Arc::new(Default::default())) [INFO] [stdout] 126 | | .clone() [INFO] [stdout] 127 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mry` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a996a9469360452cff2c3ce2cd50ea74832223a71eeca2391c23cffaf71afc5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a996a9469360452cff2c3ce2cd50ea74832223a71eeca2391c23cffaf71afc5e", kill_on_drop: false }` [INFO] [stdout] a996a9469360452cff2c3ce2cd50ea74832223a71eeca2391c23cffaf71afc5e