[INFO] fetching crate mqttrust_core 0.6.0... [INFO] checking mqttrust_core-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mqttrust_core 0.6.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate mqttrust_core 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mqttrust_core 0.6.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate mqttrust_core 0.6.0 [INFO] tweaked toml for crates.io crate mqttrust_core 0.6.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate mqttrust_core 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e17036f03d0734f721398e24be102b6100ff7df679befaf01305d5cae28814f [INFO] running `Command { std: "docker" "start" "-a" "5e17036f03d0734f721398e24be102b6100ff7df679befaf01305d5cae28814f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e17036f03d0734f721398e24be102b6100ff7df679befaf01305d5cae28814f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e17036f03d0734f721398e24be102b6100ff7df679befaf01305d5cae28814f", kill_on_drop: false }` [INFO] [stdout] 5e17036f03d0734f721398e24be102b6100ff7df679befaf01305d5cae28814f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 33a86e5644dd2c8dc4cec7b94211be50f00ce5b103e9ca7f5cb67337df2d071a [INFO] running `Command { std: "docker" "start" "-a" "33a86e5644dd2c8dc4cec7b94211be50f00ce5b103e9ca7f5cb67337df2d071a", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.14 [INFO] [stderr] Compiling libc v0.2.133 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.100 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling paste v1.0.9 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking nb v1.0.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Checking once_cell v1.15.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking no-std-net v0.5.0 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking spin v0.9.4 [INFO] [stderr] Checking bbqueue v0.5.1 [INFO] [stderr] Checking embedded-hal v1.0.0-alpha.8 [INFO] [stderr] Checking gcd v2.1.0 [INFO] [stderr] Compiling heapless v0.7.16 [INFO] [stderr] Checking fugit v0.3.6 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking fugit-timer v0.1.3 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking dns-lookup v1.0.8 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking embedded-nal v0.6.0 [INFO] [stderr] Checking mqttrust v0.6.0 [INFO] [stderr] Checking mqttrust_core v0.6.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking env_logger v0.9.1 [INFO] [stdout] warning: creating a mutable reference to mutable static is discouraged [INFO] [stdout] --> src/state.rs:84:41 [INFO] [stdout] | [INFO] [stdout] 84 | BoxedPublish::grow(unsafe { &mut PUBLISH_MEM }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of_mut!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 84 | BoxedPublish::grow(unsafe { addr_of_mut!(PUBLISH_MEM) }); [INFO] [stdout] | ~~~~~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `into_result` is never used [INFO] [stdout] --> src/fmt.rs:226:8 [INFO] [stdout] | [INFO] [stdout] 223 | pub trait Try { [INFO] [stdout] | --- method in this trait [INFO] [stdout] ... [INFO] [stdout] 226 | fn into_result(self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eventloop.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 35 | outgoing_timer: O, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | state: MqttState::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eventloop.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 35 | outgoing_timer: O, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | network_handle: NetworkHandle::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eventloop.rs:174:28 [INFO] [stdout] | [INFO] [stdout] 152 | let (notification, packet) = self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | notification.ok_or(nb::Error::WouldBlock) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eventloop.rs:258:43 [INFO] [stdout] | [INFO] [stdout] 258 | Ok(n.map(|n| n == Notification::ConnAck).unwrap_or(false)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eventloop.rs:519:15 [INFO] [stdout] | [INFO] [stdout] 515 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | match decode_slice(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:148:28 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|()| (Notification::ConnAck.into(), None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 225 | let notification = Some(Notification::Suback(suback.pid)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Ok((notification, request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 235 | let notification = Some(Notification::Unsuback(pid)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | Ok((notification, request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:292:12 [INFO] [stdout] | [INFO] [stdout] 272 | let boxed_publish = BoxedPublish::alloc().unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | #[cfg(not(feature = "std"))] [INFO] [stdout] 274 | let notification = Notification::Publish(boxed_publish.init(publish.try_into().unwrap())); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | Ok((Some(notification), request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mqttrust_core` (lib) due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "33a86e5644dd2c8dc4cec7b94211be50f00ce5b103e9ca7f5cb67337df2d071a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33a86e5644dd2c8dc4cec7b94211be50f00ce5b103e9ca7f5cb67337df2d071a", kill_on_drop: false }` [INFO] [stdout] 33a86e5644dd2c8dc4cec7b94211be50f00ce5b103e9ca7f5cb67337df2d071a