[INFO] fetching crate mqttest 0.2.0... [INFO] checking mqttest-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mqttest 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate mqttest 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mqttest 0.2.0 [INFO] finished tweaking crates.io crate mqttest 0.2.0 [INFO] tweaked toml for crates.io crate mqttest 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate mqttest 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc78950a695ea2311e963cb0391385849fe2654d1d4ac78087c0144226964f91 [INFO] running `Command { std: "docker" "start" "-a" "fc78950a695ea2311e963cb0391385849fe2654d1d4ac78087c0144226964f91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc78950a695ea2311e963cb0391385849fe2654d1d4ac78087c0144226964f91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc78950a695ea2311e963cb0391385849fe2654d1d4ac78087c0144226964f91", kill_on_drop: false }` [INFO] [stdout] fc78950a695ea2311e963cb0391385849fe2654d1d4ac78087c0144226964f91 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27240ed7bb69d483c89b81f67e5376eed35144823b2542b6f28e9011cd05f3c6 [INFO] running `Command { std: "docker" "start" "-a" "27240ed7bb69d483c89b81f67e5376eed35144823b2542b6f28e9011cd05f3c6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.15 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking futures-sink v0.3.4 [INFO] [stderr] Compiling proc-macro-nested v0.1.4 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling rustversion v1.0.2 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking futures-io v0.3.4 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking futures-channel v0.3.4 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling standback v0.2.2 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking futures-task v0.3.4 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling futures-macro v0.3.4 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling time-macros-impl v0.1.0 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Checking tokio v0.2.16 [INFO] [stderr] Checking time-macros v0.1.0 [INFO] [stderr] Compiling time v0.2.9 [INFO] [stderr] Compiling structopt-derive v0.4.5 [INFO] [stderr] Checking futures-util v0.3.4 [INFO] [stderr] Checking structopt v0.3.12 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.4 [INFO] [stderr] Checking futures v0.3.4 [INFO] [stderr] Checking serde_json v1.0.51 [INFO] [stderr] Checking mqttrs v0.3.0 [INFO] [stderr] Checking mqttest v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:416:13 [INFO] [stdout] | [INFO] [stdout] 407 | chan: oneshot::Sender) [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | Err(Error::new(ErrorKind::ConnectionReset, "Replaced")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:31:41 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Clone, Copy, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:48:41 [INFO] [stdout] | [INFO] [stdout] 48 | #[derive(Clone, Copy, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:126:11 [INFO] [stdout] | [INFO] [stdout] 115 | let mut child = Command::new(cmd).stdin(Stdio::piped()) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | match child.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:160:35 [INFO] [stdout] | [INFO] [stdout] 160 | #[derive(Clone, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:173:35 [INFO] [stdout] | [INFO] [stdout] 173 | #[derive(Clone, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubsub.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn add(&mut self, topic: &String, qos: QoS, id: ConnId, addr: Addr) -> bool { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | debug!("C{}: subscribe to {:?} {:?}", id, topic, qos); [INFO] [stdout] 16 | self.0.entry(topic.clone()).or_default().insert(id, Sub { qos, addr }).is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | fn block_on(f: impl Future) -> T { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let _ = env_logger::builder().is_test(true).parse_filters("debug").try_init(); [INFO] [stdout] 34 | Builder::new().basic_scheduler().enable_all().build().unwrap().block_on(f) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 43 | let srv = Mqttest::start(conf).await.expect("Failed listen"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | srv.fut.await.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mqttest` (lib test) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:416:13 [INFO] [stdout] | [INFO] [stdout] 407 | chan: oneshot::Sender) [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | Err(Error::new(ErrorKind::ConnectionReset, "Replaced")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:31:41 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Clone, Copy, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:48:41 [INFO] [stdout] | [INFO] [stdout] 48 | #[derive(Clone, Copy, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:126:11 [INFO] [stdout] | [INFO] [stdout] 115 | let mut child = Command::new(cmd).stdin(Stdio::piped()) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | match child.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:160:35 [INFO] [stdout] | [INFO] [stdout] 160 | #[derive(Clone, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dump.rs:173:35 [INFO] [stdout] | [INFO] [stdout] 173 | #[derive(Clone, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubsub.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn add(&mut self, topic: &String, qos: QoS, id: ConnId, addr: Addr) -> bool { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | debug!("C{}: subscribe to {:?} {:?}", id, topic, qos); [INFO] [stdout] 16 | self.0.entry(topic.clone()).or_default().insert(id, Sub { qos, addr }).is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mqttest` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "27240ed7bb69d483c89b81f67e5376eed35144823b2542b6f28e9011cd05f3c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27240ed7bb69d483c89b81f67e5376eed35144823b2542b6f28e9011cd05f3c6", kill_on_drop: false }` [INFO] [stdout] 27240ed7bb69d483c89b81f67e5376eed35144823b2542b6f28e9011cd05f3c6