[INFO] fetching crate mqtt-bytes-v5 0.1.3... [INFO] checking mqtt-bytes-v5-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mqtt-bytes-v5 0.1.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mqtt-bytes-v5 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mqtt-bytes-v5 0.1.3 [INFO] finished tweaking crates.io crate mqtt-bytes-v5 0.1.3 [INFO] tweaked toml for crates.io crate mqtt-bytes-v5 0.1.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 06480f0b8672551a5f18a80d66255ae38949aaa7ec42b96481ede13753a761a9 [INFO] running `Command { std: "docker" "start" "-a" "06480f0b8672551a5f18a80d66255ae38949aaa7ec42b96481ede13753a761a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "06480f0b8672551a5f18a80d66255ae38949aaa7ec42b96481ede13753a761a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06480f0b8672551a5f18a80d66255ae38949aaa7ec42b96481ede13753a761a9", kill_on_drop: false }` [INFO] [stdout] 06480f0b8672551a5f18a80d66255ae38949aaa7ec42b96481ede13753a761a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59cef5914db8d5e45ad9a57fecd559464800f0c45f69d9640d49bbd15d86469b [INFO] running `Command { std: "docker" "start" "-a" "59cef5914db8d5e45ad9a57fecd559464800f0c45f69d9640d49bbd15d86469b", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking mqtt-bytes-v5 v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connack.rs:323:12 [INFO] [stdout] | [INFO] [stdout] 228 | let mut authentication_data = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | Ok(Some(ConnAckProperties { [INFO] [stdout] | ____________^ [INFO] [stdout] 324 | | session_expiry_interval, [INFO] [stdout] 325 | | receive_max, [INFO] [stdout] 326 | | max_qos, [INFO] [stdout] ... | [INFO] [stdout] 340 | | authentication_data, [INFO] [stdout] 341 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 26 | mut bytes: Bytes, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let properties = ConnectProperties::read(&mut bytes)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let will = LastWill::read(connect_flags, &mut bytes)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let connect = Connect { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok((connect, will, login)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 183 | let mut authentication_data = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(Some(ConnectProperties { [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | session_expiry_interval, [INFO] [stdout] 243 | | receive_maximum, [INFO] [stdout] 244 | | max_packet_size, [INFO] [stdout] ... | [INFO] [stdout] 250 | | authentication_data, [INFO] [stdout] 251 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect.rs:535:12 [INFO] [stdout] | [INFO] [stdout] 482 | let mut correlation_data = None; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 535 | Ok(Some(LastWillProperties { [INFO] [stdout] | ____________^ [INFO] [stdout] 536 | | delay_interval, [INFO] [stdout] 537 | | payload_format_indicator, [INFO] [stdout] 538 | | message_expiry_interval, [INFO] [stdout] ... | [INFO] [stdout] 542 | | user_properties, [INFO] [stdout] 543 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 24 | topic: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | qos: QoS, [INFO] [stdout] 26 | payload: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | properties: Option, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | payload: payload.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 24 | topic: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | qos: QoS, [INFO] [stdout] 26 | payload: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | properties: Option, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 186 | let mut correlation_data = None; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | Ok(Some(PublishProperties { [INFO] [stdout] | ____________^ [INFO] [stdout] 248 | | payload_format_indicator, [INFO] [stdout] 249 | | message_expiry_interval, [INFO] [stdout] 250 | | topic_alias, [INFO] [stdout] ... | [INFO] [stdout] 255 | | content_type, [INFO] [stdout] 256 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subscribe.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new_many(filters: F, properties: Option) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | filters: filters.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mqtt-bytes-v5` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "59cef5914db8d5e45ad9a57fecd559464800f0c45f69d9640d49bbd15d86469b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59cef5914db8d5e45ad9a57fecd559464800f0c45f69d9640d49bbd15d86469b", kill_on_drop: false }` [INFO] [stdout] 59cef5914db8d5e45ad9a57fecd559464800f0c45f69d9640d49bbd15d86469b