[INFO] fetching crate mprocs-pty 0.7.0... [INFO] checking mprocs-pty-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mprocs-pty 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate mprocs-pty 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mprocs-pty 0.7.0 [INFO] finished tweaking crates.io crate mprocs-pty 0.7.0 [INFO] tweaked toml for crates.io crate mprocs-pty 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate mprocs-pty 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 864472945f57ec64aba01fb311d0f9de51f925a41490eb8a62354204a7620935 [INFO] running `Command { std: "docker" "start" "-a" "864472945f57ec64aba01fb311d0f9de51f925a41490eb8a62354204a7620935", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "864472945f57ec64aba01fb311d0f9de51f925a41490eb8a62354204a7620935", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "864472945f57ec64aba01fb311d0f9de51f925a41490eb8a62354204a7620935", kill_on_drop: false }` [INFO] [stdout] 864472945f57ec64aba01fb311d0f9de51f925a41490eb8a62354204a7620935 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 749db778101d02e8dd1668acf456f85d9218b4f023f099c93b1d3293579add4f [INFO] running `Command { std: "docker" "start" "-a" "749db778101d02e8dd1668acf456f85d9218b4f023f099c93b1d3293579add4f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking cache-padded v1.2.0 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking async-task v4.3.0 [INFO] [stderr] Checking concurrent-queue v1.2.4 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking atomic-waker v1.0.0 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking async-lock v2.5.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking async-channel v1.7.1 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Compiling syn v2.0.32 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-lite v1.12.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking polling v2.2.0 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking nix v0.24.2 [INFO] [stderr] Checking blocking v1.2.0 [INFO] [stderr] Checking async-executor v1.4.1 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking async-fs v1.5.0 [INFO] [stderr] Checking async-io v1.7.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking async-process v1.4.0 [INFO] [stderr] Checking async-net v1.6.1 [INFO] [stderr] Checking smol v1.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Checking filedescriptor v0.8.1 [INFO] [stderr] Checking mprocs-pty v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/unix.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::unnecessary_mut_passed))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `serde`, `serde_derive`, `serde_support`, `ssh`, and `ssh2` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/unix.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 230 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `serde`, `serde_derive`, `serde_support`, `ssh`, and `ssh2` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:58:6 [INFO] [stdout] | [INFO] [stdout] 44 | let master = UnixMasterPty { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let slave = UnixSlavePty { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok((master, slave)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 63 | let (master, slave) = openpty(size)?; [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(PtyPair { [INFO] [stdout] | ________^ [INFO] [stdout] 65 | | master: Box::new(master), [INFO] [stdout] 66 | | slave: Box::new(slave), [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:318:8 [INFO] [stdout] | [INFO] [stdout] 317 | let fd = PtyFd(self.fd.try_clone()?); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | Ok(Box::new(fd)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:323:8 [INFO] [stdout] | [INFO] [stdout] 322 | let fd = PtyFd(self.fd.try_clone()?); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | Ok(Box::new(UnixMasterPty { fd })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 69 | let mut port = serial::open(&self.port) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let port: Handle = Arc::new(Mutex::new(port)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | Ok(PtyPair { [INFO] [stdout] | ________^ [INFO] [stdout] 92 | | slave: Box::new(Slave { [INFO] [stdout] 93 | | port: Arc::clone(&port), [INFO] [stdout] 94 | | }), [INFO] [stdout] 95 | | master: Box::new(Master { port }), [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:221:8 [INFO] [stdout] | [INFO] [stdout] 220 | let fd = FileDescriptor::dup(&*self.port.lock().unwrap())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | Ok(Box::new(Reader { fd })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:226:8 [INFO] [stdout] | [INFO] [stdout] 225 | let port = Arc::clone(&self.port); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Ok(Box::new(Master { port })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mprocs-pty` (lib) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "749db778101d02e8dd1668acf456f85d9218b4f023f099c93b1d3293579add4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "749db778101d02e8dd1668acf456f85d9218b4f023f099c93b1d3293579add4f", kill_on_drop: false }` [INFO] [stdout] 749db778101d02e8dd1668acf456f85d9218b4f023f099c93b1d3293579add4f