[INFO] fetching crate mpdsh 0.1.0... [INFO] checking mpdsh-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mpdsh 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mpdsh 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mpdsh 0.1.0 [INFO] finished tweaking crates.io crate mpdsh 0.1.0 [INFO] tweaked toml for crates.io crate mpdsh 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate mpdsh 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a2a1466727ef0862cb88d07492a93f01c5a60e2edd3d708f4c20904a8147416 [INFO] running `Command { std: "docker" "start" "-a" "6a2a1466727ef0862cb88d07492a93f01c5a60e2edd3d708f4c20904a8147416", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a2a1466727ef0862cb88d07492a93f01c5a60e2edd3d708f4c20904a8147416", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a2a1466727ef0862cb88d07492a93f01c5a60e2edd3d708f4c20904a8147416", kill_on_drop: false }` [INFO] [stdout] 6a2a1466727ef0862cb88d07492a93f01c5a60e2edd3d708f4c20904a8147416 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f7cd08f82ae0ed587153a9c7b1cd2bb2241df27dd6c3c587beb8c651727e365 [INFO] running `Command { std: "docker" "start" "-a" "8f7cd08f82ae0ed587153a9c7b1cd2bb2241df27dd6c3c587beb8c651727e365", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Compiling syn v1.0.31 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking shell-words v1.0.0 [INFO] [stderr] Checking wildmatch v1.0.10 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking dirs-sys-next v0.1.0 [INFO] [stderr] Checking dirs-next v1.0.1 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling rustyline-derive v0.3.1 [INFO] [stderr] Checking rustyline v6.2.0 [INFO] [stderr] Checking mpdsh v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `arg_prog` [INFO] [stdout] --> src/main.rs:1329:9 [INFO] [stdout] | [INFO] [stdout] 1329 | let arg_prog = args[0].clone(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_arg_prog` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bin` is never read [INFO] [stdout] --> src/main.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 35 | struct ExecOk [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 38 | , bin: Option> [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cmd_index` and `cur_cmd` are never read [INFO] [stdout] --> src/main.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 41 | struct ExecErr [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 44 | , cmd_index: i32 [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 45 | , cur_cmd: Option [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `worker_handle` and `version` are never read [INFO] [stdout] --> src/main.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 79 | struct Mpdsh [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 80 | { [INFO] [stdout] 81 | worker_handle: thread::JoinHandle<()> [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | , version: String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `hint_playlist` is never used [INFO] [stdout] --> src/main.rs:646:8 [INFO] [stdout] | [INFO] [stdout] 90 | impl Mpdsh [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 646 | fn hint_playlist( &mut self ) -> Vec [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PKG_AUTHORS` is never used [INFO] [stdout] --> src/main.rs:1323:7 [INFO] [stdout] | [INFO] [stdout] 1323 | const PKG_AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 92 | fn new( stream: TcpStream, opt_protolog: bool ) -> Result< Self, () > [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | { [INFO] [stdout] 94 | let mut reader = BufReader::new( &stream ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let ( htx, hrx ) : ( mpsc::Sender, mpsc::Receiver ) = mpsc::channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let ( wtx, wrx ) : ( mpsc::Sender, mpsc::Receiver ) = mpsc::channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | [INFO] [stdout] 111 | let worker_handle = thread::spawn( move || [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok( Mpdsh [INFO] [stdout] | _____________^ [INFO] [stdout] 118 | | { [INFO] [stdout] 119 | | worker_handle: worker_handle [INFO] [stdout] 120 | | , htx: htx [INFO] [stdout] ... | [INFO] [stdout] 125 | | , args_opt: Vec::new() [INFO] [stdout] 126 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | / wtx.send( [INFO] [stdout] 177 | | Ok( [INFO] [stdout] 178 | | ExecOk [INFO] [stdout] 179 | | { [INFO] [stdout] ... | [INFO] [stdout] 183 | | ) [INFO] [stdout] 184 | | ); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 176 | let _ = wtx.send( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:310:17 [INFO] [stdout] | [INFO] [stdout] 310 | wtx.send( send ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 310 | let _ = wtx.send( send ); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mpdsh` (bin "mpdsh") due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `arg_prog` [INFO] [stdout] --> src/main.rs:1329:9 [INFO] [stdout] | [INFO] [stdout] 1329 | let arg_prog = args[0].clone(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_arg_prog` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bin` is never read [INFO] [stdout] --> src/main.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 35 | struct ExecOk [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 38 | , bin: Option> [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cmd_index` and `cur_cmd` are never read [INFO] [stdout] --> src/main.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 41 | struct ExecErr [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 44 | , cmd_index: i32 [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 45 | , cur_cmd: Option [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `worker_handle` and `version` are never read [INFO] [stdout] --> src/main.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 79 | struct Mpdsh [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 80 | { [INFO] [stdout] 81 | worker_handle: thread::JoinHandle<()> [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | , version: String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `hint_playlist` is never used [INFO] [stdout] --> src/main.rs:646:8 [INFO] [stdout] | [INFO] [stdout] 90 | impl Mpdsh [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 646 | fn hint_playlist( &mut self ) -> Vec [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PKG_AUTHORS` is never used [INFO] [stdout] --> src/main.rs:1323:7 [INFO] [stdout] | [INFO] [stdout] 1323 | const PKG_AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 92 | fn new( stream: TcpStream, opt_protolog: bool ) -> Result< Self, () > [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | { [INFO] [stdout] 94 | let mut reader = BufReader::new( &stream ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let ( htx, hrx ) : ( mpsc::Sender, mpsc::Receiver ) = mpsc::channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let ( wtx, wrx ) : ( mpsc::Sender, mpsc::Receiver ) = mpsc::channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | [INFO] [stdout] 111 | let worker_handle = thread::spawn( move || [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok( Mpdsh [INFO] [stdout] | _____________^ [INFO] [stdout] 118 | | { [INFO] [stdout] 119 | | worker_handle: worker_handle [INFO] [stdout] 120 | | , htx: htx [INFO] [stdout] ... | [INFO] [stdout] 125 | | , args_opt: Vec::new() [INFO] [stdout] 126 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | / wtx.send( [INFO] [stdout] 177 | | Ok( [INFO] [stdout] 178 | | ExecOk [INFO] [stdout] 179 | | { [INFO] [stdout] ... | [INFO] [stdout] 183 | | ) [INFO] [stdout] 184 | | ); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 176 | let _ = wtx.send( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:310:17 [INFO] [stdout] | [INFO] [stdout] 310 | wtx.send( send ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 310 | let _ = wtx.send( send ); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mpdsh` (bin "mpdsh" test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8f7cd08f82ae0ed587153a9c7b1cd2bb2241df27dd6c3c587beb8c651727e365", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f7cd08f82ae0ed587153a9c7b1cd2bb2241df27dd6c3c587beb8c651727e365", kill_on_drop: false }` [INFO] [stdout] 8f7cd08f82ae0ed587153a9c7b1cd2bb2241df27dd6c3c587beb8c651727e365