[INFO] fetching crate mp4parse 0.17.0... [INFO] checking mp4parse-0.17.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mp4parse 0.17.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mp4parse 0.17.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mp4parse 0.17.0 [INFO] finished tweaking crates.io crate mp4parse 0.17.0 [INFO] tweaked toml for crates.io crate mp4parse 0.17.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 86 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dfc3775f72475f6f6e137a7fb3fd51e737a22d34ff2c3971c746c75feb4f5b86 [INFO] running `Command { std: "docker" "start" "-a" "dfc3775f72475f6f6e137a7fb3fd51e737a22d34ff2c3971c746c75feb4f5b86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dfc3775f72475f6f6e137a7fb3fd51e737a22d34ff2c3971c746c75feb4f5b86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dfc3775f72475f6f6e137a7fb3fd51e737a22d34ff2c3971c746c75feb4f5b86", kill_on_drop: false }` [INFO] [stdout] dfc3775f72475f6f6e137a7fb3fd51e737a22d34ff2c3971c746c75feb4f5b86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d422da30ea50b5880a1e080e800528ba6af98d6b729d2993618e1498a7690b5 [INFO] running `Command { std: "docker" "start" "-a" "9d422da30ea50b5880a1e080e800528ba6af98d6b729d2993618e1498a7690b5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking bitreader v0.3.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking test-assembler v0.1.6 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking fallible_collections v0.4.9 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking mp4parse v0.17.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2223:9 [INFO] [stdout] | [INFO] [stdout] 2222 | fn add(self, other: TrackScaledTime) -> Self::Output { [INFO] [stdout] | ---- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2223 | self.0.checked_add(&other.0).map(|sum| Self(sum, self.1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2827:8 [INFO] [stdout] | [INFO] [stdout] 2471 | let major_brand = if let Some(mut b) = iter.next_box()? { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2516 | let mut meta = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2517 | let mut image_sequence = None; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2590 | item_properties, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2593 | iloc_items, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2827 | Ok(AvifContext { [INFO] [stdout] | ________^ [INFO] [stdout] 2828 | | strictness, [INFO] [stdout] 2829 | | media_storage, [INFO] [stdout] 2830 | | item_data_box, [INFO] [stdout] ... | [INFO] [stdout] 2837 | | unsupported_features, [INFO] [stdout] 2838 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2937:8 [INFO] [stdout] | [INFO] [stdout] 2859 | let mut iloc_items = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2860 | let mut item_references = None; [INFO] [stdout] 2861 | let mut item_properties = None; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2937 | Ok(AvifMeta { [INFO] [stdout] | ________^ [INFO] [stdout] 2938 | | item_properties: item_properties.unwrap_or_default(), [INFO] [stdout] 2939 | | item_references: item_references.unwrap_or_default(), [INFO] [stdout] 2940 | | primary_item_id, [INFO] [stdout] ... | [INFO] [stdout] 2943 | | item_data_box, [INFO] [stdout] 2944 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:4245:19 [INFO] [stdout] | [INFO] [stdout] 4191 | let mut context = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4245 | context.ok_or(Error::MoovMissing) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:4310:8 [INFO] [stdout] | [INFO] [stdout] 4265 | fn read_moov(f: &mut BMFFBox, context: Option) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4271 | mut userdata, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4310 | Ok(MediaContext { [INFO] [stdout] | ________^ [INFO] [stdout] 4311 | | timescale, [INFO] [stdout] 4312 | | tracks, [INFO] [stdout] 4313 | | mvex, [INFO] [stdout] ... | [INFO] [stdout] 4317 | | metadata, [INFO] [stdout] 4318 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mp4parse` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9d422da30ea50b5880a1e080e800528ba6af98d6b729d2993618e1498a7690b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d422da30ea50b5880a1e080e800528ba6af98d6b729d2993618e1498a7690b5", kill_on_drop: false }` [INFO] [stdout] 9d422da30ea50b5880a1e080e800528ba6af98d6b729d2993618e1498a7690b5