[INFO] fetching crate mp4 0.14.0... [INFO] checking mp4-0.14.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mp4 0.14.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate mp4 0.14.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mp4 0.14.0 [INFO] finished tweaking crates.io crate mp4 0.14.0 [INFO] tweaked toml for crates.io crate mp4 0.14.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate mp4 0.14.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c35bcfb557f6f170968db5de426350f376d9d2b3a36e9c6cc101b29164783e11 [INFO] running `Command { std: "docker" "start" "-a" "c35bcfb557f6f170968db5de426350f376d9d2b3a36e9c6cc101b29164783e11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c35bcfb557f6f170968db5de426350f376d9d2b3a36e9c6cc101b29164783e11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c35bcfb557f6f170968db5de426350f376d9d2b3a36e9c6cc101b29164783e11", kill_on_drop: false }` [INFO] [stdout] c35bcfb557f6f170968db5de426350f376d9d2b3a36e9c6cc101b29164783e11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76e29fd54bccc260c10b0a9ae24a954373a8363620867d81f35407b3a99d4fe3 [INFO] running `Command { std: "docker" "start" "-a" "76e29fd54bccc260c10b0a9ae24a954373a8363620867d81f35407b3a99d4fe3", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.20 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.40 [INFO] [stderr] Compiling serde_derive v1.0.115 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling rayon-core v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking either v1.6.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Compiling rayon v1.4.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking tinytemplate v1.1.0 [INFO] [stderr] Checking mp4 v0.14.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.3.3 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track.rs:557:12 [INFO] [stdout] | [INFO] [stdout] 541 | Err(err) => return Err(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | Err(err) => return Err(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | Ok(Some(Mp4Sample { [INFO] [stdout] | ____________^ [INFO] [stdout] 558 | | start_time, [INFO] [stdout] 559 | | duration, [INFO] [stdout] 560 | | rendering_offset, [INFO] [stdout] 561 | | is_sync, [INFO] [stdout] 562 | | bytes: Bytes::from(buffer), [INFO] [stdout] 563 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn read_header(mut reader: R, size: u64) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok(Mp4Reader { [INFO] [stdout] | ____________^ [INFO] [stdout] 118 | | reader, [INFO] [stdout] 119 | | ftyp: ftyp.unwrap(), [INFO] [stdout] 120 | | moov: moov.unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 124 | | tracks, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn write_start(mut writer: W, config: &Mp4Config) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let tracks = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | writer, [INFO] [stdout] 81 | | tracks, [INFO] [stdout] 82 | | mdat_pos, [INFO] [stdout] 83 | | timescale, [INFO] [stdout] 84 | | duration, [INFO] [stdout] 85 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mp4` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "76e29fd54bccc260c10b0a9ae24a954373a8363620867d81f35407b3a99d4fe3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76e29fd54bccc260c10b0a9ae24a954373a8363620867d81f35407b3a99d4fe3", kill_on_drop: false }` [INFO] [stdout] 76e29fd54bccc260c10b0a9ae24a954373a8363620867d81f35407b3a99d4fe3