[INFO] fetching crate mozrunner 0.15.3... [INFO] checking mozrunner-0.15.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mozrunner 0.15.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mozrunner 0.15.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mozrunner 0.15.3 [INFO] finished tweaking crates.io crate mozrunner 0.15.3 [INFO] tweaked toml for crates.io crate mozrunner 0.15.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate mozrunner 0.15.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed31d1121085e0526367ff8863de022360a8455bb7ac703c7e9c3eb567fd5ca7 [INFO] running `Command { std: "docker" "start" "-a" "ed31d1121085e0526367ff8863de022360a8455bb7ac703c7e9c3eb567fd5ca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed31d1121085e0526367ff8863de022360a8455bb7ac703c7e9c3eb567fd5ca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed31d1121085e0526367ff8863de022360a8455bb7ac703c7e9c3eb567fd5ca7", kill_on_drop: false }` [INFO] [stdout] ed31d1121085e0526367ff8863de022360a8455bb7ac703c7e9c3eb567fd5ca7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bcfcc55c0dbf699486dc99461b28a47ee34a102a70e4d30f85382f033d3bbb90 [INFO] running `Command { std: "docker" "start" "-a" "bcfcc55c0dbf699486dc99461b28a47ee34a102a70e4d30f85382f033d3bbb90", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking itoa v1.0.5 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking quick-xml v0.32.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking plist v1.7.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking mozprofile v0.9.3 [INFO] [stderr] Checking mozrunner v0.15.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/firefox_args.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 187 | args: impl Iterator, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | ) -> Vec<(Option, Option)> { [INFO] [stdout] 189 | / args.map(parse_arg_name_value) [INFO] [stdout] 190 | | .map(|(name, value)| { [INFO] [stdout] 191 | | if let Some(arg_name) = name { [INFO] [stdout] 192 | | (Some(Arg::new(&arg_name)), value) [INFO] [stdout] ... | [INFO] [stdout] 195 | | } [INFO] [stdout] 196 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 162 | pub fn new(path: &Path, profile: Option) -> FirefoxRunner { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | stdout: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:172:21 [INFO] [stdout] | [INFO] [stdout] 162 | pub fn new(path: &Path, profile: Option) -> FirefoxRunner { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | stderr: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 236 | fn start(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let stdout = self.stdout.unwrap_or_else(Stdio::inherit); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let stderr = self.stderr.unwrap_or_else(Stdio::inherit); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let mut cmd = Command::new(binary_path); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | let process = cmd.spawn()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | Ok(FirefoxProcess { [INFO] [stdout] | ____________^ [INFO] [stdout] 284 | | process, [INFO] [stdout] 285 | | profile: self.profile, [INFO] [stdout] 286 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mozrunner` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/firefox_args.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 187 | args: impl Iterator, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | ) -> Vec<(Option, Option)> { [INFO] [stdout] 189 | / args.map(parse_arg_name_value) [INFO] [stdout] 190 | | .map(|(name, value)| { [INFO] [stdout] 191 | | if let Some(arg_name) = name { [INFO] [stdout] 192 | | (Some(Arg::new(&arg_name)), value) [INFO] [stdout] ... | [INFO] [stdout] 195 | | } [INFO] [stdout] 196 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 162 | pub fn new(path: &Path, profile: Option) -> FirefoxRunner { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | stdout: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:172:21 [INFO] [stdout] | [INFO] [stdout] 162 | pub fn new(path: &Path, profile: Option) -> FirefoxRunner { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | stderr: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 236 | fn start(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let stdout = self.stdout.unwrap_or_else(Stdio::inherit); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let stderr = self.stderr.unwrap_or_else(Stdio::inherit); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let mut cmd = Command::new(binary_path); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | let process = cmd.spawn()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | Ok(FirefoxProcess { [INFO] [stdout] | ____________^ [INFO] [stdout] 284 | | process, [INFO] [stdout] 285 | | profile: self.profile, [INFO] [stdout] 286 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mozrunner` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bcfcc55c0dbf699486dc99461b28a47ee34a102a70e4d30f85382f033d3bbb90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bcfcc55c0dbf699486dc99461b28a47ee34a102a70e4d30f85382f033d3bbb90", kill_on_drop: false }` [INFO] [stdout] bcfcc55c0dbf699486dc99461b28a47ee34a102a70e4d30f85382f033d3bbb90