[INFO] fetching crate mozprofile 0.9.3... [INFO] checking mozprofile-0.9.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mozprofile 0.9.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate mozprofile 0.9.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mozprofile 0.9.3 [INFO] finished tweaking crates.io crate mozprofile 0.9.3 [INFO] tweaked toml for crates.io crate mozprofile 0.9.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 80acd5535f2e52b73bb5bfc9b829a8042ec6913e7f04bf59919d52e130e4d7de [INFO] running `Command { std: "docker" "start" "-a" "80acd5535f2e52b73bb5bfc9b829a8042ec6913e7f04bf59919d52e130e4d7de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "80acd5535f2e52b73bb5bfc9b829a8042ec6913e7f04bf59919d52e130e4d7de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80acd5535f2e52b73bb5bfc9b829a8042ec6913e7f04bf59919d52e130e4d7de", kill_on_drop: false }` [INFO] [stdout] 80acd5535f2e52b73bb5bfc9b829a8042ec6913e7f04bf59919d52e130e4d7de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b1899be884d510d4ac10dc96112237f08b231272e0c55c2571d1546d5d1f59da [INFO] running `Command { std: "docker" "start" "-a" "b1899be884d510d4ac10dc96112237f08b231272e0c55c2571d1546d5d1f59da", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking mozprofile v0.9.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prefreader.rs:27:65 [INFO] [stdout] | [INFO] [stdout] 26 | fn from(err: io::Error) -> PrefReaderError { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | PrefReaderError::new("IOError".into(), Position::new(), Some(err.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 32 | let dir = if let Some(temp_root) = temp_root { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let temp_dir = Some(dir); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Ok(Profile { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | path, [INFO] [stdout] 41 | | temp_dir, [INFO] [stdout] 42 | | prefs: None, [INFO] [stdout] 43 | | user_prefs: None, [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 49 | let temp_dir = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(Profile { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | path, [INFO] [stdout] 52 | | temp_dir, [INFO] [stdout] 53 | | prefs: None, [INFO] [stdout] 54 | | user_prefs: None, [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prefreader.rs:27:65 [INFO] [stdout] | [INFO] [stdout] 26 | fn from(err: io::Error) -> PrefReaderError { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | PrefReaderError::new("IOError".into(), Position::new(), Some(err.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 32 | let dir = if let Some(temp_root) = temp_root { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let temp_dir = Some(dir); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Ok(Profile { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | path, [INFO] [stdout] 41 | | temp_dir, [INFO] [stdout] 42 | | prefs: None, [INFO] [stdout] 43 | | user_prefs: None, [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 49 | let temp_dir = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(Profile { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | path, [INFO] [stdout] 52 | | temp_dir, [INFO] [stdout] 53 | | prefs: None, [INFO] [stdout] 54 | | user_prefs: None, [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mozprofile` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mozprofile` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "b1899be884d510d4ac10dc96112237f08b231272e0c55c2571d1546d5d1f59da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1899be884d510d4ac10dc96112237f08b231272e0c55c2571d1546d5d1f59da", kill_on_drop: false }` [INFO] [stdout] b1899be884d510d4ac10dc96112237f08b231272e0c55c2571d1546d5d1f59da