[INFO] fetching crate mozilla-readability 0.1.1... [INFO] checking mozilla-readability-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mozilla-readability 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate mozilla-readability 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mozilla-readability 0.1.1 [INFO] finished tweaking crates.io crate mozilla-readability 0.1.1 [INFO] tweaked toml for crates.io crate mozilla-readability 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 96 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding cssparser v0.27.2 (latest: v0.34.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding html5ever v0.25.2 (latest: v0.28.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding markup5ever v0.10.1 (latest: v0.13.0) [INFO] [stderr] Adding phf v0.8.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_codegen v0.8.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_generator v0.8.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_generator v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_macros v0.8.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_shared v0.8.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_pcg v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding selectors v0.22.0 (latest: v0.25.0) [INFO] [stderr] Adding servo_arc v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cfb8a7f48dee0d0ed465359fed105d4fd9a2aae78cb0777799c3406338c9d863 [INFO] running `Command { std: "docker" "start" "-a" "cfb8a7f48dee0d0ed465359fed105d4fd9a2aae78cb0777799c3406338c9d863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cfb8a7f48dee0d0ed465359fed105d4fd9a2aae78cb0777799c3406338c9d863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfb8a7f48dee0d0ed465359fed105d4fd9a2aae78cb0777799c3406338c9d863", kill_on_drop: false }` [INFO] [stdout] cfb8a7f48dee0d0ed465359fed105d4fd9a2aae78cb0777799c3406338c9d863 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3c6461553edb7cfa4d573885fbdf5ca69fe82cc8b460e816bbaf40765b9581e7 [INFO] running `Command { std: "docker" "start" "-a" "3c6461553edb7cfa4d573885fbdf5ca69fe82cc8b460e816bbaf40765b9581e7", kill_on_drop: false }` [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking thin-slice v0.1.1 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Compiling selectors v0.22.0 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling markup5ever v0.10.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Compiling cssparser v0.27.2 [INFO] [stderr] Compiling html5ever v0.25.2 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking kuchiki v0.8.1 [INFO] [stderr] Checking mozilla-readability v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:997:10 [INFO] [stdout] | [INFO] [stdout] 991 | let first_child = node_ref.children().elements().next(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 997 | !node_ref.children().any(|node| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1203:37 [INFO] [stdout] | [INFO] [stdout] 1203 | .any(|tag_name| table_node.select_first(tag_name).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1549:37 [INFO] [stdout] | [INFO] [stdout] 1548 | let next_node = Self::next_element(br_node.next_sibling(), true); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1549 | next_node.is_some() && &next_node.unwrap().as_element().unwrap().name.local == "p" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1742:41 [INFO] [stdout] | [INFO] [stdout] 1741 | let parent = node_ref.parent(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1742 | parent.is_some() && parent.unwrap().as_element().is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1808:41 [INFO] [stdout] | [INFO] [stdout] 1808 | .map(|node_ref| node_ref.as_element().unwrap().attributes.borrow()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1833:34 [INFO] [stdout] | [INFO] [stdout] 1833 | .map(|node| &node.as_element().unwrap().name.local) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:997:10 [INFO] [stdout] | [INFO] [stdout] 991 | let first_child = node_ref.children().elements().next(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 997 | !node_ref.children().any(|node| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1203:37 [INFO] [stdout] | [INFO] [stdout] 1203 | .any(|tag_name| table_node.select_first(tag_name).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1549:37 [INFO] [stdout] | [INFO] [stdout] 1548 | let next_node = Self::next_element(br_node.next_sibling(), true); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1549 | next_node.is_some() && &next_node.unwrap().as_element().unwrap().name.local == "p" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1742:41 [INFO] [stdout] | [INFO] [stdout] 1741 | let parent = node_ref.parent(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1742 | parent.is_some() && parent.unwrap().as_element().is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mozilla-readability` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1808:41 [INFO] [stdout] | [INFO] [stdout] 1808 | .map(|node_ref| node_ref.as_element().unwrap().attributes.borrow()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1833:34 [INFO] [stdout] | [INFO] [stdout] 1833 | .map(|node| &node.as_element().unwrap().name.local) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mozilla-readability` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "3c6461553edb7cfa4d573885fbdf5ca69fe82cc8b460e816bbaf40765b9581e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c6461553edb7cfa4d573885fbdf5ca69fe82cc8b460e816bbaf40765b9581e7", kill_on_drop: false }` [INFO] [stdout] 3c6461553edb7cfa4d573885fbdf5ca69fe82cc8b460e816bbaf40765b9581e7