[INFO] fetching crate moteconnection 0.3.1... [INFO] checking moteconnection-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate moteconnection 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate moteconnection 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate moteconnection 0.3.1 [INFO] finished tweaking crates.io crate moteconnection 0.3.1 [INFO] tweaked toml for crates.io crate moteconnection 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate moteconnection 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b925a9c2f70bb5df03b81e308a7df0a4f9f302b81fe4c7c120e2d44352b9d47e [INFO] running `Command { std: "docker" "start" "-a" "b925a9c2f70bb5df03b81e308a7df0a4f9f302b81fe4c7c120e2d44352b9d47e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b925a9c2f70bb5df03b81e308a7df0a4f9f302b81fe4c7c120e2d44352b9d47e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b925a9c2f70bb5df03b81e308a7df0a4f9f302b81fe4c7c120e2d44352b9d47e", kill_on_drop: false }` [INFO] [stdout] b925a9c2f70bb5df03b81e308a7df0a4f9f302b81fe4c7c120e2d44352b9d47e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc1cd70d35e3370365854ed09f198d528b831d1ffd8cc4295c143986562ba718 [INFO] running `Command { std: "docker" "start" "-a" "bc1cd70d35e3370365854ed09f198d528b831d1ffd8cc4295c143986562ba718", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking regex-syntax v0.6.20 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking aho-corasick v0.7.14 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.4.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking stderrlog v0.4.3 [INFO] [stderr] Checking serialport v3.3.0 [INFO] [stderr] Checking moteconnection v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `internal_tx` and `internal_rx` are never read [INFO] [stdout] --> src/tests.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TestTransport { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 14 | pub handle: Rc>>, [INFO] [stdout] 15 | pub internal_tx: Rc>>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 16 | pub internal_rx: Rc>>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestTransport` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:201:26 [INFO] [stdout] | [INFO] [stdout] 199 | pub fn with_transport(transport: Box) -> ConnectionBuilder { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | ConnectionBuilder { [INFO] [stdout] 201 | dispatchers: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:357:24 [INFO] [stdout] | [INFO] [stdout] 357 | panic!(format!("Unknown event {:?}!", e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 357 - panic!(format!("Unknown event {:?}!", e)); [INFO] [stdout] 357 + panic!("Unknown event {:?}!", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/mod.rs:51:48 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(tx: Sender>, rx: Receiver>) -> DispatcherHandle { [INFO] [stdout] | ------------------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | DispatcherHandle::with_stopper(tx, rx, Box::new(|| Ok(()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/am/dispatcher.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 125 | receivers: ReceiverRegistry, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | ) -> AMDispatcher { [INFO] [stdout] 127 | let (tx, connection_rx) = mpsc::channel(); [INFO] [stdout] | -- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let (connection_tx, rx) = mpsc::channel(); [INFO] [stdout] | ------------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | [INFO] [stdout] 130 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | let stopper_tx = connection_tx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | handle: Some(DispatcherHandle::with_stopper( [INFO] [stdout] | _____________________^ [INFO] [stdout] 149 | | connection_tx, [INFO] [stdout] 150 | | connection_rx, [INFO] [stdout] 151 | | Box::new(move || { [INFO] [stdout] ... | [INFO] [stdout] 159 | | }), [INFO] [stdout] 160 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/dispatcher/am/dispatcher.rs:247:29 [INFO] [stdout] | [INFO] [stdout] 247 | e => panic!(format!("Unexpected event {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 247 - e => panic!(format!("Unexpected event {:?}", e)), [INFO] [stdout] 247 + e => panic!("Unexpected event {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/am/receiver.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 39 | let (handle_tx, rx) = mpsc::channel(); [INFO] [stdout] | --------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | handle: Some(AMReceiverHandle { tx: handle_tx }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/raw.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 25 | let (transport_tx, rx) = mpsc::channel(); [INFO] [stdout] | ------------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let (tx, transport_rx) = mpsc::channel(); [INFO] [stdout] | -- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | handle: Some(DispatcherHandle::new(transport_tx, transport_rx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/mod.rs:41:41 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(tx: Sender>, rx: Receiver>) -> Transport { [INFO] [stdout] | ------------------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Transport::with_stopper(tx, rx, Box::new(|| Ok(()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/mod.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 46 | tx: Sender>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | rx: Receiver>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | stopper: Box Result<(), &'static str>>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | handle: Some(TransportHandle { tx, rx }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/serial/mod.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 81 | let (tx, connection_rx) = mpsc::channel(); [INFO] [stdout] | -- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (connection_tx, rx) = mpsc::channel(); [INFO] [stdout] | ------------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let loopback_tx = connection_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | connection_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/serial/mod.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 81 | let (tx, connection_rx) = mpsc::channel(); [INFO] [stdout] | -- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (connection_tx, rx) = mpsc::channel(); [INFO] [stdout] | ------------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let loopback_tx = connection_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | / Box::new(move || { [INFO] [stdout] 169 | | if connection_tx.send(Event::Stop).is_err() { [INFO] [stdout] 170 | | return Err("SFTransport thread already closed!"); [INFO] [stdout] 171 | | } [INFO] [stdout] ... | [INFO] [stdout] 175 | | Ok(()) [INFO] [stdout] 176 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/serialforwarder.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 48 | let (tcp_tx, transport_rx) = mpsc::channel(); [INFO] [stdout] | ------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let (transport_tx, tcp_rx) = mpsc::channel(); [INFO] [stdout] | ------------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let loopback_tx = transport_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | transport_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/serialforwarder.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 48 | let (tcp_tx, transport_rx) = mpsc::channel(); [INFO] [stdout] | ------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let (transport_tx, tcp_rx) = mpsc::channel(); [INFO] [stdout] | ------------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let loopback_tx = transport_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | / Box::new(move || { [INFO] [stdout] 134 | | if transport_tx.send(Event::Stop).is_err() { [INFO] [stdout] 135 | | return Err("SFTransport thread already closed!"); [INFO] [stdout] 136 | | } [INFO] [stdout] ... | [INFO] [stdout] 140 | | Ok(()) [INFO] [stdout] 141 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:43:25 [INFO] [stdout] | [INFO] [stdout] 40 | let (tx, internal_rx) = mpsc::channel(); [INFO] [stdout] | -- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let (internal_tx, rx) = mpsc::channel(); [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | TestTransport { [INFO] [stdout] 43 | handle: Rc::new(RefCell::new(Some(TransportHandle { tx, rx }))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 40 | let (tx, internal_rx) = mpsc::channel(); [INFO] [stdout] | -- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let (internal_tx, rx) = mpsc::channel(); [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | internal_tx: Rc::new(internal_tx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:45:30 [INFO] [stdout] | [INFO] [stdout] 40 | let (tx, internal_rx) = mpsc::channel(); [INFO] [stdout] | -- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let (internal_tx, rx) = mpsc::channel(); [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | internal_rx: Rc::new(internal_rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moteconnection` (lib) due to 15 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `internal_tx` and `internal_rx` are never read [INFO] [stdout] --> src/tests.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TestTransport { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 14 | pub handle: Rc>>, [INFO] [stdout] 15 | pub internal_tx: Rc>>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 16 | pub internal_rx: Rc>>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestTransport` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:201:26 [INFO] [stdout] | [INFO] [stdout] 199 | pub fn with_transport(transport: Box) -> ConnectionBuilder { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | ConnectionBuilder { [INFO] [stdout] 201 | dispatchers: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:357:24 [INFO] [stdout] | [INFO] [stdout] 357 | panic!(format!("Unknown event {:?}!", e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 357 - panic!(format!("Unknown event {:?}!", e)); [INFO] [stdout] 357 + panic!("Unknown event {:?}!", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:481:25 [INFO] [stdout] | [INFO] [stdout] 481 | e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 481 - e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] 481 + e => panic!("Unexpected output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:503:25 [INFO] [stdout] | [INFO] [stdout] 503 | e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 503 - e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] 503 + e => panic!("Unexpected output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:525:25 [INFO] [stdout] | [INFO] [stdout] 525 | e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 525 - e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] 525 + e => panic!("Unexpected output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:547:25 [INFO] [stdout] | [INFO] [stdout] 547 | e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 547 - e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] 547 + e => panic!("Unexpected output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:569:25 [INFO] [stdout] | [INFO] [stdout] 569 | e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 569 - e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] 569 + e => panic!("Unexpected output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:611:25 [INFO] [stdout] | [INFO] [stdout] 611 | e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 611 - e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] 611 + e => panic!("Unexpected output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/connection.rs:634:25 [INFO] [stdout] | [INFO] [stdout] 634 | e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 634 - e => panic!(format!("Unexpected output: {:?}", e)), [INFO] [stdout] 634 + e => panic!("Unexpected output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/mod.rs:51:48 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(tx: Sender>, rx: Receiver>) -> DispatcherHandle { [INFO] [stdout] | ------------------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | DispatcherHandle::with_stopper(tx, rx, Box::new(|| Ok(()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/am/dispatcher.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 125 | receivers: ReceiverRegistry, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | ) -> AMDispatcher { [INFO] [stdout] 127 | let (tx, connection_rx) = mpsc::channel(); [INFO] [stdout] | -- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let (connection_tx, rx) = mpsc::channel(); [INFO] [stdout] | ------------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | [INFO] [stdout] 130 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | let stopper_tx = connection_tx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | handle: Some(DispatcherHandle::with_stopper( [INFO] [stdout] | _____________________^ [INFO] [stdout] 149 | | connection_tx, [INFO] [stdout] 150 | | connection_rx, [INFO] [stdout] 151 | | Box::new(move || { [INFO] [stdout] ... | [INFO] [stdout] 159 | | }), [INFO] [stdout] 160 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/dispatcher/am/dispatcher.rs:247:29 [INFO] [stdout] | [INFO] [stdout] 247 | e => panic!(format!("Unexpected event {:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 247 - e => panic!(format!("Unexpected event {:?}", e)), [INFO] [stdout] 247 + e => panic!("Unexpected event {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/am/receiver.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 39 | let (handle_tx, rx) = mpsc::channel(); [INFO] [stdout] | --------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | handle: Some(AMReceiverHandle { tx: handle_tx }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/raw.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 25 | let (transport_tx, rx) = mpsc::channel(); [INFO] [stdout] | ------------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let (tx, transport_rx) = mpsc::channel(); [INFO] [stdout] | -- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | handle: Some(DispatcherHandle::new(transport_tx, transport_rx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/mod.rs:41:41 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(tx: Sender>, rx: Receiver>) -> Transport { [INFO] [stdout] | ------------------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Transport::with_stopper(tx, rx, Box::new(|| Ok(()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/mod.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 46 | tx: Sender>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | rx: Receiver>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | stopper: Box Result<(), &'static str>>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | handle: Some(TransportHandle { tx, rx }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/serial/mod.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 81 | let (tx, connection_rx) = mpsc::channel(); [INFO] [stdout] | -- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (connection_tx, rx) = mpsc::channel(); [INFO] [stdout] | ------------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let loopback_tx = connection_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | connection_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/serial/mod.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 81 | let (tx, connection_rx) = mpsc::channel(); [INFO] [stdout] | -- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (connection_tx, rx) = mpsc::channel(); [INFO] [stdout] | ------------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let loopback_tx = connection_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | / Box::new(move || { [INFO] [stdout] 169 | | if connection_tx.send(Event::Stop).is_err() { [INFO] [stdout] 170 | | return Err("SFTransport thread already closed!"); [INFO] [stdout] 171 | | } [INFO] [stdout] ... | [INFO] [stdout] 175 | | Ok(()) [INFO] [stdout] 176 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/serialforwarder.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 48 | let (tcp_tx, transport_rx) = mpsc::channel(); [INFO] [stdout] | ------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let (transport_tx, tcp_rx) = mpsc::channel(); [INFO] [stdout] | ------------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let loopback_tx = transport_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | transport_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/serialforwarder.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 48 | let (tcp_tx, transport_rx) = mpsc::channel(); [INFO] [stdout] | ------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let (transport_tx, tcp_rx) = mpsc::channel(); [INFO] [stdout] | ------------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let loopback_tx = transport_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let join_handle = Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | / Box::new(move || { [INFO] [stdout] 134 | | if transport_tx.send(Event::Stop).is_err() { [INFO] [stdout] 135 | | return Err("SFTransport thread already closed!"); [INFO] [stdout] 136 | | } [INFO] [stdout] ... | [INFO] [stdout] 140 | | Ok(()) [INFO] [stdout] 141 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/transport/serialforwarder.rs:397:25 [INFO] [stdout] | [INFO] [stdout] 397 | v => panic!(format!("Expected a closed stream, got {:?}", v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 397 - v => panic!(format!("Expected a closed stream, got {:?}", v)), [INFO] [stdout] 397 + v => panic!("Expected a closed stream, got {:?}", v), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:43:25 [INFO] [stdout] | [INFO] [stdout] 40 | let (tx, internal_rx) = mpsc::channel(); [INFO] [stdout] | -- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let (internal_tx, rx) = mpsc::channel(); [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | TestTransport { [INFO] [stdout] 43 | handle: Rc::new(RefCell::new(Some(TransportHandle { tx, rx }))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 40 | let (tx, internal_rx) = mpsc::channel(); [INFO] [stdout] | -- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let (internal_tx, rx) = mpsc::channel(); [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | internal_tx: Rc::new(internal_tx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:45:30 [INFO] [stdout] | [INFO] [stdout] 40 | let (tx, internal_rx) = mpsc::channel(); [INFO] [stdout] | -- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let (internal_tx, rx) = mpsc::channel(); [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | internal_rx: Rc::new(internal_rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moteconnection` (lib test) due to 15 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bc1cd70d35e3370365854ed09f198d528b831d1ffd8cc4295c143986562ba718", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc1cd70d35e3370365854ed09f198d528b831d1ffd8cc4295c143986562ba718", kill_on_drop: false }` [INFO] [stdout] bc1cd70d35e3370365854ed09f198d528b831d1ffd8cc4295c143986562ba718