[INFO] fetching crate moshudp 0.1.4... [INFO] checking moshudp-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate moshudp 0.1.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate moshudp 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate moshudp 0.1.4 [INFO] finished tweaking crates.io crate moshudp 0.1.4 [INFO] tweaked toml for crates.io crate moshudp 0.1.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate moshudp 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 986bd88b10f45f2f1b293873ce168c3d7f6ad84f288328c5b06659b8d39c6f33 [INFO] running `Command { std: "docker" "start" "-a" "986bd88b10f45f2f1b293873ce168c3d7f6ad84f288328c5b06659b8d39c6f33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "986bd88b10f45f2f1b293873ce168c3d7f6ad84f288328c5b06659b8d39c6f33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "986bd88b10f45f2f1b293873ce168c3d7f6ad84f288328c5b06659b8d39c6f33", kill_on_drop: false }` [INFO] [stdout] 986bd88b10f45f2f1b293873ce168c3d7f6ad84f288328c5b06659b8d39c6f33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41b8c131f5a59e606c4a6203a7887c79cd60053c8a9686f9fe3b51d2c2a1a7aa [INFO] running `Command { std: "docker" "start" "-a" "41b8c131f5a59e606c4a6203a7887c79cd60053c8a9686f9fe3b51d2c2a1a7aa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling libc v0.2.123 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking zeroize v1.4.3 [INFO] [stderr] Compiling argh_shared v0.1.7 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking chacha20 v0.8.1 [INFO] [stderr] Checking poly1305 v0.7.2 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking chacha20poly1305 v0.9.0 [INFO] [stderr] Compiling argh_derive v0.1.7 [INFO] [stderr] Compiling gumdrop_derive v0.8.1 [INFO] [stderr] Checking argh v0.1.7 [INFO] [stderr] Checking gumdrop v0.8.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking moshudp v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/server.rs:167:35 [INFO] [stdout] | [INFO] [stdout] 167 | Ok(sz) => (&buf[..sz]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 167 - Ok(sz) => (&buf[..sz]), [INFO] [stdout] 167 + Ok(sz) => &buf[..sz], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/server.rs:167:35 [INFO] [stdout] | [INFO] [stdout] 167 | Ok(sz) => (&buf[..sz]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 167 - Ok(sz) => (&buf[..sz]), [INFO] [stdout] 167 + Ok(sz) => &buf[..sz], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 108 | let crypto = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | chacha20poly1305::XChaCha20Poly1305::new(chacha20poly1305::Key::from_slice(&key)); [INFO] [stdout] 110 | client::Client::new(addr, crypto, ping)?.connect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 34 | crypto: XChaCha20Poly1305, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Client { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | client_socket: UdpSocket::bind(bind_sa)?, [INFO] [stdout] 45 | | crypto, [INFO] [stdout] 46 | | mosh: None, [INFO] [stdout] ... | [INFO] [stdout] 51 | | ping_mode, [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 203 | let udp = UdpSocket::bind(SocketAddr::V4(SocketAddrV4::new(Ipv4Addr::LOCALHOST, 0)))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let mut cmd = std::process::Command::new(mosh_client); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut child = cmd.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | Ok(MoshClientState { [INFO] [stdout] | ____________^ [INFO] [stdout] 226 | | //child, [INFO] [stdout] 227 | | socket: udp, [INFO] [stdout] 228 | | reply_address: None, [INFO] [stdout] 229 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:211:42 [INFO] [stdout] | [INFO] [stdout] 210 | let mut child = cmd.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | std::thread::spawn(move || match child.wait() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Serialize, Deserialize,Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(sa: SocketAddr, crypto: XChaCha20Poly1305) -> anyhow::Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | server_socket: UdpSocket::bind(sa)?, [INFO] [stdout] 37 | | crypto, [INFO] [stdout] 38 | | mosh: None, [INFO] [stdout] ... | [INFO] [stdout] 41 | | update_address_cooldown: Instant::now(), [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moshudp` (bin "moshudp" test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 108 | let crypto = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | chacha20poly1305::XChaCha20Poly1305::new(chacha20poly1305::Key::from_slice(&key)); [INFO] [stdout] 110 | client::Client::new(addr, crypto, ping)?.connect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 34 | crypto: XChaCha20Poly1305, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Client { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | client_socket: UdpSocket::bind(bind_sa)?, [INFO] [stdout] 45 | | crypto, [INFO] [stdout] 46 | | mosh: None, [INFO] [stdout] ... | [INFO] [stdout] 51 | | ping_mode, [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 203 | let udp = UdpSocket::bind(SocketAddr::V4(SocketAddrV4::new(Ipv4Addr::LOCALHOST, 0)))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let mut cmd = std::process::Command::new(mosh_client); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut child = cmd.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | Ok(MoshClientState { [INFO] [stdout] | ____________^ [INFO] [stdout] 226 | | //child, [INFO] [stdout] 227 | | socket: udp, [INFO] [stdout] 228 | | reply_address: None, [INFO] [stdout] 229 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:211:42 [INFO] [stdout] | [INFO] [stdout] 210 | let mut child = cmd.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | std::thread::spawn(move || match child.wait() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Serialize, Deserialize,Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(sa: SocketAddr, crypto: XChaCha20Poly1305) -> anyhow::Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | server_socket: UdpSocket::bind(sa)?, [INFO] [stdout] 37 | | crypto, [INFO] [stdout] 38 | | mosh: None, [INFO] [stdout] ... | [INFO] [stdout] 41 | | update_address_cooldown: Instant::now(), [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moshudp` (bin "moshudp") due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "41b8c131f5a59e606c4a6203a7887c79cd60053c8a9686f9fe3b51d2c2a1a7aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41b8c131f5a59e606c4a6203a7887c79cd60053c8a9686f9fe3b51d2c2a1a7aa", kill_on_drop: false }` [INFO] [stdout] 41b8c131f5a59e606c4a6203a7887c79cd60053c8a9686f9fe3b51d2c2a1a7aa