[INFO] fetching crate moro 0.4.0... [INFO] checking moro-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate moro 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate moro 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate moro 0.4.0 [INFO] finished tweaking crates.io crate moro 0.4.0 [INFO] tweaked toml for crates.io crate moro 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate moro 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 55fb411b01264fa8bd5a724d296204a630a76a56f917c6b15ca9ed0a8ba3f7b5 [INFO] running `Command { std: "docker" "start" "-a" "55fb411b01264fa8bd5a724d296204a630a76a56f917c6b15ca9ed0a8ba3f7b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "55fb411b01264fa8bd5a724d296204a630a76a56f917c6b15ca9ed0a8ba3f7b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55fb411b01264fa8bd5a724d296204a630a76a56f917c6b15ca9ed0a8ba3f7b5", kill_on_drop: false }` [INFO] [stdout] 55fb411b01264fa8bd5a724d296204a630a76a56f917c6b15ca9ed0a8ba3f7b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e5528699b85dad267724dc9ccc37e1916426d16e5601266ccbe9c536e6ba139 [INFO] running `Command { std: "docker" "start" "-a" "8e5528699b85dad267724dc9ccc37e1916426d16e5601266ccbe9c536e6ba139", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking cache-padded v1.2.0 [INFO] [stderr] Compiling async-trait v0.1.56 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking concurrent-queue v1.2.2 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking event-listener v2.5.2 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking async-channel v1.6.1 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.19.0 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking moro v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn scope_fn<'env, R, B>(body: B) -> ScopeBody<'env, R> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let scope = Scope::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let body_future = body(unsafe { &*scope_ref }); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | [INFO] [stdout] 156 | ScopeBody::new(body::Body::new(body_future, scope)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/body.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 28 | pub(crate) fn new(future: BoxFuture<'scope, R>, scope: Arc>) -> Self { [INFO] [stdout] | ---------------------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Self { [INFO] [stdout] 30 | body_future: Some(future), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/body.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 28 | pub(crate) fn new(future: BoxFuture<'scope, R>, scope: Arc>) -> Self { [INFO] [stdout] | ---------------------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | result: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result_ext.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 27 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | / { [INFO] [stdout] 34 | | match self { [INFO] [stdout] 35 | | Ok(o) => o, [INFO] [stdout] 36 | | Err(e) => scope.terminate(Err(e)).await, [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:124:20 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn terminate(&'scope self, value: R) -> impl Future + 'scope [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let mut lock = self.terminated.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | self.spawn(async { panic!() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 132 | future: impl Future + Send + 'scope, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let (tx, rx) = async_channel::bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Spawned::new(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 154 | | match rx.recv().await { [INFO] [stdout] 155 | | Ok(v) => v, [INFO] [stdout] 156 | | Err(e) => panic!("unexpected error: {e:?}"), [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 146 | let (tx, rx) = async_channel::bounded(1); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | match rx.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawned.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 41 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | scope.spawn(async { self.await.unwrap_or_cancel(scope).await }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawned.rs:49:64 [INFO] [stdout] | [INFO] [stdout] 41 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | scope.spawn(async { self.await.unwrap_or_cancel(scope).await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moro` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8e5528699b85dad267724dc9ccc37e1916426d16e5601266ccbe9c536e6ba139", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e5528699b85dad267724dc9ccc37e1916426d16e5601266ccbe9c536e6ba139", kill_on_drop: false }` [INFO] [stdout] 8e5528699b85dad267724dc9ccc37e1916426d16e5601266ccbe9c536e6ba139