[INFO] fetching crate mork 0.1.4... [INFO] checking mork-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mork 0.1.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mork 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate mork 0.1.4 [INFO] finished tweaking crates.io crate mork 0.1.4 [INFO] tweaked toml for crates.io crate mork 0.1.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate mork 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 07a46a4864c7b1fdc099a6d568d9dd6d919bc20786b43edebb42fe7d1825e184 [INFO] running `Command { std: "docker" "start" "-a" "07a46a4864c7b1fdc099a6d568d9dd6d919bc20786b43edebb42fe7d1825e184", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "07a46a4864c7b1fdc099a6d568d9dd6d919bc20786b43edebb42fe7d1825e184", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07a46a4864c7b1fdc099a6d568d9dd6d919bc20786b43edebb42fe7d1825e184", kill_on_drop: false }` [INFO] [stdout] 07a46a4864c7b1fdc099a6d568d9dd6d919bc20786b43edebb42fe7d1825e184 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b46e67c086eb49754bab5860ebd410a0ea5fc1e96a627cf1f3a3fe2a5244b390 [INFO] running `Command { std: "docker" "start" "-a" "b46e67c086eb49754bab5860ebd410a0ea5fc1e96a627cf1f3a3fe2a5244b390", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking mio v0.8.1 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking whoami v1.2.1 [INFO] [stderr] Checking ip_rfc v0.1.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling darling_core v0.13.1 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Compiling darling_macro v0.13.1 [INFO] [stderr] Compiling darling v0.13.1 [INFO] [stderr] Checking dovepipe v0.1.6 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Compiling mork-message-derive v0.1.0 [INFO] [stderr] Checking mork v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `target` [INFO] [stdout] --> src/client/recieving.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(target = "windows")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(target, values("windows"))'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(target, values(\"windows\"))");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/main.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | loop { [INFO] [stdout] | _____^ - [INFO] [stdout] | |__________| [INFO] [stdout] 106 | || // Recieve message [INFO] [stdout] 107 | || let mut buf = [0u8; 8192]; [INFO] [stdout] 108 | || let (amt, src) = sock.recv_from(&mut buf).await?; [INFO] [stdout] ... || [INFO] [stdout] 164 | || } [INFO] [stdout] 165 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `target` [INFO] [stdout] --> src/client/recieving.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(target = "windows")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(target, values("windows"))'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(target, values(\"windows\"))");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mork` (bin "mork-server") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/main.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | loop { [INFO] [stdout] | _____^ - [INFO] [stdout] | |__________| [INFO] [stdout] 106 | || // Recieve message [INFO] [stdout] 107 | || let mut buf = [0u8; 8192]; [INFO] [stdout] 108 | || let (amt, src) = sock.recv_from(&mut buf).await?; [INFO] [stdout] ... || [INFO] [stdout] 164 | || } [INFO] [stdout] 165 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mork` (bin "mork-server" test) due to 2 previous errors [INFO] [stdout] warning: struct `NotRightAmountError` is never constructed [INFO] [stdout] --> src/client/main.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 165 | struct NotRightAmountError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/main.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 225 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/sending.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 20 | let file = File::open(file_name)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | Ok(file.metadata().unwrap().len()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mork` (bin "mork") due to 3 previous errors; 2 warnings emitted [INFO] [stdout] warning: struct `NotRightAmountError` is never constructed [INFO] [stdout] --> src/client/main.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 165 | struct NotRightAmountError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/main.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 225 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/sending.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 20 | let file = File::open(file_name)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | Ok(file.metadata().unwrap().len()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mork` (bin "mork" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b46e67c086eb49754bab5860ebd410a0ea5fc1e96a627cf1f3a3fe2a5244b390", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b46e67c086eb49754bab5860ebd410a0ea5fc1e96a627cf1f3a3fe2a5244b390", kill_on_drop: false }` [INFO] [stdout] b46e67c086eb49754bab5860ebd410a0ea5fc1e96a627cf1f3a3fe2a5244b390