[INFO] fetching crate more-sync 0.1.5... [INFO] checking more-sync-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate more-sync 0.1.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate more-sync 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate more-sync 0.1.5 [INFO] finished tweaking crates.io crate more-sync 0.1.5 [INFO] tweaked toml for crates.io crate more-sync 0.1.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 156ac8512286334260a9e87928fb7d6e91b253723f65dcb8675a60457c8b56bb [INFO] running `Command { std: "docker" "start" "-a" "156ac8512286334260a9e87928fb7d6e91b253723f65dcb8675a60457c8b56bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "156ac8512286334260a9e87928fb7d6e91b253723f65dcb8675a60457c8b56bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "156ac8512286334260a9e87928fb7d6e91b253723f65dcb8675a60457c8b56bb", kill_on_drop: false }` [INFO] [stdout] 156ac8512286334260a9e87928fb7d6e91b253723f65dcb8675a60457c8b56bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac27db51b0b9549a134a3521cdaa642bd7c04f50d986b6121deab825269a6290 [INFO] running `Command { std: "docker" "start" "-a" "ac27db51b0b9549a134a3521cdaa642bd7c04f50d986b6121deab825269a6290", kill_on_drop: false }` [INFO] [stderr] Checking more-sync v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carrier/mod.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(target: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Self { [INFO] [stdout] 54 | template: Arc::new(CarrierTarget { [INFO] [stdout] | _______________________^ [INFO] [stdout] 55 | | target, [INFO] [stdout] 56 | | condvar: Default::default(), [INFO] [stdout] 57 | | count: Mutex::new(0), [INFO] [stdout] 58 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carrier/mod.rs:105:15 [INFO] [stdout] | [INFO] [stdout] 97 | fn unwrap_or_panic(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let arc = self.template; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | match Arc::try_unwrap(arc) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carrier/mod.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 217 | let mut count = inner.lock_count(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | inner: inner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_parker/mod.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { [INFO] [stdout] 61 | inner: Arc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 62 | | version: AtomicUsize::new(0), [INFO] [stdout] 63 | | data: Mutex::new(data), [INFO] [stdout] 64 | | condvar: Condvar::new(), [INFO] [stdout] 65 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_parker/mod.rs:77:20 [INFO] [stdout] | [INFO] [stdout] 74 | let guard = self.inner.data.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | guard: Some(guard), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `more-sync` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carrier/mod.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(target: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Self { [INFO] [stdout] 54 | template: Arc::new(CarrierTarget { [INFO] [stdout] | _______________________^ [INFO] [stdout] 55 | | target, [INFO] [stdout] 56 | | condvar: Default::default(), [INFO] [stdout] 57 | | count: Mutex::new(0), [INFO] [stdout] 58 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `more-sync` (lib test) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carrier/mod.rs:105:15 [INFO] [stdout] | [INFO] [stdout] 97 | fn unwrap_or_panic(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let arc = self.template; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | match Arc::try_unwrap(arc) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carrier/mod.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 217 | let mut count = inner.lock_count(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | inner: inner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carrier/mod.rs:270:36 [INFO] [stdout] | [INFO] [stdout] 263 | let carrier = Carrier::new(7usize); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | std::thread::spawn(|| (carrier.create_ref(), carrier)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_parker/mod.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { [INFO] [stdout] 61 | inner: Arc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 62 | | version: AtomicUsize::new(0), [INFO] [stdout] 63 | | data: Mutex::new(data), [INFO] [stdout] 64 | | condvar: Condvar::new(), [INFO] [stdout] 65 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_parker/mod.rs:77:20 [INFO] [stdout] | [INFO] [stdout] 74 | let guard = self.inner.data.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | guard: Some(guard), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "ac27db51b0b9549a134a3521cdaa642bd7c04f50d986b6121deab825269a6290", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac27db51b0b9549a134a3521cdaa642bd7c04f50d986b6121deab825269a6290", kill_on_drop: false }` [INFO] [stdout] ac27db51b0b9549a134a3521cdaa642bd7c04f50d986b6121deab825269a6290