[INFO] fetching crate moq-pub 0.7.0... [INFO] checking moq-pub-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate moq-pub 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate moq-pub 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate moq-pub 0.7.0 [INFO] finished tweaking crates.io crate moq-pub 0.7.0 [INFO] tweaked toml for crates.io crate moq-pub 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate moq-pub 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c63df930c7dbf2864fe36fe9574a4721c7a8def0df7496ae4423fa4d8929b65e [INFO] running `Command { std: "docker" "start" "-a" "c63df930c7dbf2864fe36fe9574a4721c7a8def0df7496ae4423fa4d8929b65e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c63df930c7dbf2864fe36fe9574a4721c7a8def0df7496ae4423fa4d8929b65e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c63df930c7dbf2864fe36fe9574a4721c7a8def0df7496ae4423fa4d8929b65e", kill_on_drop: false }` [INFO] [stdout] c63df930c7dbf2864fe36fe9574a4721c7a8def0df7496ae4423fa4d8929b65e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4bb9e4239ff8cf2bf63dba3f45d057e6a1f783f1b7abbc7053d077c046b631d0 [INFO] running `Command { std: "docker" "start" "-a" "4bb9e4239ff8cf2bf63dba3f45d057e6a1f783f1b7abbc7053d077c046b631d0", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling dunce v1.0.4 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling aws-lc-rs v1.7.1 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Compiling rustls v0.23.7 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Compiling anyhow v1.0.85 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking four-cc v0.4.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking mp4ra-rust v0.3.0 [INFO] [stderr] Checking rustls-native-certs v0.7.0 [INFO] [stderr] Checking mpeg4-audio-const v0.2.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking rfc6381-codec v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking num-bigint v0.4.5 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling aws-lc-sys v0.16.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking web-transport-proto v0.2.0 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking quinn-udp v0.5.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking moq-catalog v0.2.0 [INFO] [stderr] Checking mp4 v0.14.0 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Checking rustls-platform-verifier v0.3.1 [INFO] [stderr] Checking quinn-proto v0.11.1 [INFO] [stderr] Checking quinn v0.11.0 [INFO] [stderr] Checking web-transport-quinn v0.3.0 [INFO] [stderr] Checking web-transport v0.3.0 [INFO] [stderr] Checking moq-transport v0.6.0 [INFO] [stderr] Checking moq-native v0.4.0 [INFO] [stderr] Checking moq-pub v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/media.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(mut broadcast: TracksWriter) -> anyhow::Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let catalog = broadcast.create(".catalog").context("broadcast closed")?.groups()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let init = broadcast.create("0.mp4").context("broadcast closed")?.groups()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | Ok(Media { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | tracks: Default::default(), [INFO] [stdout] 36 | | broadcast, [INFO] [stdout] 37 | | catalog, [INFO] [stdout] ... | [INFO] [stdout] 41 | | current: None, [INFO] [stdout] 42 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/media.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 265 | 0 => anyhow::bail!("TODO: unsupported EOF atom"), [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | let atom = buf.copy_to_bytes(size); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | [INFO] [stdout] 287 | Ok(Some(atom)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/media.rs:307:11 [INFO] [stdout] | [INFO] [stdout] 305 | fn new(track: TrackWriter, handler: TrackType, timescale: u64) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Self { [INFO] [stdout] 307 | track: track.groups().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/media.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 305 | fn new(track: TrackWriter, handler: TrackType, timescale: u64) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | current: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/media.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(mut broadcast: TracksWriter) -> anyhow::Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let catalog = broadcast.create(".catalog").context("broadcast closed")?.groups()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let init = broadcast.create("0.mp4").context("broadcast closed")?.groups()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | Ok(Media { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | tracks: Default::default(), [INFO] [stdout] 36 | | broadcast, [INFO] [stdout] 37 | | catalog, [INFO] [stdout] ... | [INFO] [stdout] 41 | | current: None, [INFO] [stdout] 42 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/media.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 265 | 0 => anyhow::bail!("TODO: unsupported EOF atom"), [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | let atom = buf.copy_to_bytes(size); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | [INFO] [stdout] 287 | Ok(Some(atom)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/media.rs:307:11 [INFO] [stdout] | [INFO] [stdout] 305 | fn new(track: TrackWriter, handler: TrackType, timescale: u64) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Self { [INFO] [stdout] 307 | track: track.groups().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/media.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 305 | fn new(track: TrackWriter, handler: TrackType, timescale: u64) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | current: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moq-pub` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `moq-pub` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "4bb9e4239ff8cf2bf63dba3f45d057e6a1f783f1b7abbc7053d077c046b631d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bb9e4239ff8cf2bf63dba3f45d057e6a1f783f1b7abbc7053d077c046b631d0", kill_on_drop: false }` [INFO] [stdout] 4bb9e4239ff8cf2bf63dba3f45d057e6a1f783f1b7abbc7053d077c046b631d0