[INFO] fetching crate moore-derive 0.14.0... [INFO] checking moore-derive-0.14.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate moore-derive 0.14.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate moore-derive 0.14.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate moore-derive 0.14.0 [INFO] finished tweaking crates.io crate moore-derive 0.14.0 [INFO] tweaked toml for crates.io crate moore-derive 0.14.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f76a9c910643e2c9a706a16a662fcd842057ca6cf196427e323100c39a78cd18 [INFO] running `Command { std: "docker" "start" "-a" "f76a9c910643e2c9a706a16a662fcd842057ca6cf196427e323100c39a78cd18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f76a9c910643e2c9a706a16a662fcd842057ca6cf196427e323100c39a78cd18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f76a9c910643e2c9a706a16a662fcd842057ca6cf196427e323100c39a78cd18", kill_on_drop: false }` [INFO] [stdout] f76a9c910643e2c9a706a16a662fcd842057ca6cf196427e323100c39a78cd18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] edd6bd388056198d046ff0d362f3fbe90be6121504fca22f8c0a6b590bb8dd2d [INFO] running `Command { std: "docker" "start" "-a" "edd6bd388056198d046ff0d362f3fbe90be6121504fca22f8c0a6b590bb8dd2d", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking heck v0.3.3 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking moore-derive v0.14.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> all_node.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | NODES.with(|c| c.borrow_mut().push(node)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> all_node.rs:34:56 [INFO] [stdout] | [INFO] [stdout] 34 | let nodes = NODES.with(|c| std::mem::replace(&mut *c.borrow_mut(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> arena.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 30 | TYPES.with(|c| c.borrow_mut().push(node)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> arena.rs:51:56 [INFO] [stdout] | [INFO] [stdout] 51 | let types = TYPES.with(|c| std::mem::replace(&mut *c.borrow_mut(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> node_data.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 269 | tokens: proc_macro2::TokenStream, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | / tokens [INFO] [stdout] 273 | | .into_iter() [INFO] [stdout] 274 | | .map(|tkn| match tkn { [INFO] [stdout] 275 | | proc_macro2::TokenTree::Ident(id) => { [INFO] [stdout] ... | [INFO] [stdout] 283 | | _ => tkn, [INFO] [stdout] 284 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> query.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | QUERIES.with(|c| c.borrow_mut().push(input.to_token_stream().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> query.rs:25:42 [INFO] [stdout] | [INFO] [stdout] 25 | QUERIES.with(|c| c.borrow_mut().push(input.to_token_stream().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> query.rs:41:60 [INFO] [stdout] | [INFO] [stdout] 41 | let queries = QUERIES.with(|c| std::mem::replace(&mut *c.borrow_mut(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> visitor.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | CALLS.with(|c| c.borrow_mut().push(call)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> visitor.rs:36:56 [INFO] [stdout] | [INFO] [stdout] 36 | let calls = CALLS.with(|c| std::mem::replace(&mut *c.borrow_mut(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moore-derive` (lib test) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> all_node.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | NODES.with(|c| c.borrow_mut().push(node)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> all_node.rs:34:56 [INFO] [stdout] | [INFO] [stdout] 34 | let nodes = NODES.with(|c| std::mem::replace(&mut *c.borrow_mut(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> arena.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 30 | TYPES.with(|c| c.borrow_mut().push(node)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> arena.rs:51:56 [INFO] [stdout] | [INFO] [stdout] 51 | let types = TYPES.with(|c| std::mem::replace(&mut *c.borrow_mut(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> node_data.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 269 | tokens: proc_macro2::TokenStream, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | / tokens [INFO] [stdout] 273 | | .into_iter() [INFO] [stdout] 274 | | .map(|tkn| match tkn { [INFO] [stdout] 275 | | proc_macro2::TokenTree::Ident(id) => { [INFO] [stdout] ... | [INFO] [stdout] 283 | | _ => tkn, [INFO] [stdout] 284 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> query.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | QUERIES.with(|c| c.borrow_mut().push(input.to_token_stream().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> query.rs:25:42 [INFO] [stdout] | [INFO] [stdout] 25 | QUERIES.with(|c| c.borrow_mut().push(input.to_token_stream().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> query.rs:41:60 [INFO] [stdout] | [INFO] [stdout] 41 | let queries = QUERIES.with(|c| std::mem::replace(&mut *c.borrow_mut(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> visitor.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | CALLS.with(|c| c.borrow_mut().push(call)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> visitor.rs:36:56 [INFO] [stdout] | [INFO] [stdout] 36 | let calls = CALLS.with(|c| std::mem::replace(&mut *c.borrow_mut(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moore-derive` (lib) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "edd6bd388056198d046ff0d362f3fbe90be6121504fca22f8c0a6b590bb8dd2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edd6bd388056198d046ff0d362f3fbe90be6121504fca22f8c0a6b590bb8dd2d", kill_on_drop: false }` [INFO] [stdout] edd6bd388056198d046ff0d362f3fbe90be6121504fca22f8c0a6b590bb8dd2d