[INFO] fetching crate monster 0.1.28... [INFO] checking monster-0.1.28 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate monster 0.1.28 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate monster 0.1.28 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate monster 0.1.28 [INFO] finished tweaking crates.io crate monster 0.1.28 [INFO] tweaked toml for crates.io crate monster 0.1.28 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] [stderr] Adding lazy_static v0.1.16 (latest: v1.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b72226d0cd3ddba4c162248a94f8af198e255735da64fdb9d616fb8c190e1df [INFO] running `Command { std: "docker" "start" "-a" "9b72226d0cd3ddba4c162248a94f8af198e255735da64fdb9d616fb8c190e1df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b72226d0cd3ddba4c162248a94f8af198e255735da64fdb9d616fb8c190e1df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b72226d0cd3ddba4c162248a94f8af198e255735da64fdb9d616fb8c190e1df", kill_on_drop: false }` [INFO] [stdout] 9b72226d0cd3ddba4c162248a94f8af198e255735da64fdb9d616fb8c190e1df [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 599af9a561b9705c483032958e7608493289477d713b1b9e38b1b71fcc92dfb2 [INFO] running `Command { std: "docker" "start" "-a" "599af9a561b9705c483032958e7608493289477d713b1b9e38b1b71fcc92dfb2", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Checking monster v0.1.28 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | try!(write_format(&mut buffer, fmt, args)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | _ => try!(buffer.write_char(ch)) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | try!(buffer.write_char(ch)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:59:38 [INFO] [stdout] | [INFO] [stdout] 59 | Some(arg) => try!(write!(buffer, "{}", arg)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 68 | try!(buffer.write_char(ch)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/incubation/map_ref_mut.rs:21:25 [INFO] [stdout] | [INFO] [stdout] 21 | let dummy: T = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/incubation/fmt/mod.rs:39:67 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn write_format(buffer: &mut W, fmt: &str, args: &[&Display]) -> Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | pub fn write_format(buffer: &mut W, fmt: &str, args: &[&dyn Display]) -> Result<()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/incubation/fmt/mod.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn format(fmt: &str, args: &[&Display]) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | pub fn format(fmt: &str, args: &[&dyn Display]) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/incubation/fmt/error.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | write!(f, "Formatting error: {}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | try!(write_format(&mut buffer, fmt, args)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | _ => try!(buffer.write_char(ch)) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | try!(buffer.write_char(ch)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:59:38 [INFO] [stdout] | [INFO] [stdout] 59 | Some(arg) => try!(write!(buffer, "{}", arg)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/incubation/fmt/mod.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 68 | try!(buffer.write_char(ch)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/incubation/fmt/mod.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | _ => return return Err(Error::UnexpectedRightBrace) // No standalone right brace allowed [INFO] [stdout] | ^^^^^^^--------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/incubation/map_ref_mut.rs:21:25 [INFO] [stdout] | [INFO] [stdout] 21 | let dummy: T = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/incubation/fmt/mod.rs:39:67 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn write_format(buffer: &mut W, fmt: &str, args: &[&Display]) -> Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | pub fn write_format(buffer: &mut W, fmt: &str, args: &[&dyn Display]) -> Result<()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/incubation/fmt/mod.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn format(fmt: &str, args: &[&Display]) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | pub fn format(fmt: &str, args: &[&dyn Display]) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/incubation/zip_ends.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 49 | fn zip_ends(self) -> ZipEnds { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | ZipEnds { [INFO] [stdout] 51 | iter: self.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/incubation/ref_eq.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | / &**self as *const ::Target == [INFO] [stdout] 6 | | &**other as *const ::Target [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 5 | std::ptr::addr_eq(&**self as *const ::Target, &**other as *const ::Target) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 5 | std::ptr::eq(&**self as *const ::Target, &**other as *const ::Target) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/incubation/global_init_cleanup.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 54 | let mut handle = handle.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | / handle.as_ref() [INFO] [stdout] 56 | | .and_then(Weak::upgrade) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/incubation/with_lock.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 21 | fn with_lock R, R>(&self, f: F) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | f(&mut self.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monster` (lib) due to 4 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/incubation/fmt/error.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | write!(f, "Formatting error: {}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/incubation/fmt/mod.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | _ => return return Err(Error::UnexpectedRightBrace) // No standalone right brace allowed [INFO] [stdout] | ^^^^^^^--------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/incubation/zip_ends.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 49 | fn zip_ends(self) -> ZipEnds { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | ZipEnds { [INFO] [stdout] 51 | iter: self.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/incubation/ref_eq.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | / &**self as *const ::Target == [INFO] [stdout] 6 | | &**other as *const ::Target [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 5 | std::ptr::addr_eq(&**self as *const ::Target, &**other as *const ::Target) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 5 | std::ptr::eq(&**self as *const ::Target, &**other as *const ::Target) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/incubation/global_init_cleanup.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 54 | let mut handle = handle.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | / handle.as_ref() [INFO] [stdout] 56 | | .and_then(Weak::upgrade) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/incubation/with_lock.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 21 | fn with_lock R, R>(&self, f: F) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | f(&mut self.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monster` (lib test) due to 4 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "599af9a561b9705c483032958e7608493289477d713b1b9e38b1b71fcc92dfb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "599af9a561b9705c483032958e7608493289477d713b1b9e38b1b71fcc92dfb2", kill_on_drop: false }` [INFO] [stdout] 599af9a561b9705c483032958e7608493289477d713b1b9e38b1b71fcc92dfb2