[INFO] fetching crate monoio-client 0.1.0... [INFO] checking monoio-client-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate monoio-client 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate monoio-client 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate monoio-client 0.1.0 [INFO] finished tweaking crates.io crate monoio-client 0.1.0 [INFO] tweaked toml for crates.io crate monoio-client 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 52 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding memoffset v0.7.1 (latest: v0.9.1) [INFO] [stderr] Adding mio v0.8.11 (latest: v1.0.2) [INFO] [stderr] Adding monoio v0.1.9 (latest: v0.2.4) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0144efde3ccc0d024d2e359d3f13ad2c154515ae007e417186f080025aefc646 [INFO] running `Command { std: "docker" "start" "-a" "0144efde3ccc0d024d2e359d3f13ad2c154515ae007e417186f080025aefc646", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0144efde3ccc0d024d2e359d3f13ad2c154515ae007e417186f080025aefc646", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0144efde3ccc0d024d2e359d3f13ad2c154515ae007e417186f080025aefc646", kill_on_drop: false }` [INFO] [stdout] 0144efde3ccc0d024d2e359d3f13ad2c154515ae007e417186f080025aefc646 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 09c09e73792c0577a8e86fab413bcd281aa04d594c7f9721ce100483d8641737 [INFO] running `Command { std: "docker" "start" "-a" "09c09e73792c0577a8e86fab413bcd281aa04d594c7f9721ce100483d8641737", kill_on_drop: false }` [INFO] [stderr] Compiling io-uring v0.6.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking local-sync v0.1.1 [INFO] [stderr] Compiling auto-const-array v0.2.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling monoio-macros v0.1.0 [INFO] [stderr] Checking monoio v0.1.9 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking monoio-client v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | fn ready(mut self) -> PooledConnectionInner { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | self.inner.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:181:15 [INFO] [stdout] | [INFO] [stdout] 172 | let inner = match self.inner.take() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Some(i) => i, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let key = inner.key; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | [INFO] [stdout] 181 | match PooledConnection::pool(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 293 | pub(crate) fn from_builder(builder: ClientBuilder) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | Self { [INFO] [stdout] 295 | inner: Rc::new(ClientInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 296 | | connector: builder.connector, [INFO] [stdout] 297 | | slots: UnsafeCell::new(Slots { [INFO] [stdout] 298 | | map: HashMap::with_capacity(builder.config.max_size), [INFO] [stdout] ... | [INFO] [stdout] 304 | | hooks: builder.hooks, [INFO] [stdout] 305 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/builder.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub(crate) fn new(connector: M) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | hooks: Hooks::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/hooks.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 34 | f: impl Fn(&mut M::Connection, &Metrics) -> HookResult + 'static, [INFO] [stdout] | -------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | ) -> Self { [INFO] [stdout] 36 | Self::Fn(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/hooks.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 40 | f: impl for<'a> Fn(&'a mut M::Connection, &'a Metrics) -> HookFuture<'a, M::Error> + 'static, [INFO] [stdout] | -------------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Self { [INFO] [stdout] 42 | Self::AsyncFn(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp_client/mod.rs:177:16 [INFO] [stdout] | [INFO] [stdout] 170 | let stream = TcpStream::connect(key).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(TcpConn { [INFO] [stdout] | ________________^ [INFO] [stdout] 178 | | inner: stream, [INFO] [stdout] 179 | | io_error: None, [INFO] [stdout] 180 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | fn ready(mut self) -> PooledConnectionInner { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | self.inner.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:181:15 [INFO] [stdout] | [INFO] [stdout] 172 | let inner = match self.inner.take() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Some(i) => i, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let key = inner.key; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | [INFO] [stdout] 181 | match PooledConnection::pool(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 293 | pub(crate) fn from_builder(builder: ClientBuilder) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | Self { [INFO] [stdout] 295 | inner: Rc::new(ClientInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 296 | | connector: builder.connector, [INFO] [stdout] 297 | | slots: UnsafeCell::new(Slots { [INFO] [stdout] 298 | | map: HashMap::with_capacity(builder.config.max_size), [INFO] [stdout] ... | [INFO] [stdout] 304 | | hooks: builder.hooks, [INFO] [stdout] 305 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/builder.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub(crate) fn new(connector: M) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | hooks: Hooks::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/hooks.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 34 | f: impl Fn(&mut M::Connection, &Metrics) -> HookResult + 'static, [INFO] [stdout] | -------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | ) -> Self { [INFO] [stdout] 36 | Self::Fn(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/hooks.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 40 | f: impl for<'a> Fn(&'a mut M::Connection, &'a Metrics) -> HookFuture<'a, M::Error> + 'static, [INFO] [stdout] | -------------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Self { [INFO] [stdout] 42 | Self::AsyncFn(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp_client/mod.rs:177:16 [INFO] [stdout] | [INFO] [stdout] 170 | let stream = TcpStream::connect(key).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(TcpConn { [INFO] [stdout] | ________________^ [INFO] [stdout] 178 | | inner: stream, [INFO] [stdout] 179 | | io_error: None, [INFO] [stdout] 180 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monoio-client` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monoio-client` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "09c09e73792c0577a8e86fab413bcd281aa04d594c7f9721ce100483d8641737", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09c09e73792c0577a8e86fab413bcd281aa04d594c7f9721ce100483d8641737", kill_on_drop: false }` [INFO] [stdout] 09c09e73792c0577a8e86fab413bcd281aa04d594c7f9721ce100483d8641737