[INFO] fetching crate monkey-evaluator 0.3.0... [INFO] checking monkey-evaluator-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate monkey-evaluator 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate monkey-evaluator 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate monkey-evaluator 0.3.0 [INFO] finished tweaking crates.io crate monkey-evaluator 0.3.0 [INFO] tweaked toml for crates.io crate monkey-evaluator 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate monkey-evaluator 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3035ea10e055a1383632c50dd5c8b98e88db82cd7350353af5b61a6d03b153bd [INFO] running `Command { std: "docker" "start" "-a" "3035ea10e055a1383632c50dd5c8b98e88db82cd7350353af5b61a6d03b153bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3035ea10e055a1383632c50dd5c8b98e88db82cd7350353af5b61a6d03b153bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3035ea10e055a1383632c50dd5c8b98e88db82cd7350353af5b61a6d03b153bd", kill_on_drop: false }` [INFO] [stdout] 3035ea10e055a1383632c50dd5c8b98e88db82cd7350353af5b61a6d03b153bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7fc936ae75be10896ef6b144e4c3654ac19e30d4662dbc29f81c393abe74e67d [INFO] running `Command { std: "docker" "start" "-a" "7fc936ae75be10896ef6b144e4c3654ac19e30d4662dbc29f81c393abe74e67d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.10 [INFO] [stderr] Compiling syn v1.0.54 [INFO] [stderr] Compiling siphasher v0.3.3 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking monkey-lexer v0.3.0 [INFO] [stderr] Checking monkey-parser v0.3.0 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking monkey-evaluator v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 208 | let result = match &op.kind { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | Ok(Rc::from(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:230:8 [INFO] [stdout] | [INFO] [stdout] 224 | let result = match &op.kind { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | Ok(Rc::from(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:241:8 [INFO] [stdout] | [INFO] [stdout] 234 | let result = match &op.kind { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(Rc::from(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> builtins.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn len(args: Vec>) -> Rc { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Rc::from(match &*args[0] { [INFO] [stdout] | ______________^ [INFO] [stdout] 24 | | Object::String(s) => Object::Integer(s.len() as i64), [INFO] [stdout] 25 | | Object::Array(a) => Object::Integer(a.len() as i64), [INFO] [stdout] 26 | | o => Object::Error(format!("builtin len not supported for for type {}", o)) [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> builtins.rs:32:14 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn puts(args: Vec>) -> Rc { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | args.iter().for_each(|obj| println!("{}", obj)); [INFO] [stdout] 32 | Rc::from(Object::Null) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> object.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | t => panic!(format!("can't hashable for {}" ,t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 68 - t => panic!(format!("can't hashable for {}" ,t)) [INFO] [stdout] 68 + t => panic!("can't hashable for {}" ,t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monkey-evaluator` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 208 | let result = match &op.kind { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | Ok(Rc::from(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:230:8 [INFO] [stdout] | [INFO] [stdout] 224 | let result = match &op.kind { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | Ok(Rc::from(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:241:8 [INFO] [stdout] | [INFO] [stdout] 234 | let result = match &op.kind { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(Rc::from(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> builtins.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn len(args: Vec>) -> Rc { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Rc::from(match &*args[0] { [INFO] [stdout] | ______________^ [INFO] [stdout] 24 | | Object::String(s) => Object::Integer(s.len() as i64), [INFO] [stdout] 25 | | Object::Array(a) => Object::Integer(a.len() as i64), [INFO] [stdout] 26 | | o => Object::Error(format!("builtin len not supported for for type {}", o)) [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> builtins.rs:32:14 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn puts(args: Vec>) -> Rc { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | args.iter().for_each(|obj| println!("{}", obj)); [INFO] [stdout] 32 | Rc::from(Object::Null) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> object.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | t => panic!(format!("can't hashable for {}" ,t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 68 - t => panic!(format!("can't hashable for {}" ,t)) [INFO] [stdout] 68 + t => panic!("can't hashable for {}" ,t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monkey-evaluator` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7fc936ae75be10896ef6b144e4c3654ac19e30d4662dbc29f81c393abe74e67d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fc936ae75be10896ef6b144e4c3654ac19e30d4662dbc29f81c393abe74e67d", kill_on_drop: false }` [INFO] [stdout] 7fc936ae75be10896ef6b144e4c3654ac19e30d4662dbc29f81c393abe74e67d