[INFO] fetching crate monade-mprocs 0.2.1... [INFO] checking monade-mprocs-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate monade-mprocs 0.2.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate monade-mprocs 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate monade-mprocs 0.2.1 [INFO] finished tweaking crates.io crate monade-mprocs 0.2.1 [INFO] tweaked toml for crates.io crate monade-mprocs 0.2.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate monade-mprocs 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d1d5d431371488854dad3a7bffac097b1e1ec165a946dca05c64e8dbf3e345d [INFO] running `Command { std: "docker" "start" "-a" "6d1d5d431371488854dad3a7bffac097b1e1ec165a946dca05c64e8dbf3e345d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d1d5d431371488854dad3a7bffac097b1e1ec165a946dca05c64e8dbf3e345d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d1d5d431371488854dad3a7bffac097b1e1ec165a946dca05c64e8dbf3e345d", kill_on_drop: false }` [INFO] [stdout] 6d1d5d431371488854dad3a7bffac097b1e1ec165a946dca05c64e8dbf3e345d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a61d64619aa1366dea01339cd1b5d93bb75e2cfd7735404e0cb26ac5a7ea6a92 [INFO] running `Command { std: "docker" "start" "-a" "a61d64619aa1366dea01339cd1b5d93bb75e2cfd7735404e0cb26ac5a7ea6a92", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling proc-macro2 v1.0.30 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling signal-hook v0.3.13 [INFO] [stderr] Checking smallvec v1.8.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking futures-sink v0.3.25 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Checking futures-channel v0.3.21 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.44 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Compiling tokio v1.22.0 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Checking num_threads v0.1.5 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking triggered v0.1.2 [INFO] [stderr] Checking dunce v1.0.2 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking clipboard-win v4.4.2 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking vte v0.10.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking nix v0.24.2 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking which v4.2.5 [INFO] [stderr] Compiling getrandom v0.2.6 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking xdg v2.4.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking crossterm v0.23.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking mprocs-vt100 v0.1.1 [INFO] [stderr] Checking tui v0.18.0 [INFO] [stderr] Checking tui-input v0.4.0 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking futures-util v0.3.21 [INFO] [stderr] Checking filedescriptor v0.8.1 [INFO] [stderr] Checking flexi_logger v0.22.3 [INFO] [stderr] Checking mprocs-pty v0.1.0 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking serde_yaml v0.8.24 [INFO] [stderr] Checking clap v3.1.8 [INFO] [stderr] Checking monade-mprocs v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `io::Read` [INFO] [stdout] --> lib.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | use std::{io::Read, path::Path}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> lib.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flexi_logger::FileSpec` [INFO] [stdout] --> lib.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | use flexi_logger::FileSpec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `io::Read` [INFO] [stdout] --> lib.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | use std::{io::Read, path::Path}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> lib.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flexi_logger::FileSpec` [INFO] [stdout] --> lib.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | use flexi_logger::FileSpec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> lib.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | let mut config = if let Some((v, ctx)) = config_value { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> lib.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | let mut config = if let Some((v, ctx)) = config_value { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> lib.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | let mut reader = std::io::BufReader::new(file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:131:26 [INFO] [stdout] | [INFO] [stdout] 131 | env: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:154:67 [INFO] [stdout] | [INFO] [stdout] 151 | let (clt_tx, srv_rx) = tokio::sync::mpsc::channel::(64); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (srv_tx, clt_rx) = tokio::sync::mpsc::unbounded_channel::(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let client = tokio::spawn(async { client_main(clt_tx, clt_rx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:156:74 [INFO] [stdout] | [INFO] [stdout] 150 | async fn run_client_and_server(config: Config, keymap: Keymap) -> Result<()> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let (clt_tx, srv_rx) = tokio::sync::mpsc::channel::(64); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (srv_tx, clt_rx) = tokio::sync::mpsc::unbounded_channel::(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | tokio::spawn(async { server_main(config, keymap, srv_tx, srv_rx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:160:35 [INFO] [stdout] | [INFO] [stdout] 160 | .unwrap_or_else(|err| Err(anyhow::Error::from(err))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:163:35 [INFO] [stdout] | [INFO] [stdout] 163 | .unwrap_or_else(|err| Err(anyhow::Error::from(err))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> app.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | self.terminal.resize(area); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 451 | let _ = self.terminal.resize(area); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> config.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|(name, proc)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(ProcConfig::from_val(value_to_string(&name)?, proc, ctx)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> config.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | .map(|item| item.as_str().map(|s| s.to_owned())) [INFO] [stdout] | ---- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> config.rs:138:26 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|v| v.as_str().map(|s| s.to_owned())) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> event.rs:103:24 [INFO] [stdout] | [INFO] [stdout] 103 | #[derive(Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> key.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 147 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Key::parse(text.as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> package_json.rs:50:6 [INFO] [stdout] | [INFO] [stdout] 18 | let file = File::open("package.json")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let package: Package = serde_yaml::from_reader(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let mut env = IndexMap::with_capacity(1); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(procs.collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> package_json.rs:45:10 [INFO] [stdout] | [INFO] [stdout] 45 | env: Some(env.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proc.rs:174:24 [INFO] [stdout] | [INFO] [stdout] 174 | #[derive(Clone, Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> yaml_val.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn add(&self, seg: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Trace(Some(Rc::new(Box::new((seg.to_string(), self.clone()))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> yaml_val.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 44 | fn create(value: &'a Value, trace: Trace) -> anyhow::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Val(value, trace)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> yaml_val.rs:122:42 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|(i, item)| Val::create(item, self.1.add(i))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monade-mprocs` (lib) due to 17 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> lib.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | let mut reader = std::io::BufReader::new(file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:131:26 [INFO] [stdout] | [INFO] [stdout] 131 | env: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:154:67 [INFO] [stdout] | [INFO] [stdout] 151 | let (clt_tx, srv_rx) = tokio::sync::mpsc::channel::(64); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (srv_tx, clt_rx) = tokio::sync::mpsc::unbounded_channel::(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let client = tokio::spawn(async { client_main(clt_tx, clt_rx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:156:74 [INFO] [stdout] | [INFO] [stdout] 150 | async fn run_client_and_server(config: Config, keymap: Keymap) -> Result<()> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let (clt_tx, srv_rx) = tokio::sync::mpsc::channel::(64); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (srv_tx, clt_rx) = tokio::sync::mpsc::unbounded_channel::(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | tokio::spawn(async { server_main(config, keymap, srv_tx, srv_rx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:160:35 [INFO] [stdout] | [INFO] [stdout] 160 | .unwrap_or_else(|err| Err(anyhow::Error::from(err))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:163:35 [INFO] [stdout] | [INFO] [stdout] 163 | .unwrap_or_else(|err| Err(anyhow::Error::from(err))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> app.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | self.terminal.resize(area); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 451 | let _ = self.terminal.resize(area); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> config.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|(name, proc)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(ProcConfig::from_val(value_to_string(&name)?, proc, ctx)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> config.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | .map(|item| item.as_str().map(|s| s.to_owned())) [INFO] [stdout] | ---- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> config.rs:138:26 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|v| v.as_str().map(|s| s.to_owned())) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> event.rs:103:24 [INFO] [stdout] | [INFO] [stdout] 103 | #[derive(Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> key.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 147 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Key::parse(text.as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> package_json.rs:50:6 [INFO] [stdout] | [INFO] [stdout] 18 | let file = File::open("package.json")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let package: Package = serde_yaml::from_reader(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let mut env = IndexMap::with_capacity(1); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(procs.collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> package_json.rs:45:10 [INFO] [stdout] | [INFO] [stdout] 45 | env: Some(env.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proc.rs:174:24 [INFO] [stdout] | [INFO] [stdout] 174 | #[derive(Clone, Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> yaml_val.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn add(&self, seg: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Trace(Some(Rc::new(Box::new((seg.to_string(), self.clone()))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> yaml_val.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 44 | fn create(value: &'a Value, trace: Trace) -> anyhow::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Val(value, trace)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> yaml_val.rs:122:42 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|(i, item)| Val::create(item, self.1.add(i))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monade-mprocs` (lib test) due to 17 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a61d64619aa1366dea01339cd1b5d93bb75e2cfd7735404e0cb26ac5a7ea6a92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a61d64619aa1366dea01339cd1b5d93bb75e2cfd7735404e0cb26ac5a7ea6a92", kill_on_drop: false }` [INFO] [stdout] a61d64619aa1366dea01339cd1b5d93bb75e2cfd7735404e0cb26ac5a7ea6a92