[INFO] fetching crate moment 0.1.0... [INFO] checking moment-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate moment 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate moment 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate moment 0.1.0 [INFO] finished tweaking crates.io crate moment 0.1.0 [INFO] tweaked toml for crates.io crate moment 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 082f95ad725ad581b995d938b29cafdef84372229f21bcd4cfa0f76e0dc14bd2 [INFO] running `Command { std: "docker" "start" "-a" "082f95ad725ad581b995d938b29cafdef84372229f21bcd4cfa0f76e0dc14bd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "082f95ad725ad581b995d938b29cafdef84372229f21bcd4cfa0f76e0dc14bd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "082f95ad725ad581b995d938b29cafdef84372229f21bcd4cfa0f76e0dc14bd2", kill_on_drop: false }` [INFO] [stdout] 082f95ad725ad581b995d938b29cafdef84372229f21bcd4cfa0f76e0dc14bd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8fae47f5690916f4cdd589a78c7c7bd9404dd4cc911df7a1a3d7411613857d88 [INFO] running `Command { std: "docker" "start" "-a" "8fae47f5690916f4cdd589a78c7c7bd9404dd4cc911df7a1a3d7411613857d88", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking moment v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/moment.rs:199:18 [INFO] [stdout] | [INFO] [stdout] 199 | .ymd(year, 0, first_week_day as u32) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/moment.rs:199:18 [INFO] [stdout] | [INFO] [stdout] 199 | .ymd(year, 0, first_week_day as u32) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `time_zone` is never read [INFO] [stdout] --> src/moment.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Moment { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 7 | date_time: DateTime, [INFO] [stdout] 8 | time_zone: T, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Moment` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LT` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub LT: &'static str, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `lt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LTS` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub LTS: &'static str, [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `lts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `L` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub L: &'static str, [INFO] [stdout] | ^ help: convert the identifier to snake case: `l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LL` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub LL: &'static str, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `ll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LLL` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub LLL: &'static str, [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `lll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LLLL` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub LLLL: &'static str, [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `llll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/locale/relative_time_strings.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub M: &'static str, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MM` should have a snake case name [INFO] [stdout] --> src/locale/relative_time_strings.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub MM: &'static str, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `mm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn utc(self) -> Moment { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | locale: LOCALE_EN_US.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn utc(self) -> Moment { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | locale: LOCALE_EN_US.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn utc>(date: Option, format: Option) -> Result, String> { [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(Moment::::new(date.unwrap(), format)?.utc()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn end_of(self, unit: UnitOfTime) -> Moment { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let mut durations = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | durations.insert((1, UnitOfTime::Nanosecond)); [INFO] [stdout] 173 | / self.start_of(unit) [INFO] [stdout] 174 | | .add(duration(durations)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `time_zone` is never read [INFO] [stdout] --> src/moment.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Moment { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 7 | date_time: DateTime, [INFO] [stdout] 8 | time_zone: T, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Moment` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LT` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub LT: &'static str, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `lt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LTS` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub LTS: &'static str, [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `lts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `L` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub L: &'static str, [INFO] [stdout] | ^ help: convert the identifier to snake case: `l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LL` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub LL: &'static str, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `ll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LLL` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub LLL: &'static str, [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `lll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `LLLL` should have a snake case name [INFO] [stdout] --> src/locale/long_date_format_strings.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub LLLL: &'static str, [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `llll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/locale/relative_time_strings.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub M: &'static str, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MM` should have a snake case name [INFO] [stdout] --> src/locale/relative_time_strings.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub MM: &'static str, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `mm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn utc(self) -> Moment { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | locale: LOCALE_EN_US.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn utc(self) -> Moment { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | locale: LOCALE_EN_US.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn utc>(date: Option, format: Option) -> Result, String> { [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(Moment::::new(date.unwrap(), format)?.utc()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn end_of(self, unit: UnitOfTime) -> Moment { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let mut durations = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | durations.insert((1, UnitOfTime::Nanosecond)); [INFO] [stdout] 173 | / self.start_of(unit) [INFO] [stdout] 174 | | .add(duration(durations)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moment` (lib test) due to 5 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `moment` (lib) due to 5 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8fae47f5690916f4cdd589a78c7c7bd9404dd4cc911df7a1a3d7411613857d88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fae47f5690916f4cdd589a78c7c7bd9404dd4cc911df7a1a3d7411613857d88", kill_on_drop: false }` [INFO] [stdout] 8fae47f5690916f4cdd589a78c7c7bd9404dd4cc911df7a1a3d7411613857d88