[INFO] fetching crate mollysocket 1.4.1... [INFO] checking mollysocket-1.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mollysocket 1.4.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mollysocket 1.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mollysocket 1.4.1 [INFO] finished tweaking crates.io crate mollysocket 1.4.1 [INFO] tweaked toml for crates.io crate mollysocket 1.4.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate mollysocket 1.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b6f95dbacd647d85b4060419f5c01350b6697789b5ca65ddfca95d90f94734a [INFO] running `Command { std: "docker" "start" "-a" "2b6f95dbacd647d85b4060419f5c01350b6697789b5ca65ddfca95d90f94734a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b6f95dbacd647d85b4060419f5c01350b6697789b5ca65ddfca95d90f94734a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b6f95dbacd647d85b4060419f5c01350b6697789b5ca65ddfca95d90f94734a", kill_on_drop: false }` [INFO] [stdout] 2b6f95dbacd647d85b4060419f5c01350b6697789b5ca65ddfca95d90f94734a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 817ba223f4ab29d672f091cc8f4120954ff9dcb6ad3b8859c0284991bf0c8e53 [INFO] running `Command { std: "docker" "start" "-a" "817ba223f4ab29d672f091cc8f4120954ff9dcb6ad3b8859c0284991bf0c8e53", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling yansi v1.0.1 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling futures-sink v0.3.30 [INFO] [stderr] Compiling futures-core v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling futures-task v0.3.30 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Compiling futures-util v0.3.30 [INFO] [stderr] Compiling futures-channel v0.3.30 [INFO] [stderr] Compiling try-lock v0.2.5 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling deranged v0.3.11 [INFO] [stderr] Compiling want v0.3.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling tracing v0.1.40 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Compiling futures-io v0.3.30 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking inlinable_string v0.1.15 [INFO] [stderr] Checking winnow v0.6.8 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling tower-service v0.3.2 [INFO] [stderr] Compiling httpdate v1.0.3 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Compiling mio v0.8.11 [INFO] [stderr] Compiling socket2 v0.5.7 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling time v0.3.36 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling tokio v1.37.0 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling http-body v0.4.6 [INFO] [stderr] Compiling stable-pattern v0.1.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling figment v0.10.19 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Compiling state v0.6.0 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling rocket v0.5.1 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling futures v0.3.30 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking binascii v0.1.4 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking atomic v0.5.3 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking resolv-conf v0.7.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking ip_rfc v0.1.0 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling hyper v0.14.28 [INFO] [stderr] Compiling devise_core v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pear_codegen v0.2.9 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling enum-as-inner v0.6.0 [INFO] [stderr] Compiling prost-derive v0.13.1 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling devise_codegen v0.4.1 [INFO] [stderr] Compiling pear v0.2.9 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling devise v0.4.1 [INFO] [stderr] Checking prost v0.13.1 [INFO] [stderr] Compiling rocket_http v0.5.1 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Compiling rocket_codegen v0.5.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking trust-dns-proto v0.23.2 [INFO] [stderr] Checking tokio-tungstenite v0.23.1 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking ubyte v0.10.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking toml_edit v0.22.13 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking trust-dns-resolver v0.23.2 [INFO] [stderr] Checking toml v0.8.13 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking rocket_prometheus v0.10.1 [INFO] [stderr] Checking mollysocket v1.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `migrate` is never used [INFO] [stdout] --> src/db/migrations.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Migration { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 6 | fn migrate(&self) -> Result<()>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 94 | let mut figment = Figment::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | match figment.extract() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 73 | let db = rusqlite::Connection::open(config::get_db())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(MollySocketDb { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | db: Arc::new(Mutex::new(db)), [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/connections.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 23 | .map(|co| connection_loop(co).fuse()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/metrics.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 20 | let connections = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | register_int_gauge!("mollysocket_connections", "Connections to Signal server")?; [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let forbiddens = register_int_gauge!( [INFO] [stdout] | _____________----------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | | "mollysocket_forbiddens", [INFO] [stdout] 24 | | "Forbidden connections to Signal server" [INFO] [stdout] 25 | | )?; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let reconnections = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | register_int_counter!("mollysocket_reconnections", "Reconnections since the start")?; [INFO] [stdout] | ----------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let messages = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | register_int_counter!("mollysocket_messages", "Messages received from Signal")?; [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let pushs = register_int_counter!( [INFO] [stdout] | _____________-----___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | | "mollysocket_pushs", [INFO] [stdout] 32 | | "Push messages sent to UnifiedPush endpoint" [INFO] [stdout] 33 | | )?; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 36 | | connections, [INFO] [stdout] 37 | | forbiddens, [INFO] [stdout] 38 | | reconnections, [INFO] [stdout] 39 | | messages, [INFO] [stdout] 40 | | pushs, [INFO] [stdout] 41 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/metrics.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 53 | fn mount_metrics<'a, B>(self, base: B, metrics: &Metrics) -> Self [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let prometheus = PrometheusMetrics::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | self.attach(prometheus.clone()).mount(base, prometheus) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/post_allowed.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 41 | fn resolve(&self, _: reqwest::dns::Name) -> reqwest::dns::Resolving { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let addrs = Box::new(iter::once(net::SocketAddr::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Box::pin(futures_util::future::ready(Ok(addrs))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ws/websocket_connection.rs:32:76 [INFO] [stdout] | [INFO] [stdout] 32 | async fn connect(&mut self, tls_connector: TlsConnector) -> Result<()> { [INFO] [stdout] | _________________________________---------------------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | | let mut request = self.get_url().into_client_request()?; [INFO] [stdout] 34 | | [INFO] [stdout] 35 | | request [INFO] [stdout] ... | [INFO] [stdout] 91 | | Ok(()) [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ws/websocket_connection.rs:143:75 [INFO] [stdout] | [INFO] [stdout] 143 | async fn loop_keepalive(&self, timer_tx: mpsc::UnboundedSender) { [INFO] [stdout] | ____________________________________-------------------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | | let last_keepalive = self.get_last_keepalive(); [INFO] [stdout] 145 | | loop { [INFO] [stdout] 146 | | if last_keepalive.lock().unwrap().elapsed() > KEEPALIVE_TIMEOUT { [INFO] [stdout] ... | [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `migrate` is never used [INFO] [stdout] --> src/db/migrations.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Migration { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 6 | fn migrate(&self) -> Result<()>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 94 | let mut figment = Figment::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | match figment.extract() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 73 | let db = rusqlite::Connection::open(config::get_db())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(MollySocketDb { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | db: Arc::new(Mutex::new(db)), [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/connections.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 23 | .map(|co| connection_loop(co).fuse()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/metrics.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 20 | let connections = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | register_int_gauge!("mollysocket_connections", "Connections to Signal server")?; [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let forbiddens = register_int_gauge!( [INFO] [stdout] | _____________----------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | | "mollysocket_forbiddens", [INFO] [stdout] 24 | | "Forbidden connections to Signal server" [INFO] [stdout] 25 | | )?; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let reconnections = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | register_int_counter!("mollysocket_reconnections", "Reconnections since the start")?; [INFO] [stdout] | ----------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let messages = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | register_int_counter!("mollysocket_messages", "Messages received from Signal")?; [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let pushs = register_int_counter!( [INFO] [stdout] | _____________-----___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | | "mollysocket_pushs", [INFO] [stdout] 32 | | "Push messages sent to UnifiedPush endpoint" [INFO] [stdout] 33 | | )?; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 36 | | connections, [INFO] [stdout] 37 | | forbiddens, [INFO] [stdout] 38 | | reconnections, [INFO] [stdout] 39 | | messages, [INFO] [stdout] 40 | | pushs, [INFO] [stdout] 41 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/metrics.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 53 | fn mount_metrics<'a, B>(self, base: B, metrics: &Metrics) -> Self [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let prometheus = PrometheusMetrics::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | self.attach(prometheus.clone()).mount(base, prometheus) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/post_allowed.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 41 | fn resolve(&self, _: reqwest::dns::Name) -> reqwest::dns::Resolving { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let addrs = Box::new(iter::once(net::SocketAddr::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Box::pin(futures_util::future::ready(Ok(addrs))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mollysocket` (bin "mollysocket" test) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ws/websocket_connection.rs:32:76 [INFO] [stdout] | [INFO] [stdout] 32 | async fn connect(&mut self, tls_connector: TlsConnector) -> Result<()> { [INFO] [stdout] | _________________________________---------------------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | | let mut request = self.get_url().into_client_request()?; [INFO] [stdout] 34 | | [INFO] [stdout] 35 | | request [INFO] [stdout] ... | [INFO] [stdout] 91 | | Ok(()) [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ws/websocket_connection.rs:143:75 [INFO] [stdout] | [INFO] [stdout] 143 | async fn loop_keepalive(&self, timer_tx: mpsc::UnboundedSender) { [INFO] [stdout] | ____________________________________-------------------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | | let last_keepalive = self.get_last_keepalive(); [INFO] [stdout] 145 | | loop { [INFO] [stdout] 146 | | if last_keepalive.lock().unwrap().elapsed() > KEEPALIVE_TIMEOUT { [INFO] [stdout] ... | [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mollysocket` (bin "mollysocket") due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "817ba223f4ab29d672f091cc8f4120954ff9dcb6ad3b8859c0284991bf0c8e53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "817ba223f4ab29d672f091cc8f4120954ff9dcb6ad3b8859c0284991bf0c8e53", kill_on_drop: false }` [INFO] [stdout] 817ba223f4ab29d672f091cc8f4120954ff9dcb6ad3b8859c0284991bf0c8e53