[INFO] fetching crate mogwai-js-framework-benchmark 0.1.0... [INFO] checking mogwai-js-framework-benchmark-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mogwai-js-framework-benchmark 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate mogwai-js-framework-benchmark 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mogwai-js-framework-benchmark 0.1.0 [INFO] finished tweaking crates.io crate mogwai-js-framework-benchmark 0.1.0 [INFO] tweaked toml for crates.io crate mogwai-js-framework-benchmark 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding async-broadcast v0.4.1 (latest: v0.7.1) [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding console_log v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding syn-rsx v0.7.3 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 443c190ba1a0289eae0c5747abad507492d1aad3edc1cf568716c0bdd19cb621 [INFO] running `Command { std: "docker" "start" "-a" "443c190ba1a0289eae0c5747abad507492d1aad3edc1cf568716c0bdd19cb621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "443c190ba1a0289eae0c5747abad507492d1aad3edc1cf568716c0bdd19cb621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "443c190ba1a0289eae0c5747abad507492d1aad3edc1cf568716c0bdd19cb621", kill_on_drop: false }` [INFO] [stdout] 443c190ba1a0289eae0c5747abad507492d1aad3edc1cf568716c0bdd19cb621 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e777690a693cdf4b9228c546e314f6ce53a146e936324bdd4d0f44cef15da9cf [INFO] running `Command { std: "docker" "start" "-a" "e777690a693cdf4b9228c546e314f6ce53a146e936324bdd4d0f44cef15da9cf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling wasm-bindgen v0.2.93 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking send_wrapper v0.6.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking async-broadcast v0.4.1 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling syn-rsx v0.7.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Compiling mogwai-macros v0.1.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.43 [INFO] [stderr] Checking console_log v0.1.2 [INFO] [stderr] Checking mogwai v0.6.8 [INFO] [stderr] Checking mogwai-dom v0.2.6 [INFO] [stderr] Checking mogwai-js-framework-benchmark v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 126 | fn viewbuilder(mut self) -> ViewBuilder { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | / self.dom [INFO] [stdout] 128 | | .current() [INFO] [stdout] 129 | | .map(ViewBuilder::from) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 178 | let rows: ListPatchModel = ListPatchModel::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | cache: Arc::new(Mutex::new(Vec::with_capacity(11_000))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:23 [INFO] [stdout] | [INFO] [stdout] 178 | let rows: ListPatchModel = ListPatchModel::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | selected: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn dequeue(&self, rows: impl IntoIterator) -> Vec { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let mut cache = self.cache.lock().unwrap_throw(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | / rows.into_iter() [INFO] [stdout] 212 | | .map(|(id, label)| { [INFO] [stdout] 213 | | if let Some(row) = cache.pop() { [INFO] [stdout] 214 | | row.model_id [INFO] [stdout] ... | [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:371:27 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn viewbuilder(mut self) -> ViewBuilder { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | let main_click = Output::::default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | let builder = rsx! ( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | builder.with_task(async move { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 372 | | // To save creating thousands of event listeners (one on each row) we instead use one [INFO] [stdout] 373 | | // click event on the main div, and then figure out which row was clicked using JS APIs. [INFO] [stdout] 374 | | // This is the power of mogwai being so close to the metal. [INFO] [stdout] ... | [INFO] [stdout] 427 | | } [INFO] [stdout] 428 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 126 | fn viewbuilder(mut self) -> ViewBuilder { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | / self.dom [INFO] [stdout] 128 | | .current() [INFO] [stdout] 129 | | .map(ViewBuilder::from) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 178 | let rows: ListPatchModel = ListPatchModel::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | cache: Arc::new(Mutex::new(Vec::with_capacity(11_000))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:23 [INFO] [stdout] | [INFO] [stdout] 178 | let rows: ListPatchModel = ListPatchModel::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | selected: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn dequeue(&self, rows: impl IntoIterator) -> Vec { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let mut cache = self.cache.lock().unwrap_throw(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | / rows.into_iter() [INFO] [stdout] 212 | | .map(|(id, label)| { [INFO] [stdout] 213 | | if let Some(row) = cache.pop() { [INFO] [stdout] 214 | | row.model_id [INFO] [stdout] ... | [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:371:27 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn viewbuilder(mut self) -> ViewBuilder { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | let main_click = Output::::default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | let builder = rsx! ( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | builder.with_task(async move { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 372 | | // To save creating thousands of event listeners (one on each row) we instead use one [INFO] [stdout] 373 | | // click event on the main div, and then figure out which row was clicked using JS APIs. [INFO] [stdout] 374 | | // This is the power of mogwai being so close to the metal. [INFO] [stdout] ... | [INFO] [stdout] 427 | | } [INFO] [stdout] 428 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mogwai-js-framework-benchmark` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `mogwai-js-framework-benchmark` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "e777690a693cdf4b9228c546e314f6ce53a146e936324bdd4d0f44cef15da9cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e777690a693cdf4b9228c546e314f6ce53a146e936324bdd4d0f44cef15da9cf", kill_on_drop: false }` [INFO] [stdout] e777690a693cdf4b9228c546e314f6ce53a146e936324bdd4d0f44cef15da9cf