[INFO] fetching crate mogrify_derive 0.2.0... [INFO] checking mogrify_derive-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mogrify_derive 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate mogrify_derive 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mogrify_derive 0.2.0 [INFO] finished tweaking crates.io crate mogrify_derive 0.2.0 [INFO] tweaked toml for crates.io crate mogrify_derive 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d9efc1a7906c2d21edb9ea1d2f33cadda128b081252cb33c8e657f08af452b76 [INFO] running `Command { std: "docker" "start" "-a" "d9efc1a7906c2d21edb9ea1d2f33cadda128b081252cb33c8e657f08af452b76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d9efc1a7906c2d21edb9ea1d2f33cadda128b081252cb33c8e657f08af452b76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9efc1a7906c2d21edb9ea1d2f33cadda128b081252cb33c8e657f08af452b76", kill_on_drop: false }` [INFO] [stdout] d9efc1a7906c2d21edb9ea1d2f33cadda128b081252cb33c8e657f08af452b76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf6830ab8d6a4aff1b60c98792f30eedb2ad158363fc68053f46d20253de0c52 [INFO] running `Command { std: "docker" "start" "-a" "cf6830ab8d6a4aff1b60c98792f30eedb2ad158363fc68053f46d20253de0c52", kill_on_drop: false }` [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking mogrify_derive v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attrs.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn extract_mogrify_meta(attrs: Vec) -> Vec { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | / attrs [INFO] [stdout] 28 | | .into_iter() [INFO] [stdout] 29 | | .filter(|attr| attr.path().is_ident("mogrify")) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attrs.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn extract_mogrify_meta(attrs: Vec) -> Vec { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | / attrs [INFO] [stdout] 28 | | .into_iter() [INFO] [stdout] 29 | | .filter(|attr| attr.path().is_ident("mogrify")) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attrs.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 112 | fn try_from(value: Attribute) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let source: TypePath = value.parse_args()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Ok(MogrifyStructAttrs { source }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attrs.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 112 | fn try_from(value: Attribute) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let source: TypePath = value.parse_args()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Ok(MogrifyStructAttrs { source }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields.rs:144:11 [INFO] [stdout] | [INFO] [stdout] 143 | fn extract_single_generic(path: TypePath) -> GenericArgument { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | match path [INFO] [stdout] | ___________^ [INFO] [stdout] 145 | | .path [INFO] [stdout] 146 | | .segments [INFO] [stdout] 147 | | .into_iter() [INFO] [stdout] 148 | | .last() [INFO] [stdout] 149 | | .expect("expectation failed") [INFO] [stdout] 150 | | .arguments [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields.rs:159:11 [INFO] [stdout] | [INFO] [stdout] 158 | fn extract_double_generic(path: TypePath) -> (GenericArgument, GenericArgument) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | match path [INFO] [stdout] | ___________^ [INFO] [stdout] 160 | | .path [INFO] [stdout] 161 | | .segments [INFO] [stdout] 162 | | .into_iter() [INFO] [stdout] 163 | | .last() [INFO] [stdout] 164 | | .expect("expectation failed") [INFO] [stdout] 165 | | .arguments [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 181 | fn try_from((idx, value): (usize, Field)) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let attrs: MogrifyFieldAttrs = extract_mogrify_meta(value.attrs).try_into()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let specialization = match value.ty { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Type::Path(path) if type_shape_check(&path, "Option", 1) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let ty = extract_single_generic(path); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Type::Path(path) if type_shape_check(&path, "Vec", 1) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let ty = extract_single_generic(path); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | Type::Path(path) if type_shape_check(&path, "HashMap", 2) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let (key_ty, value_ty) = extract_double_generic(path); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let local_ident = Ident::new(&format!("local{idx}"), Span::mixed_site()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Ok(MogrifyFieldInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 200 | | idx, [INFO] [stdout] 201 | | local_ident, [INFO] [stdout] 202 | | source_ident: value.ident, [INFO] [stdout] 203 | | attrs, [INFO] [stdout] 204 | | specialization, [INFO] [stdout] 205 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields.rs:144:11 [INFO] [stdout] | [INFO] [stdout] 143 | fn extract_single_generic(path: TypePath) -> GenericArgument { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | match path [INFO] [stdout] | ___________^ [INFO] [stdout] 145 | | .path [INFO] [stdout] 146 | | .segments [INFO] [stdout] 147 | | .into_iter() [INFO] [stdout] 148 | | .last() [INFO] [stdout] 149 | | .expect("expectation failed") [INFO] [stdout] 150 | | .arguments [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields.rs:159:11 [INFO] [stdout] | [INFO] [stdout] 158 | fn extract_double_generic(path: TypePath) -> (GenericArgument, GenericArgument) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | match path [INFO] [stdout] | ___________^ [INFO] [stdout] 160 | | .path [INFO] [stdout] 161 | | .segments [INFO] [stdout] 162 | | .into_iter() [INFO] [stdout] 163 | | .last() [INFO] [stdout] 164 | | .expect("expectation failed") [INFO] [stdout] 165 | | .arguments [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 181 | fn try_from((idx, value): (usize, Field)) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let attrs: MogrifyFieldAttrs = extract_mogrify_meta(value.attrs).try_into()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let specialization = match value.ty { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Type::Path(path) if type_shape_check(&path, "Option", 1) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let ty = extract_single_generic(path); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Type::Path(path) if type_shape_check(&path, "Vec", 1) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let ty = extract_single_generic(path); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | Type::Path(path) if type_shape_check(&path, "HashMap", 2) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let (key_ty, value_ty) = extract_double_generic(path); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let local_ident = Ident::new(&format!("local{idx}"), Span::mixed_site()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Ok(MogrifyFieldInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 200 | | idx, [INFO] [stdout] 201 | | local_ident, [INFO] [stdout] 202 | | source_ident: value.ident, [INFO] [stdout] 203 | | attrs, [INFO] [stdout] 204 | | specialization, [INFO] [stdout] 205 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mogrify_derive` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mogrify_derive` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "cf6830ab8d6a4aff1b60c98792f30eedb2ad158363fc68053f46d20253de0c52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf6830ab8d6a4aff1b60c98792f30eedb2ad158363fc68053f46d20253de0c52", kill_on_drop: false }` [INFO] [stdout] cf6830ab8d6a4aff1b60c98792f30eedb2ad158363fc68053f46d20253de0c52