[INFO] fetching crate modyne 0.3.0... [INFO] checking modyne-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate modyne 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate modyne 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate modyne 0.3.0 [INFO] finished tweaking crates.io crate modyne 0.3.0 [INFO] tweaked toml for crates.io crate modyne 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 152 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd6061e05f91fb5cf81c3c56d7d6b4ad54ec8bc98af00b8b00854bc6d9b65466 [INFO] running `Command { std: "docker" "start" "-a" "cd6061e05f91fb5cf81c3c56d7d6b4ad54ec8bc98af00b8b00854bc6d9b65466", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd6061e05f91fb5cf81c3c56d7d6b4ad54ec8bc98af00b8b00854bc6d9b65466", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd6061e05f91fb5cf81c3c56d7d6b4ad54ec8bc98af00b8b00854bc6d9b65466", kill_on_drop: false }` [INFO] [stdout] cd6061e05f91fb5cf81c3c56d7d6b4ad54ec8bc98af00b8b00854bc6d9b65466 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5adcc4f6d76c70eea31027346398b187f235ae5934f05df66c74d6965b5a48f [INFO] running `Command { std: "docker" "start" "-a" "c5adcc4f6d76c70eea31027346398b187f235ae5934f05df66c74d6965b5a48f", kill_on_drop: false }` [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling aws-types v1.3.3 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling aliri_braid_impl v0.4.0 [INFO] [stderr] Checking aws-smithy-xml v0.60.8 [INFO] [stderr] Checking aliri_braid v0.4.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking aws-smithy-types v1.2.4 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.2 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking aws-smithy-http v0.60.10 [INFO] [stderr] Checking aws-credential-types v1.2.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking aws-sigv4 v1.2.3 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.7.1 [INFO] [stderr] Checking aws-runtime v1.4.2 [INFO] [stderr] Checking aws-sdk-sso v1.40.0 [INFO] [stderr] Checking aws-sdk-sts v1.40.0 [INFO] [stderr] Checking aws-sdk-dynamodb v1.43.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.41.0 [INFO] [stderr] Checking aws-config v1.5.5 [INFO] [stderr] Checking serde_dynamo v4.2.14 [INFO] [stderr] Checking modyne v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:18 [INFO] [stdout] | [INFO] [stdout] 345 | fn get(input: Self::KeyInput<'_>) -> Get { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | Get::new(Self::primary_key(input).into_key()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:398:21 [INFO] [stdout] | [INFO] [stdout] 397 | fn update(key: Self::KeyInput<'_>) -> Update { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | Update::new(Self::primary_key(key).into_key()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:404:21 [INFO] [stdout] | [INFO] [stdout] 403 | fn delete(key: Self::KeyInput<'_>) -> Delete { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 404 | Delete::new(Self::primary_key(key).into_key()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:410:29 [INFO] [stdout] | [INFO] [stdout] 409 | fn condition_check(key: Self::KeyInput<'_>, condition: expr::Condition) -> ConditionCheck { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | ConditionCheck::new(Self::primary_key(key).into_key(), condition) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1068:9 [INFO] [stdout] | [INFO] [stdout] 994 | let mut builder = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1068 | / builder [INFO] [stdout] 1069 | | .set_key_schema(Some(key_schema)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 124 | fn from(e: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Self(Box::new(e.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 73 | fn into_key(self) -> Item { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | crate::codec::to_item(self.to_serialize()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys.rs:171:34 [INFO] [stdout] | [INFO] [stdout] 166 | fn serialize_keys(keys: &K, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | serde::Serialize::serialize(&keys.to_serialize(), serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `modyne` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:18 [INFO] [stdout] | [INFO] [stdout] 345 | fn get(input: Self::KeyInput<'_>) -> Get { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | Get::new(Self::primary_key(input).into_key()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:398:21 [INFO] [stdout] | [INFO] [stdout] 397 | fn update(key: Self::KeyInput<'_>) -> Update { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | Update::new(Self::primary_key(key).into_key()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:404:21 [INFO] [stdout] | [INFO] [stdout] 403 | fn delete(key: Self::KeyInput<'_>) -> Delete { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 404 | Delete::new(Self::primary_key(key).into_key()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:410:29 [INFO] [stdout] | [INFO] [stdout] 409 | fn condition_check(key: Self::KeyInput<'_>, condition: expr::Condition) -> ConditionCheck { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | ConditionCheck::new(Self::primary_key(key).into_key(), condition) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1068:9 [INFO] [stdout] | [INFO] [stdout] 994 | let mut builder = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1068 | / builder [INFO] [stdout] 1069 | | .set_key_schema(Some(key_schema)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 124 | fn from(e: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Self(Box::new(e.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 73 | fn into_key(self) -> Item { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | crate::codec::to_item(self.to_serialize()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys.rs:171:34 [INFO] [stdout] | [INFO] [stdout] 166 | fn serialize_keys(keys: &K, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | serde::Serialize::serialize(&keys.to_serialize(), serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `modyne` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "c5adcc4f6d76c70eea31027346398b187f235ae5934f05df66c74d6965b5a48f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5adcc4f6d76c70eea31027346398b187f235ae5934f05df66c74d6965b5a48f", kill_on_drop: false }` [INFO] [stdout] c5adcc4f6d76c70eea31027346398b187f235ae5934f05df66c74d6965b5a48f