[INFO] fetching crate modbus-proxy-rs 1.0.0... [INFO] checking modbus-proxy-rs-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate modbus-proxy-rs 1.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate modbus-proxy-rs 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate modbus-proxy-rs 1.0.0 [INFO] finished tweaking crates.io crate modbus-proxy-rs 1.0.0 [INFO] tweaked toml for crates.io crate modbus-proxy-rs 1.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate modbus-proxy-rs 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5adbb27730b746ae4f055bdde5d6a21839bd2fee064e0e2938ee91caddfe52c0 [INFO] running `Command { std: "docker" "start" "-a" "5adbb27730b746ae4f055bdde5d6a21839bd2fee064e0e2938ee91caddfe52c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5adbb27730b746ae4f055bdde5d6a21839bd2fee064e0e2938ee91caddfe52c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5adbb27730b746ae4f055bdde5d6a21839bd2fee064e0e2938ee91caddfe52c0", kill_on_drop: false }` [INFO] [stdout] 5adbb27730b746ae4f055bdde5d6a21839bd2fee064e0e2938ee91caddfe52c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4a60a6c1058bac613e73301b2f79b56c8af145ea936a291612fff0441233f6b [INFO] running `Command { std: "docker" "start" "-a" "f4a60a6c1058bac613e73301b2f79b56c8af145ea936a291612fff0441233f6b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling syn v1.0.83 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Checking futures-io v0.3.19 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Checking lexical-core v0.7.6 [INFO] [stderr] Checking serde v0.8.23 [INFO] [stderr] Checking rust-ini v0.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking serde-hjson v0.9.1 [INFO] [stderr] Compiling futures-macro v0.3.19 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking futures-executor v0.3.19 [INFO] [stderr] Checking futures v0.3.19 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking config v0.11.0 [INFO] [stderr] Checking modbus-proxy-rs v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:6 [INFO] [stdout] | [INFO] [stdout] 38 | fn split_connection(stream: TcpStream) -> (TcpReader, TcpWriter) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let (reader, writer) = stream.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | (BufReader::new(reader), BufWriter::new(writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 38 | fn split_connection(stream: TcpStream) -> (TcpReader, TcpWriter) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let (reader, writer) = stream.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | (BufReader::new(reader), BufWriter::new(writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:34 [INFO] [stdout] | [INFO] [stdout] 138 | .or_else(|error| Err(format!("error sending reply to client: {:?}", error).into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `modbus-proxy-rs` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:6 [INFO] [stdout] | [INFO] [stdout] 38 | fn split_connection(stream: TcpStream) -> (TcpReader, TcpWriter) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let (reader, writer) = stream.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | (BufReader::new(reader), BufWriter::new(writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 38 | fn split_connection(stream: TcpStream) -> (TcpReader, TcpWriter) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let (reader, writer) = stream.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | (BufReader::new(reader), BufWriter::new(writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:34 [INFO] [stdout] | [INFO] [stdout] 138 | .or_else(|error| Err(format!("error sending reply to client: {:?}", error).into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `modbus-proxy-rs` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "f4a60a6c1058bac613e73301b2f79b56c8af145ea936a291612fff0441233f6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4a60a6c1058bac613e73301b2f79b56c8af145ea936a291612fff0441233f6b", kill_on_drop: false }` [INFO] [stdout] f4a60a6c1058bac613e73301b2f79b56c8af145ea936a291612fff0441233f6b