[INFO] fetching crate mod3d-gl 0.1.0... [INFO] checking mod3d-gl-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mod3d-gl 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate mod3d-gl 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mod3d-gl 0.1.0 [INFO] finished tweaking crates.io crate mod3d-gl 0.1.0 [INFO] tweaked toml for crates.io crate mod3d-gl 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be6588b7d6533793d92806a6242499b0d6e4c616c2f72fd7fc55094ddae6d9db [INFO] running `Command { std: "docker" "start" "-a" "be6588b7d6533793d92806a6242499b0d6e4c616c2f72fd7fc55094ddae6d9db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be6588b7d6533793d92806a6242499b0d6e4c616c2f72fd7fc55094ddae6d9db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be6588b7d6533793d92806a6242499b0d6e4c616c2f72fd7fc55094ddae6d9db", kill_on_drop: false }` [INFO] [stdout] be6588b7d6533793d92806a6242499b0d6e4c616c2f72fd7fc55094ddae6d9db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ab117667b5d1db12581d39740ddb8da61f0505982d02af1e872541db8f1916ec [INFO] running `Command { std: "docker" "start" "-a" "ab117667b5d1db12581d39740ddb8da61f0505982d02af1e872541db8f1916ec", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling xml-rs v0.8.21 [INFO] [stderr] Compiling wasm-bindgen v0.2.93 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking indent-display v0.1.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking geo-nd v0.5.2 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Checking mod3d-base v0.1.0 [INFO] [stderr] Checking mod3d-gl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shader_instantiable.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 127 | let mut vaos = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 132 | | instantiable, [INFO] [stdout] 133 | | vaos, [INFO] [stdout] 134 | | program, [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/webgl.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 230 | let mut gl = buffer::Buffer::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | gl.uniform_buffer(self, data, is_dynamic)?; [INFO] [stdout] 232 | Ok(UniformBuffer::new(gl, byte_length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/webgl/program.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 45 | let program = context [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let uniforms = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let uniform_buffers = Vec::new(); [INFO] [stdout] 67 | let textures = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(Program { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | program, [INFO] [stdout] 70 | | attributes, [INFO] [stdout] 71 | | textures, [INFO] [stdout] 72 | | uniforms, [INFO] [stdout] 73 | | uniform_buffers, [INFO] [stdout] 74 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/webgl/texture.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 74 | let gl = render_context.create_texture().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | gl: Rc::new(Some(gl)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/webgl/texture.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / render_context.tex_image_2d_with_i32_and_i32_and_i32_and_format_and_type_and_opt_u8_array( [INFO] [stdout] 77 | | WebGl2RenderingContext::TEXTURE_2D, [INFO] [stdout] 78 | | 0, [INFO] [stdout] 79 | | WebGl2RenderingContext::RGB as i32, [INFO] [stdout] ... | [INFO] [stdout] 85 | | Some(texture.data()), [INFO] [stdout] 86 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 76 | let _ = render_context.tex_image_2d_with_i32_and_i32_and_i32_and_format_and_type_and_opt_u8_array( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/opengl.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 234 | let mut gl = buffer::Buffer::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | gl.uniform_buffer(data, is_dynamic)?; [INFO] [stdout] 236 | Ok(UniformBuffer::new(gl, byte_length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mod3d-gl` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shader_instantiable.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 127 | let mut vaos = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 132 | | instantiable, [INFO] [stdout] 133 | | vaos, [INFO] [stdout] 134 | | program, [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/webgl.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 230 | let mut gl = buffer::Buffer::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | gl.uniform_buffer(self, data, is_dynamic)?; [INFO] [stdout] 232 | Ok(UniformBuffer::new(gl, byte_length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/webgl/program.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 45 | let program = context [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let uniforms = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let uniform_buffers = Vec::new(); [INFO] [stdout] 67 | let textures = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(Program { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | program, [INFO] [stdout] 70 | | attributes, [INFO] [stdout] 71 | | textures, [INFO] [stdout] 72 | | uniforms, [INFO] [stdout] 73 | | uniform_buffers, [INFO] [stdout] 74 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/webgl/texture.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 74 | let gl = render_context.create_texture().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | gl: Rc::new(Some(gl)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/webgl/texture.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / render_context.tex_image_2d_with_i32_and_i32_and_i32_and_format_and_type_and_opt_u8_array( [INFO] [stdout] 77 | | WebGl2RenderingContext::TEXTURE_2D, [INFO] [stdout] 78 | | 0, [INFO] [stdout] 79 | | WebGl2RenderingContext::RGB as i32, [INFO] [stdout] ... | [INFO] [stdout] 85 | | Some(texture.data()), [INFO] [stdout] 86 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 76 | let _ = render_context.tex_image_2d_with_i32_and_i32_and_i32_and_format_and_type_and_opt_u8_array( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/opengl.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 234 | let mut gl = buffer::Buffer::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | gl.uniform_buffer(data, is_dynamic)?; [INFO] [stdout] 236 | Ok(UniformBuffer::new(gl, byte_length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mod3d-gl` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ab117667b5d1db12581d39740ddb8da61f0505982d02af1e872541db8f1916ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab117667b5d1db12581d39740ddb8da61f0505982d02af1e872541db8f1916ec", kill_on_drop: false }` [INFO] [stdout] ab117667b5d1db12581d39740ddb8da61f0505982d02af1e872541db8f1916ec