[INFO] fetching crate mlinrust 0.1.0...
[INFO] checking mlinrust-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604
[INFO] extracting crate mlinrust 0.1.0 into /workspace/builds/worker-4-tc2/source
[INFO] validating manifest of crates.io crate mlinrust 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking crates.io crate mlinrust 0.1.0
[INFO] finished tweaking crates.io crate mlinrust 0.1.0
[INFO] tweaked toml for crates.io crate mlinrust 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml
[INFO] crate crates.io crate mlinrust 0.1.0 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] b4acb046fb430e019d7c027dc7e99c662410b4c09e83253ed20f29771d19af1f
[INFO] running `Command { std: "docker" "start" "-a" "b4acb046fb430e019d7c027dc7e99c662410b4c09e83253ed20f29771d19af1f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "b4acb046fb430e019d7c027dc7e99c662410b4c09e83253ed20f29771d19af1f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b4acb046fb430e019d7c027dc7e99c662410b4c09e83253ed20f29771d19af1f", kill_on_drop: false }`
[INFO] [stdout] b4acb046fb430e019d7c027dc7e99c662410b4c09e83253ed20f29771d19af1f
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 5ad7100a7b46d3a7ab4048ba0e3e1e4c8ffc679022aec4a55f0c0b52aaa9a7a6
[INFO] running `Command { std: "docker" "start" "-a" "5ad7100a7b46d3a7ab4048ba0e3e1e4c8ffc679022aec4a55f0c0b52aaa9a7a6", kill_on_drop: false }`
[INFO] [stderr]     Checking mlinrust v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout]   --> src/dataset/utils.rs:33:17
[INFO] [stdout]    |
[INFO] [stdout] 32 |               res.into_iter().map(|item| {
[INFO] [stdout]    |                                    ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 33 | /                 item.into_iter().enumerate().map(|(i, e)| {
[INFO] [stdout] 34 | |                     if let Ok(v) = e {
[INFO] [stdout] 35 | |                         v
[INFO] [stdout] 36 | |                     } else {
[INFO] [stdout] 37 | |                         counter[i]
[INFO] [stdout] 38 | |                     }
[INFO] [stdout] 39 | |                 }).collect::<Vec<f32>>()
[INFO] [stdout]    | |__________________^
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
[INFO] [stdout]    = note: requested on the command line with `-D tail-expr-drop-order`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout]   --> src/dataset/utils.rs:44:17
[INFO] [stdout]    |
[INFO] [stdout] 43 |               res.into_iter().map(|item| {
[INFO] [stdout]    |                                    ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 44 | /                 item.into_iter().map(|e| {
[INFO] [stdout] 45 | |                     if let Ok(v) = e {
[INFO] [stdout] 46 | |                         v
[INFO] [stdout] 47 | |                     } else {
[INFO] [stdout] 48 | |                         0.0
[INFO] [stdout] 49 | |                     }
[INFO] [stdout] 50 | |                 }).collect::<Vec<f32>>()
[INFO] [stdout]    | |__________________^
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout]   --> src/dataset/utils.rs:55:17
[INFO] [stdout]    |
[INFO] [stdout] 54 |               res.into_iter().map(|item| {
[INFO] [stdout]    |                                    ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 55 | /                 item.into_iter().map(|e| {
[INFO] [stdout] 56 | |                     if let Ok(v) = e {
[INFO] [stdout] 57 | |                         v
[INFO] [stdout] 58 | |                     } else {
[INFO] [stdout] 59 | |                         value
[INFO] [stdout] 60 | |                     }
[INFO] [stdout] 61 | |                 }).collect::<Vec<f32>>()
[INFO] [stdout]    | |__________________^
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/model/decision_tree.rs:97:51
[INFO] [stdout]    |
[INFO] [stdout] 97 |         let mut node = self.root.as_ref().unwrap().clone();
[INFO] [stdout]    |                                                   ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `Box<Node<T>>` does not implement `Clone`, so calling `clone` on `&Box<Node<T>>` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout] 97 -         let mut node = self.root.as_ref().unwrap().clone();
[INFO] [stdout] 97 +         let mut node = self.root.as_ref().unwrap();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/model/decision_tree.rs:101:52
[INFO] [stdout]     |
[INFO] [stdout] 101 |                 node = &node.left.as_ref().unwrap().clone();
[INFO] [stdout]     |                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Box<Node<T>>` does not implement `Clone`, so calling `clone` on `&Box<Node<T>>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 101 -                 node = &node.left.as_ref().unwrap().clone();
[INFO] [stdout] 101 +                 node = &node.left.as_ref().unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/model/decision_tree.rs:103:53
[INFO] [stdout]     |
[INFO] [stdout] 103 |                 node = &node.right.as_ref().unwrap().clone();
[INFO] [stdout]     |                                                     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Box<Node<T>>` does not implement `Clone`, so calling `clone` on `&Box<Node<T>>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 103 -                 node = &node.right.as_ref().unwrap().clone();
[INFO] [stdout] 103 +                 node = &node.right.as_ref().unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `mlinrust` (lib) due to 4 previous errors; 3 warnings emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout]   --> src/dataset/utils.rs:33:17
[INFO] [stdout]    |
[INFO] [stdout] 32 |               res.into_iter().map(|item| {
[INFO] [stdout]    |                                    ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 33 | /                 item.into_iter().enumerate().map(|(i, e)| {
[INFO] [stdout] 34 | |                     if let Ok(v) = e {
[INFO] [stdout] 35 | |                         v
[INFO] [stdout] 36 | |                     } else {
[INFO] [stdout] 37 | |                         counter[i]
[INFO] [stdout] 38 | |                     }
[INFO] [stdout] 39 | |                 }).collect::<Vec<f32>>()
[INFO] [stdout]    | |__________________^
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
[INFO] [stdout]    = note: requested on the command line with `-D tail-expr-drop-order`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout]   --> src/dataset/utils.rs:44:17
[INFO] [stdout]    |
[INFO] [stdout] 43 |               res.into_iter().map(|item| {
[INFO] [stdout]    |                                    ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 44 | /                 item.into_iter().map(|e| {
[INFO] [stdout] 45 | |                     if let Ok(v) = e {
[INFO] [stdout] 46 | |                         v
[INFO] [stdout] 47 | |                     } else {
[INFO] [stdout] 48 | |                         0.0
[INFO] [stdout] 49 | |                     }
[INFO] [stdout] 50 | |                 }).collect::<Vec<f32>>()
[INFO] [stdout]    | |__________________^
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout]   --> src/dataset/utils.rs:55:17
[INFO] [stdout]    |
[INFO] [stdout] 54 |               res.into_iter().map(|item| {
[INFO] [stdout]    |                                    ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 55 | /                 item.into_iter().map(|e| {
[INFO] [stdout] 56 | |                     if let Ok(v) = e {
[INFO] [stdout] 57 | |                         v
[INFO] [stdout] 58 | |                     } else {
[INFO] [stdout] 59 | |                         value
[INFO] [stdout] 60 | |                     }
[INFO] [stdout] 61 | |                 }).collect::<Vec<f32>>()
[INFO] [stdout]    | |__________________^
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/model/decision_tree.rs:97:51
[INFO] [stdout]    |
[INFO] [stdout] 97 |         let mut node = self.root.as_ref().unwrap().clone();
[INFO] [stdout]    |                                                   ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `Box<Node<T>>` does not implement `Clone`, so calling `clone` on `&Box<Node<T>>` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout] 97 -         let mut node = self.root.as_ref().unwrap().clone();
[INFO] [stdout] 97 +         let mut node = self.root.as_ref().unwrap();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/model/decision_tree.rs:101:52
[INFO] [stdout]     |
[INFO] [stdout] 101 |                 node = &node.left.as_ref().unwrap().clone();
[INFO] [stdout]     |                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Box<Node<T>>` does not implement `Clone`, so calling `clone` on `&Box<Node<T>>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 101 -                 node = &node.left.as_ref().unwrap().clone();
[INFO] [stdout] 101 +                 node = &node.left.as_ref().unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/model/decision_tree.rs:103:53
[INFO] [stdout]     |
[INFO] [stdout] 103 |                 node = &node.right.as_ref().unwrap().clone();
[INFO] [stdout]     |                                                     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Box<Node<T>>` does not implement `Clone`, so calling `clone` on `&Box<Node<T>>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 103 -                 node = &node.right.as_ref().unwrap().clone();
[INFO] [stdout] 103 +                 node = &node.right.as_ref().unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `mlinrust` (lib test) due to 4 previous errors; 3 warnings emitted
[INFO] running `Command { std: "docker" "inspect" "5ad7100a7b46d3a7ab4048ba0e3e1e4c8ffc679022aec4a55f0c0b52aaa9a7a6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5ad7100a7b46d3a7ab4048ba0e3e1e4c8ffc679022aec4a55f0c0b52aaa9a7a6", kill_on_drop: false }`
[INFO] [stdout] 5ad7100a7b46d3a7ab4048ba0e3e1e4c8ffc679022aec4a55f0c0b52aaa9a7a6