[INFO] fetching crate mit-commit-message-lints 5.13.28... [INFO] checking mit-commit-message-lints-5.13.28 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mit-commit-message-lints 5.13.28 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate mit-commit-message-lints 5.13.28 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mit-commit-message-lints 5.13.28 [INFO] finished tweaking crates.io crate mit-commit-message-lints 5.13.28 [INFO] tweaked toml for crates.io crate mit-commit-message-lints 5.13.28 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 204 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding crossterm v0.27.0 (latest: v0.28.1) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95fdd60f90ca03d87a616c10abf5e425814246d171ac1041f42dcfbc87541136 [INFO] running `Command { std: "docker" "start" "-a" "95fdd60f90ca03d87a616c10abf5e425814246d171ac1041f42dcfbc87541136", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95fdd60f90ca03d87a616c10abf5e425814246d171ac1041f42dcfbc87541136", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95fdd60f90ca03d87a616c10abf5e425814246d171ac1041f42dcfbc87541136", kill_on_drop: false }` [INFO] [stdout] 95fdd60f90ca03d87a616c10abf5e425814246d171ac1041f42dcfbc87541136 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 898f59936dc6aff6097c4834a3eff1f64b95c6ed65826b8cadb1090ddbf5a34a [INFO] running `Command { std: "docker" "start" "-a" "898f59936dc6aff6097c4834a3eff1f64b95c6ed65826b8cadb1090ddbf5a34a", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking clap_complete v4.5.24 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking mit-commit v3.2.1 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking mit-lint v3.2.9 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking mit-hook-test-helper v5.13.29 [INFO] [stderr] Checking mit-commit-message-lints v5.13.28 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/console/style.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|x| Box::new(x.to_string()) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/console/style.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|x| Box::new(x.to_string()) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/external/git2.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(mut config: git2::Config, state: Option) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self { [INFO] [stdout] 26 | config_snapshot: config.snapshot().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/external/git2.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 141 | .and_then(|repo| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let state = repo.state(); [INFO] [stdout] 143 | repo.config().map(|config| (config, Some(state))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/external/git2.rs:145:27 [INFO] [stdout] | [INFO] [stdout] 145 | .or_else(|_| (Config::open_default().map(|config| (config, None)))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/get_authors.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | .map_or_else(|| Err(super::errors::Error::AuthorFileNotSet.into()), Ok) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/get_authors.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | .map(|path| fs::read_to_string(path).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/get_authors.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / Command::new(commandline.first().unwrap_or(&String::new())) [INFO] [stdout] 90 | | .stderr(Stdio::inherit()) [INFO] [stdout] 91 | | .args(commandline.iter().skip(1)) [INFO] [stdout] 92 | | .output() [INFO] [stdout] 93 | | .into_diagnostic() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/set_commit_authors.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | / config [INFO] [stdout] 109 | | .set_i64(CONFIG_KEY_EXPIRES, expiry_time) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/vcs.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 19 | let email = get_vcs_coauthor_config(config, "email", index); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let name = get_vcs_coauthor_config(config, "name", index); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | matches!((name, email), (Ok(Some(_)), Ok(Some(_)))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relates/cmd/set_relates_to.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / config [INFO] [stdout] 39 | | .set_i64(CONFIG_KEY_EXPIRES, expiry_time) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mit-commit-message-lints` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/console/style.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|x| Box::new(x.to_string()) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/console/style.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|x| Box::new(x.to_string()) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/external/git2.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(mut config: git2::Config, state: Option) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self { [INFO] [stdout] 26 | config_snapshot: config.snapshot().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/external/git2.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 141 | .and_then(|repo| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let state = repo.state(); [INFO] [stdout] 143 | repo.config().map(|config| (config, Some(state))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/external/git2.rs:145:27 [INFO] [stdout] | [INFO] [stdout] 145 | .or_else(|_| (Config::open_default().map(|config| (config, None)))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/get_authors.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | .map_or_else(|| Err(super::errors::Error::AuthorFileNotSet.into()), Ok) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/get_authors.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | .map(|path| fs::read_to_string(path).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/get_authors.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / Command::new(commandline.first().unwrap_or(&String::new())) [INFO] [stdout] 90 | | .stderr(Stdio::inherit()) [INFO] [stdout] 91 | | .args(commandline.iter().skip(1)) [INFO] [stdout] 92 | | .output() [INFO] [stdout] 93 | | .into_diagnostic() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/set_commit_authors.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | / config [INFO] [stdout] 109 | | .set_i64(CONFIG_KEY_EXPIRES, expiry_time) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mit/cmd/vcs.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 19 | let email = get_vcs_coauthor_config(config, "email", index); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let name = get_vcs_coauthor_config(config, "name", index); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | matches!((name, email), (Ok(Some(_)), Ok(Some(_)))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relates/cmd/set_relates_to.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / config [INFO] [stdout] 39 | | .set_i64(CONFIG_KEY_EXPIRES, expiry_time) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mit-commit-message-lints` (lib test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "898f59936dc6aff6097c4834a3eff1f64b95c6ed65826b8cadb1090ddbf5a34a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "898f59936dc6aff6097c4834a3eff1f64b95c6ed65826b8cadb1090ddbf5a34a", kill_on_drop: false }` [INFO] [stdout] 898f59936dc6aff6097c4834a3eff1f64b95c6ed65826b8cadb1090ddbf5a34a