[INFO] fetching crate minipac 0.3.1... [INFO] checking minipac-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate minipac 0.3.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate minipac 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minipac 0.3.1 [INFO] finished tweaking crates.io crate minipac 0.3.1 [INFO] tweaked toml for crates.io crate minipac 0.3.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 55 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding crc v2.1.0 (latest: v3.2.1) [INFO] [stderr] Adding crc-catalog v1.1.1 (latest: v2.4.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zstd v0.9.2+zstd.1.5.1 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v4.1.3+zstd.1.5.1 (latest: v7.2.1) [INFO] [stderr] Adding zstd-sys v1.6.2+zstd.1.5.1 (latest: v2.0.13+zstd.1.5.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] feb8ee41a5ca7525fb34b4d43d3b8d925e2d3cdb2009db0a0c6da9a590487b85 [INFO] running `Command { std: "docker" "start" "-a" "feb8ee41a5ca7525fb34b4d43d3b8d925e2d3cdb2009db0a0c6da9a590487b85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "feb8ee41a5ca7525fb34b4d43d3b8d925e2d3cdb2009db0a0c6da9a590487b85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "feb8ee41a5ca7525fb34b4d43d3b8d925e2d3cdb2009db0a0c6da9a590487b85", kill_on_drop: false }` [INFO] [stdout] feb8ee41a5ca7525fb34b4d43d3b8d925e2d3cdb2009db0a0c6da9a590487b85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 912760decd6b4c9fbbee32d8dd37c214fc78a4dd865fc9c1d3e438ffc9a2d829 [INFO] running `Command { std: "docker" "start" "-a" "912760decd6b4c9fbbee32d8dd37c214fc78a4dd865fc9c1d3e438ffc9a2d829", kill_on_drop: false }` [INFO] [stderr] Compiling zstd-safe v4.1.3+zstd.1.5.1 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling zstd-sys v1.6.2+zstd.1.5.1 [INFO] [stderr] Checking kiss-tnc v0.2.2 [INFO] [stderr] Checking zstd v0.9.2+zstd.1.5.1 [INFO] [stderr] Checking minipac v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:263:17 [INFO] [stdout] | [INFO] [stdout] 252 | stream_sender: Sender<(Hostname, Stream)>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | packet_sender: UnboundedSender>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | connections: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:45:4 [INFO] [stdout] | [INFO] [stdout] 41 | let (s1, r1) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let (s2, r2) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | / Self { [INFO] [stdout] 46 | | writer: WriterStream { sender: s1 }, [INFO] [stdout] 47 | | reader: ReaderStream { receiver: r2 }, [INFO] [stdout] 48 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:49:4 [INFO] [stdout] | [INFO] [stdout] 41 | let (s1, r1) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let (s2, r2) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / Self { [INFO] [stdout] 50 | | writer: WriterStream { sender: s2 }, [INFO] [stdout] 51 | | reader: ReaderStream { receiver: r1 }, [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minipac` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:263:17 [INFO] [stdout] | [INFO] [stdout] 252 | stream_sender: Sender<(Hostname, Stream)>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | packet_sender: UnboundedSender>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | connections: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:45:4 [INFO] [stdout] | [INFO] [stdout] 41 | let (s1, r1) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let (s2, r2) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | / Self { [INFO] [stdout] 46 | | writer: WriterStream { sender: s1 }, [INFO] [stdout] 47 | | reader: ReaderStream { receiver: r2 }, [INFO] [stdout] 48 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:49:4 [INFO] [stdout] | [INFO] [stdout] 41 | let (s1, r1) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let (s2, r2) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / Self { [INFO] [stdout] 50 | | writer: WriterStream { sender: s2 }, [INFO] [stdout] 51 | | reader: ReaderStream { receiver: r1 }, [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minipac` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "912760decd6b4c9fbbee32d8dd37c214fc78a4dd865fc9c1d3e438ffc9a2d829", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "912760decd6b4c9fbbee32d8dd37c214fc78a4dd865fc9c1d3e438ffc9a2d829", kill_on_drop: false }` [INFO] [stdout] 912760decd6b4c9fbbee32d8dd37c214fc78a4dd865fc9c1d3e438ffc9a2d829