[INFO] fetching crate mining_proxy_sv2 0.1.1... [INFO] checking mining_proxy_sv2-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mining_proxy_sv2 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate mining_proxy_sv2 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mining_proxy_sv2 0.1.1 [INFO] finished tweaking crates.io crate mining_proxy_sv2 0.1.1 [INFO] tweaked toml for crates.io crate mining_proxy_sv2 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate mining_proxy_sv2 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b093a5c20f9b7741283a4d2bd1c7c2cab8fbad5a718bf537c6c89494c35f6b5 [INFO] running `Command { std: "docker" "start" "-a" "0b093a5c20f9b7741283a4d2bd1c7c2cab8fbad5a718bf537c6c89494c35f6b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b093a5c20f9b7741283a4d2bd1c7c2cab8fbad5a718bf537c6c89494c35f6b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b093a5c20f9b7741283a4d2bd1c7c2cab8fbad5a718bf537c6c89494c35f6b5", kill_on_drop: false }` [INFO] [stdout] 0b093a5c20f9b7741283a4d2bd1c7c2cab8fbad5a718bf537c6c89494c35f6b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 99f450a4596c1a7d971b05fb6606b1345b3df79ccd00251bff18a9f25764b520 [INFO] running `Command { std: "docker" "start" "-a" "99f450a4596c1a7d971b05fb6606b1345b3df79ccd00251bff18a9f25764b520", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking hex-conservative v0.1.1 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling binary_codec_sv2 v1.0.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling derive_codec_sv2 v1.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking bs58 v0.4.0 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking buffer_sv2 v1.0.0 [INFO] [stderr] Compiling async-recursion v0.3.2 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking const_sv2 v1.0.0 [INFO] [stderr] Checking const_sv2 v0.1.3 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking noise_sv2 v1.1.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking binary_sv2 v1.0.0 [INFO] [stderr] Checking framing_sv2 v1.0.0 [INFO] [stderr] Checking common_messages_sv2 v1.0.0 [INFO] [stderr] Checking job_declaration_sv2 v1.0.0 [INFO] [stderr] Checking template_distribution_sv2 v1.0.0 [INFO] [stderr] Checking mining_sv2 v1.0.0 [INFO] [stderr] Checking codec_sv2 v1.0.1 [INFO] [stderr] Checking stratum-common v1.0.0 [INFO] [stderr] Checking roles_logic_sv2 v1.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking network_helpers_sv2 v2.0.0 [INFO] [stderr] Checking key-utils v1.0.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking mining_proxy_sv2 v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:190:23 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn new(receiver: Receiver, sender: Sender, id: u32) -> Self { [INFO] [stdout] | ------------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | upstream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:246:44 [INFO] [stdout] | [INFO] [stdout] 246 | incoming.map(|payload| payload.try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:366:9 [INFO] [stdout] | [INFO] [stdout] 357 | up: Option>>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let cloned = up.as_ref().expect("No upstream initialized").clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | / up.as_ref() [INFO] [stdout] 367 | | .expect("No upstream initialized") [INFO] [stdout] 368 | | .safe_lock(|up| { [INFO] [stdout] 369 | | if up.channel_kind.is_extended() { [INFO] [stdout] ... | [INFO] [stdout] 388 | | } [INFO] [stdout] 389 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:362:28 [INFO] [stdout] | [INFO] [stdout] 362 | .safe_lock(|s| s.channel_ids.safe_lock(|r| r.next()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:479:12 [INFO] [stdout] | [INFO] [stdout] 465 | result: Option>, [INFO] [stdout] | ----------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 468 | let upstream = match super::get_routing_logic() { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 479 | Ok(SendToCommon::RelayNewMessageToRemote( [INFO] [stdout] | ____________^ [INFO] [stdout] 480 | | Arc::new(Mutex::new(())), [INFO] [stdout] 481 | | message.into(), [INFO] [stdout] 482 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:471:36 [INFO] [stdout] | [INFO] [stdout] 471 | .safe_lock(|r| r.downstream_to_upstream_map.get(&data).unwrap()[0].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:508:19 [INFO] [stdout] | [INFO] [stdout] 498 | let node = DownstreamMiningNode::new(receiver, sender, ids.next()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 501 | let mut incoming: StdFrame = node.receiver.recv().await.unwrap().try_into().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 505 | let node = Arc::new(Mutex::new(node)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | match DownstreamMiningNode::handle_message_common( [INFO] [stdout] | ___________________^ [INFO] [stdout] 509 | | node.clone(), [INFO] [stdout] 510 | | message_type, [INFO] [stdout] 511 | | payload, [INFO] [stdout] 512 | | routing_logic, [INFO] [stdout] 513 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:218:25 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | connection: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:221:43 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | channel_id_to_job_dispatcher: HashMap::with_hasher(BuildNoHashHasher::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:224:27 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | channel_kind: channel_kind.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | tx_outs: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:231:33 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | job_up_to_down_ids: HashMap::with_hasher(BuildNoHashHasher::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:409:78 [INFO] [stdout] | [INFO] [stdout] 408 | let cloned = self_mutex.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 409 | let mut response = task::spawn(async { Self::receive(cloned).await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:419:48 [INFO] [stdout] | [INFO] [stdout] 419 | ... .safe_lock(|self_| self_.connection.clone().unwrap().receiver) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:522:44 [INFO] [stdout] | [INFO] [stdout] 522 | incoming.map(|payload| payload.try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:554:64 [INFO] [stdout] | [INFO] [stdout] 554 | ... > = incoming.clone().map(|payload| payload.try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:620:15 [INFO] [stdout] | [INFO] [stdout] 596 | self_mutex: Arc>, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 602 | let (frame, downstream_hr) = self_mutex [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | let cloned = self_mutex.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 613 | let mut response = task::spawn(async { Self::receive(cloned).await }) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 620 | match (message_type, payload).try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:613:70 [INFO] [stdout] | [INFO] [stdout] 612 | let cloned = self_mutex.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 613 | let mut response = task::spawn(async { Self::receive(cloned).await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:1119:12 [INFO] [stdout] | [INFO] [stdout] 1041 | let mut res = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1119 | Ok(SendTo::Multiple(res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:1196:25 [INFO] [stdout] | [INFO] [stdout] 1194 | let node = node.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1195 | let cloned = res.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1196 | task::spawn(async move { [INFO] [stdout] | _________________________^ [INFO] [stdout] 1197 | | if let Err(e) = UpstreamMiningNode::setup_flag_and_version( [INFO] [stdout] 1198 | | node.clone(), [INFO] [stdout] 1199 | | None, [INFO] [stdout] ... | [INFO] [stdout] 1208 | | } [INFO] [stdout] 1209 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:1207:49 [INFO] [stdout] | [INFO] [stdout] 1207 | cloned.safe_lock(|r| r.push(node.clone())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mining_proxy_sv2` (lib test) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:190:23 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn new(receiver: Receiver, sender: Sender, id: u32) -> Self { [INFO] [stdout] | ------------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | upstream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:246:44 [INFO] [stdout] | [INFO] [stdout] 246 | incoming.map(|payload| payload.try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:366:9 [INFO] [stdout] | [INFO] [stdout] 357 | up: Option>>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let cloned = up.as_ref().expect("No upstream initialized").clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | / up.as_ref() [INFO] [stdout] 367 | | .expect("No upstream initialized") [INFO] [stdout] 368 | | .safe_lock(|up| { [INFO] [stdout] 369 | | if up.channel_kind.is_extended() { [INFO] [stdout] ... | [INFO] [stdout] 388 | | } [INFO] [stdout] 389 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:362:28 [INFO] [stdout] | [INFO] [stdout] 362 | .safe_lock(|s| s.channel_ids.safe_lock(|r| r.next()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:479:12 [INFO] [stdout] | [INFO] [stdout] 465 | result: Option>, [INFO] [stdout] | ----------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 468 | let upstream = match super::get_routing_logic() { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 479 | Ok(SendToCommon::RelayNewMessageToRemote( [INFO] [stdout] | ____________^ [INFO] [stdout] 480 | | Arc::new(Mutex::new(())), [INFO] [stdout] 481 | | message.into(), [INFO] [stdout] 482 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:471:36 [INFO] [stdout] | [INFO] [stdout] 471 | .safe_lock(|r| r.downstream_to_upstream_map.get(&data).unwrap()[0].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:508:19 [INFO] [stdout] | [INFO] [stdout] 498 | let node = DownstreamMiningNode::new(receiver, sender, ids.next()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 501 | let mut incoming: StdFrame = node.receiver.recv().await.unwrap().try_into().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 505 | let node = Arc::new(Mutex::new(node)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | match DownstreamMiningNode::handle_message_common( [INFO] [stdout] | ___________________^ [INFO] [stdout] 509 | | node.clone(), [INFO] [stdout] 510 | | message_type, [INFO] [stdout] 511 | | payload, [INFO] [stdout] 512 | | routing_logic, [INFO] [stdout] 513 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:218:25 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | connection: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:221:43 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | channel_id_to_job_dispatcher: HashMap::with_hasher(BuildNoHashHasher::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:224:27 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | channel_kind: channel_kind.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | tx_outs: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:231:33 [INFO] [stdout] | [INFO] [stdout] 204 | group_id: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | channel_ids: Arc>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | downstream_share_per_minute: f32, [INFO] [stdout] 207 | solution_sender: Option>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | recv_coinbase_out: Option, Vec)>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let downstream_selector = ProxyRemoteSelector::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | job_up_to_down_ids: HashMap::with_hasher(BuildNoHashHasher::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:409:78 [INFO] [stdout] | [INFO] [stdout] 408 | let cloned = self_mutex.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 409 | let mut response = task::spawn(async { Self::receive(cloned).await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:419:48 [INFO] [stdout] | [INFO] [stdout] 419 | ... .safe_lock(|self_| self_.connection.clone().unwrap().receiver) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:522:44 [INFO] [stdout] | [INFO] [stdout] 522 | incoming.map(|payload| payload.try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:554:64 [INFO] [stdout] | [INFO] [stdout] 554 | ... > = incoming.clone().map(|payload| payload.try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:620:15 [INFO] [stdout] | [INFO] [stdout] 596 | self_mutex: Arc>, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 602 | let (frame, downstream_hr) = self_mutex [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | let cloned = self_mutex.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 613 | let mut response = task::spawn(async { Self::receive(cloned).await }) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 620 | match (message_type, payload).try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:613:70 [INFO] [stdout] | [INFO] [stdout] 612 | let cloned = self_mutex.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 613 | let mut response = task::spawn(async { Self::receive(cloned).await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:1119:12 [INFO] [stdout] | [INFO] [stdout] 1041 | let mut res = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1119 | Ok(SendTo::Multiple(res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:1196:25 [INFO] [stdout] | [INFO] [stdout] 1194 | let node = node.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1195 | let cloned = res.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1196 | task::spawn(async move { [INFO] [stdout] | _________________________^ [INFO] [stdout] 1197 | | if let Err(e) = UpstreamMiningNode::setup_flag_and_version( [INFO] [stdout] 1198 | | node.clone(), [INFO] [stdout] 1199 | | None, [INFO] [stdout] ... | [INFO] [stdout] 1208 | | } [INFO] [stdout] 1209 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:1207:49 [INFO] [stdout] | [INFO] [stdout] 1207 | cloned.safe_lock(|r| r.push(node.clone())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mining_proxy_sv2` (lib) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "99f450a4596c1a7d971b05fb6606b1345b3df79ccd00251bff18a9f25764b520", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99f450a4596c1a7d971b05fb6606b1345b3df79ccd00251bff18a9f25764b520", kill_on_drop: false }` [INFO] [stdout] 99f450a4596c1a7d971b05fb6606b1345b3df79ccd00251bff18a9f25764b520