[INFO] fetching crate minimap2 0.1.20+minimap2.2.28... [INFO] checking minimap2-0.1.20+minimap2.2.28 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate minimap2 0.1.20+minimap2.2.28 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate minimap2 0.1.20+minimap2.2.28 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minimap2 0.1.20+minimap2.2.28 [INFO] finished tweaking crates.io crate minimap2 0.1.20+minimap2.2.28 [INFO] tweaked toml for crates.io crate minimap2 0.1.20+minimap2.2.28 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 83 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding derive-new v0.5.9 (latest: v0.7.0) [INFO] [stderr] Adding derive-new v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustc_version v0.1.7 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.1.20 (latest: v1.0.23) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 381c20b348b612e48864cd53f9f7a61a47a7cd8661da5fec7ddde0d4410fa5c9 [INFO] running `Command { std: "docker" "start" "-a" "381c20b348b612e48864cd53f9f7a61a47a7cd8661da5fec7ddde0d4410fa5c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "381c20b348b612e48864cd53f9f7a61a47a7cd8661da5fec7ddde0d4410fa5c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "381c20b348b612e48864cd53f9f7a61a47a7cd8661da5fec7ddde0d4410fa5c9", kill_on_drop: false }` [INFO] [stdout] 381c20b348b612e48864cd53f9f7a61a47a7cd8661da5fec7ddde0d4410fa5c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f2811e5882de6f8c9c52e19e40c8c0f5bd71022da3b6ab54ba1ba8cac4c601d [INFO] running `Command { std: "docker" "start" "-a" "4f2811e5882de6f8c9c52e19e40c8c0f5bd71022da3b6ab54ba1ba8cac4c601d", kill_on_drop: false }` [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling minimap2-sys v0.1.19+minimap2.2.28 [INFO] [stderr] Checking buffer-redux v1.0.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking needletail v0.5.1 [INFO] [stderr] Checking minimap2 v0.1.20+minimap2.2.28 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:494:15 [INFO] [stdout] | [INFO] [stdout] 482 | pub fn preset(self, preset: Preset) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 494 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:727:22 [INFO] [stdout] | [INFO] [stdout] 727 | .map(|s| std::ffi::CString::new(s.clone()).expect("Invalid Sequence")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:731:22 [INFO] [stdout] | [INFO] [stdout] 731 | .map(|s| std::ffi::CString::new(s.clone()).expect("Invalid ID")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minimap2` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `aligner` [INFO] [stdout] --> src/lib.rs:1246:13 [INFO] [stdout] | [INFO] [stdout] 1246 | let aligner = jh.join().unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_aligner` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `jh0` [INFO] [stdout] --> src/lib.rs:1275:13 [INFO] [stdout] | [INFO] [stdout] 1275 | let jh0 = thread::spawn(move || { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_jh0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `jh1` [INFO] [stdout] --> src/lib.rs:1283:13 [INFO] [stdout] | [INFO] [stdout] 1283 | let jh1 = thread::spawn(move || { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_jh1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `results` [INFO] [stdout] --> src/lib.rs:1321:13 [INFO] [stdout] | [INFO] [stdout] 1321 | let results = sequences [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_results` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/lib.rs:1341:13 [INFO] [stdout] | [INFO] [stdout] 1341 | let x: IdxOpt = Default::default(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/lib.rs:1346:13 [INFO] [stdout] | [INFO] [stdout] 1346 | let x: mm_mapopt_t = Default::default(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/lib.rs:1347:13 [INFO] [stdout] | [INFO] [stdout] 1347 | let y: MapOpt = Default::default(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `aligner` [INFO] [stdout] --> src/lib.rs:1360:13 [INFO] [stdout] | [INFO] [stdout] 1360 | let aligner = Aligner { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_aligner` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/lib.rs:1372:13 [INFO] [stdout] | [INFO] [stdout] 1372 | let result = Aligner::builder(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/lib.rs:1377:13 [INFO] [stdout] | [INFO] [stdout] 1377 | let result = Aligner::builder().preset(Preset::LrHq); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/lib.rs:1382:13 [INFO] [stdout] | [INFO] [stdout] 1382 | let result = Aligner::builder() [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `aligner` is never read [INFO] [stdout] --> src/lib.rs:1409:9 [INFO] [stdout] | [INFO] [stdout] 1409 | aligner = aligner [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1447:13 [INFO] [stdout] | [INFO] [stdout] 1447 | let mut aligner = aligner.with_cigar(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `observed` [INFO] [stdout] --> src/lib.rs:1587:13 [INFO] [stdout] | [INFO] [stdout] 1587 | let observed = mappings.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_observed` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `aligner` [INFO] [stdout] --> src/lib.rs:1843:13 [INFO] [stdout] | [INFO] [stdout] 1843 | let aligner = Aligner { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_aligner` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:494:15 [INFO] [stdout] | [INFO] [stdout] 482 | pub fn preset(self, preset: Preset) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 494 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minimap2` (lib test) due to 4 previous errors; 15 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:727:22 [INFO] [stdout] | [INFO] [stdout] 727 | .map(|s| std::ffi::CString::new(s.clone()).expect("Invalid Sequence")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:731:22 [INFO] [stdout] | [INFO] [stdout] 731 | .map(|s| std::ffi::CString::new(s.clone()).expect("Invalid ID")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "4f2811e5882de6f8c9c52e19e40c8c0f5bd71022da3b6ab54ba1ba8cac4c601d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f2811e5882de6f8c9c52e19e40c8c0f5bd71022da3b6ab54ba1ba8cac4c601d", kill_on_drop: false }` [INFO] [stdout] 4f2811e5882de6f8c9c52e19e40c8c0f5bd71022da3b6ab54ba1ba8cac4c601d