[INFO] fetching crate minify-js 0.6.0... [INFO] checking minify-js-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate minify-js 0.6.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate minify-js 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minify-js 0.6.0 [INFO] finished tweaking crates.io crate minify-js 0.6.0 [INFO] tweaked toml for crates.io crate minify-js 0.6.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.7.20 (latest: v1.1.3) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding parse-js v0.20.1 (latest: v0.24.0) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f19fabb45739b2325a9ca599caaab6c4a6372ee9087c1e770fc3e00fc0d1a582 [INFO] running `Command { std: "docker" "start" "-a" "f19fabb45739b2325a9ca599caaab6c4a6372ee9087c1e770fc3e00fc0d1a582", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f19fabb45739b2325a9ca599caaab6c4a6372ee9087c1e770fc3e00fc0d1a582", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f19fabb45739b2325a9ca599caaab6c4a6372ee9087c1e770fc3e00fc0d1a582", kill_on_drop: false }` [INFO] [stdout] f19fabb45739b2325a9ca599caaab6c4a6372ee9087c1e770fc3e00fc0d1a582 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2df40c64992c62a4dbf8d8482fa4094f3113e71e6fdce13ea0c5e32c720d62e8 [INFO] running `Command { std: "docker" "start" "-a" "2df40c64992c62a4dbf8d8482fa4094f3113e71e6fdce13ea0c5e32c720d62e8", kill_on_drop: false }` [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking parse-js v0.20.1 [INFO] [stderr] Checking minify-js v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::cmp::max` [INFO] [stdout] --> src/minify/ctx.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::cmp::max; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> src/minify/ctx.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::mem::discriminant` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use core::mem::discriminant; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::Ordering` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::cmp::Ordering; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parse_js::flag::Flags` [INFO] [stdout] --> src/minify/pass3.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use parse_js::flag::Flags; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::max` [INFO] [stdout] --> src/minify/ctx.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::cmp::max; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> src/minify/ctx.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::mem::discriminant` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use core::mem::discriminant; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::Ordering` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::cmp::Ordering; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parse_js::flag::Flags` [INFO] [stdout] --> src/minify/pass3.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use parse_js::flag::Flags; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:126:35 [INFO] [stdout] | [INFO] [stdout] 126 | Syntax::IdentifierPattern { name } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `header` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | Syntax::ForStmt { header, body } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `header: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:149:33 [INFO] [stdout] | [INFO] [stdout] 149 | Syntax::ForStmt { header, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `condition` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:152:27 [INFO] [stdout] | [INFO] [stdout] 152 | Syntax::WhileStmt { condition, body } => { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `condition: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:152:38 [INFO] [stdout] | [INFO] [stdout] 152 | Syntax::WhileStmt { condition, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `condition` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:155:29 [INFO] [stdout] | [INFO] [stdout] 155 | Syntax::DoWhileStmt { condition, body } => { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `condition: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:155:40 [INFO] [stdout] | [INFO] [stdout] 155 | Syntax::DoWhileStmt { condition, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:126:35 [INFO] [stdout] | [INFO] [stdout] 126 | Syntax::IdentifierPattern { name } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `header` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | Syntax::ForStmt { header, body } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `header: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:149:33 [INFO] [stdout] | [INFO] [stdout] 149 | Syntax::ForStmt { header, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `condition` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:152:27 [INFO] [stdout] | [INFO] [stdout] 152 | Syntax::WhileStmt { condition, body } => { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `condition: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:152:38 [INFO] [stdout] | [INFO] [stdout] 152 | Syntax::WhileStmt { condition, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `condition` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:155:29 [INFO] [stdout] | [INFO] [stdout] 155 | Syntax::DoWhileStmt { condition, body } => { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `condition: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:155:40 [INFO] [stdout] | [INFO] [stdout] 155 | Syntax::DoWhileStmt { condition, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_sibling_of` is never used [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:36:10 [INFO] [stdout] | [INFO] [stdout] 15 | impl<'a> LexicalLifetime<'a> { [INFO] [stdout] | ---------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn is_sibling_of(&self, other: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `in_loop` is never read [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:45:7 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct LexicalLifetimesPass<'a, 'b> { [INFO] [stdout] | -------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | pub in_loop: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:49:10 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a, 'b> LexicalLifetimesPass<'a, 'b> { [INFO] [stdout] | ----------------------------------------- associated function in this implementation [INFO] [stdout] 49 | pub fn new(ctx: Ctx<'a, 'b>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minify/advanced_if.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 91 | let mut hoisted_vars: SessionVec<'a, SourceRange<'a>> = session.new_vec(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let mut expressions: SessionVec<'a, Node<'a>> = session.new_vec(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | expression: expressions [INFO] [stdout] | _________________^ [INFO] [stdout] 179 | | .into_iter() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minify-js` (lib) due to 2 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `is_sibling_of` is never used [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:36:10 [INFO] [stdout] | [INFO] [stdout] 15 | impl<'a> LexicalLifetime<'a> { [INFO] [stdout] | ---------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn is_sibling_of(&self, other: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `in_loop` is never read [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:45:7 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct LexicalLifetimesPass<'a, 'b> { [INFO] [stdout] | -------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | pub in_loop: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/minify/lexical_lifetimes.rs:49:10 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a, 'b> LexicalLifetimesPass<'a, 'b> { [INFO] [stdout] | ----------------------------------------- associated function in this implementation [INFO] [stdout] 49 | pub fn new(ctx: Ctx<'a, 'b>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minify/advanced_if.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 91 | let mut hoisted_vars: SessionVec<'a, SourceRange<'a>> = session.new_vec(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let mut expressions: SessionVec<'a, Node<'a>> = session.new_vec(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | expression: expressions [INFO] [stdout] | _________________^ [INFO] [stdout] 179 | | .into_iter() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minify-js` (lib test) due to 2 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2df40c64992c62a4dbf8d8482fa4094f3113e71e6fdce13ea0c5e32c720d62e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2df40c64992c62a4dbf8d8482fa4094f3113e71e6fdce13ea0c5e32c720d62e8", kill_on_drop: false }` [INFO] [stdout] 2df40c64992c62a4dbf8d8482fa4094f3113e71e6fdce13ea0c5e32c720d62e8