[INFO] fetching crate minifier 0.3.1... [INFO] checking minifier-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate minifier 0.3.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate minifier 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minifier 0.3.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate minifier 0.3.1 [INFO] tweaked toml for crates.io crate minifier 0.3.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate minifier 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e675c14ab61bb140bfdad30bd7c6262047d07c873372e978a2bba0dc1ec97945 [INFO] running `Command { std: "docker" "start" "-a" "e675c14ab61bb140bfdad30bd7c6262047d07c873372e978a2bba0dc1ec97945", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e675c14ab61bb140bfdad30bd7c6262047d07c873372e978a2bba0dc1ec97945", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e675c14ab61bb140bfdad30bd7c6262047d07c873372e978a2bba0dc1ec97945", kill_on_drop: false }` [INFO] [stdout] e675c14ab61bb140bfdad30bd7c6262047d07c873372e978a2bba0dc1ec97945 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26f95e6f9390216f06ec5c6a19868678f7519901e58b549c473d60351011d66a [INFO] running `Command { std: "docker" "start" "-a" "26f95e6f9390216f06ec5c6a19868678f7519901e58b549c473d60351011d66a", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking minifier v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/byte_to_char.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(read: R, buffer_size: usize) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(ByteToChar { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | iter: InternalReader::new(read, buffer_size)?, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/byte_to_char.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 44 | Err(err) => return Some(Err(err)), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Some(match from_utf8(&buf[..width]).ok() { [INFO] [stdout] | ______________^ [INFO] [stdout] 74 | | Some(s) => Ok(s.chars().next().unwrap()), [INFO] [stdout] 75 | | None => Err(CharsError::NotUtf8), [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/internal_reader.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(mut read: R, buffer_size: usize) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok(InternalReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | read, [INFO] [stdout] 21 | | buffer_size, [INFO] [stdout] 22 | | buffer, [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/json_read.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(read: R, predicate: P) -> Self { [INFO] [stdout] | ------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | read: Some(read), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/json_read.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(read: R, predicate: P) -> Self { [INFO] [stdout] | ------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | iter: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minifier` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/byte_to_char.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(read: R, buffer_size: usize) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(ByteToChar { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | iter: InternalReader::new(read, buffer_size)?, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/byte_to_char.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 44 | Err(err) => return Some(Err(err)), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Some(match from_utf8(&buf[..width]).ok() { [INFO] [stdout] | ______________^ [INFO] [stdout] 74 | | Some(s) => Ok(s.chars().next().unwrap()), [INFO] [stdout] 75 | | None => Err(CharsError::NotUtf8), [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/internal_reader.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(mut read: R, buffer_size: usize) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok(InternalReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | read, [INFO] [stdout] 21 | | buffer_size, [INFO] [stdout] 22 | | buffer, [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/json_read.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(read: R, predicate: P) -> Self { [INFO] [stdout] | ------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | read: Some(read), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/read/json_read.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(read: R, predicate: P) -> Self { [INFO] [stdout] | ------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | iter: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minifier` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "26f95e6f9390216f06ec5c6a19868678f7519901e58b549c473d60351011d66a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26f95e6f9390216f06ec5c6a19868678f7519901e58b549c473d60351011d66a", kill_on_drop: false }` [INFO] [stdout] 26f95e6f9390216f06ec5c6a19868678f7519901e58b549c473d60351011d66a