[INFO] fetching crate minifb 0.27.0... [INFO] checking minifb-0.27.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate minifb 0.27.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate minifb 0.27.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minifb 0.27.0 [INFO] finished tweaking crates.io crate minifb 0.27.0 [INFO] tweaked toml for crates.io crate minifb 0.27.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate minifb 0.27.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10484b585ad5385494491f7afc8a862b8fc1556ebfc4e11968c0b8b49caeabad [INFO] running `Command { std: "docker" "start" "-a" "10484b585ad5385494491f7afc8a862b8fc1556ebfc4e11968c0b8b49caeabad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10484b585ad5385494491f7afc8a862b8fc1556ebfc4e11968c0b8b49caeabad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10484b585ad5385494491f7afc8a862b8fc1556ebfc4e11968c0b8b49caeabad", kill_on_drop: false }` [INFO] [stdout] 10484b585ad5385494491f7afc8a862b8fc1556ebfc4e11968c0b8b49caeabad [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8b4e48b0f7d3b2fbac0ce298f40d23fa3b6932152bc2bb1887effe0970fb1bf [INFO] running `Command { std: "docker" "start" "-a" "a8b4e48b0f7d3b2fbac0ce298f40d23fa3b6932152bc2bb1887effe0970fb1bf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling xml-rs v0.8.20 [INFO] [stderr] Checking libloading v0.8.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Compiling minifb v0.27.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/posix/wayland.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 76 | fn new(shm: Main, format: Format) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Self { [INFO] [stdout] 78 | pool: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/posix/wayland.rs:113:51 [INFO] [stdout] | [INFO] [stdout] 113 | let pos = self.pool.iter().rposition(|e| *e.buffer_state.borrow()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/posix/wayland.rs:297:12 [INFO] [stdout] | [INFO] [stdout] 176 | let display = Display::connect_to_env().map_err(|e| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let mut event_queue = display.create_event_queue(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let attached_display = (*display).clone().attach(event_queue.token()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let globals = GlobalManager::new(&attached_display); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let seat = globals [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let input_devices = WaylandInput::new(&seat); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let compositor = globals.instantiate_exact::(4).map_err(|e| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let shm = globals [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let surface = compositor.create_surface(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let mut buf_pool = BufferPool::new(shm.clone(), format); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let (mut tempfile, buffer) = buf_pool [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let xdg_wm_base = globals.instantiate_exact::(1).map_err(|e| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let xdg_surface = xdg_wm_base.get_xdg_surface(&surface); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | let surface_clone = surface.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | let xdg_toplevel = xdg_surface.get_toplevel(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | let cursor = wayland_cursor::CursorTheme::load(16, &shm); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | let cursor_surface = compositor.create_surface(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | [INFO] [stdout] 297 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 298 | | Self { [INFO] [stdout] 299 | | _display: display, [INFO] [stdout] 300 | | attached_display, [INFO] [stdout] ... | [INFO] [stdout] 310 | | input_devices, [INFO] [stdout] 311 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/posix/wayland.rs:529:12 [INFO] [stdout] | [INFO] [stdout] 493 | let (display, input) = DisplayInfo::new( [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 530 | | display, [INFO] [stdout] 531 | | [INFO] [stdout] 532 | | width: width as i32 * scale, [INFO] [stdout] ... | [INFO] [stdout] 562 | | pointer_visibility: true, [INFO] [stdout] 563 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/posix/wayland.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 76 | fn new(shm: Main, format: Format) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Self { [INFO] [stdout] 78 | pool: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/posix/wayland.rs:113:51 [INFO] [stdout] | [INFO] [stdout] 113 | let pos = self.pool.iter().rposition(|e| *e.buffer_state.borrow()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/posix/wayland.rs:297:12 [INFO] [stdout] | [INFO] [stdout] 176 | let display = Display::connect_to_env().map_err(|e| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let mut event_queue = display.create_event_queue(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let attached_display = (*display).clone().attach(event_queue.token()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let globals = GlobalManager::new(&attached_display); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let seat = globals [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let input_devices = WaylandInput::new(&seat); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let compositor = globals.instantiate_exact::(4).map_err(|e| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let shm = globals [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let surface = compositor.create_surface(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let mut buf_pool = BufferPool::new(shm.clone(), format); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let (mut tempfile, buffer) = buf_pool [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let xdg_wm_base = globals.instantiate_exact::(1).map_err(|e| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let xdg_surface = xdg_wm_base.get_xdg_surface(&surface); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | let surface_clone = surface.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | let xdg_toplevel = xdg_surface.get_toplevel(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | let cursor = wayland_cursor::CursorTheme::load(16, &shm); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | let cursor_surface = compositor.create_surface(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | [INFO] [stdout] 297 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 298 | | Self { [INFO] [stdout] 299 | | _display: display, [INFO] [stdout] 300 | | attached_display, [INFO] [stdout] ... | [INFO] [stdout] 310 | | input_devices, [INFO] [stdout] 311 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/posix/wayland.rs:529:12 [INFO] [stdout] | [INFO] [stdout] 493 | let (display, input) = DisplayInfo::new( [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 530 | | display, [INFO] [stdout] 531 | | [INFO] [stdout] 532 | | width: width as i32 * scale, [INFO] [stdout] ... | [INFO] [stdout] 562 | | pointer_visibility: true, [INFO] [stdout] 563 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minifb` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `minifb` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "a8b4e48b0f7d3b2fbac0ce298f40d23fa3b6932152bc2bb1887effe0970fb1bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8b4e48b0f7d3b2fbac0ce298f40d23fa3b6932152bc2bb1887effe0970fb1bf", kill_on_drop: false }` [INFO] [stdout] a8b4e48b0f7d3b2fbac0ce298f40d23fa3b6932152bc2bb1887effe0970fb1bf