[INFO] fetching crate minidump-writer 0.10.0... [INFO] checking minidump-writer-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate minidump-writer 0.10.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate minidump-writer 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate minidump-writer 0.10.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate minidump-writer 0.10.0 [INFO] tweaked toml for crates.io crate minidump-writer 0.10.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate minidump-writer 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4b39f7680c802ec7b00acf1ad10c565b5ba2e332db8a73e5648d34273f26741 [INFO] running `Command { std: "docker" "start" "-a" "b4b39f7680c802ec7b00acf1ad10c565b5ba2e332db8a73e5648d34273f26741", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4b39f7680c802ec7b00acf1ad10c565b5ba2e332db8a73e5648d34273f26741", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4b39f7680c802ec7b00acf1ad10c565b5ba2e332db8a73e5648d34273f26741", kill_on_drop: false }` [INFO] [stdout] b4b39f7680c802ec7b00acf1ad10c565b5ba2e332db8a73e5648d34273f26741 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c03a2fecfb43953959d55fc67c9ad0d00e7a2476073999f84bed745659fe297 [INFO] running `Command { std: "docker" "start" "-a" "4c03a2fecfb43953959d55fc67c9ad0d00e7a2476073999f84bed745659fe297", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.156 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking range-map v0.2.0 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking debugid v0.8.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking procfs-core v0.16.0 [INFO] [stderr] Compiling minidump-writer v0.10.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Compiling current_platform v0.2.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking crash-context v0.6.3 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling scroll_derive v0.12.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling smart-default v0.7.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking scroll v0.12.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking goblin v0.8.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking minidump-common v0.22.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking minidump v0.22.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/auxv/reader.rs:91:14 [INFO] [stdout] | [INFO] [stdout] 69 | Err(x) => return Some(Err(x.into())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Err(x) => return Some(Err(x.into())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Some(Ok(AuxvPair { [INFO] [stdout] | ______________^ [INFO] [stdout] 92 | | key: aux_key, [INFO] [stdout] 93 | | value: aux_val, [INFO] [stdout] 94 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/maps_reader.rs:285:49 [INFO] [stdout] | [INFO] [stdout] 285 | let Some(file_name) = soname.or_else(|| self.so_name().ok()) else { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/mem_reader.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 79 | let file = std::fs::File::open(format!("/proc/{pid}/mem"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | [INFO] [stdout] 81 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | pid: nix::unistd::Pid::from_raw(pid), [INFO] [stdout] 83 | | style: Some(Style::File(file)), [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/module_reader.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 153 | fn read_from_module(module_memory: ProcessMemory<'_>) -> Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let mut reader = ModuleReader::new(module_memory)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let program_headers = match reader.build_id_from_program_headers() { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok(v) => return Ok(BuildId(v)), [INFO] [stdout] 157 | Err(e) => Box::new(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | }; [INFO] [stdout] 159 | let section = match reader.build_id_from_section() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | Ok(v) => return Ok(BuildId(v)), [INFO] [stdout] 161 | Err(e) => Box::new(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | }; [INFO] [stdout] 163 | let generated = match reader.build_id_generate_from_text() { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | Ok(v) => return Ok(BuildId(v)), [INFO] [stdout] 165 | Err(e) => Box::new(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | }; [INFO] [stdout] 167 | Err(Error::NoBuildId { [INFO] [stdout] | _____________^ [INFO] [stdout] 168 | | program_headers, [INFO] [stdout] 169 | | section, [INFO] [stdout] 170 | | generated, [INFO] [stdout] 171 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/module_reader.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 213 | fn read_from_module(module_memory: ProcessMemory<'_>) -> Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let mut reader = ModuleReader::new(module_memory)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | let program_headers = match reader.soname_from_program_headers() { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | Ok(v) => return Ok(SoName(v)), [INFO] [stdout] 217 | Err(e) => Box::new(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | }; [INFO] [stdout] 219 | let section = match reader.soname_from_sections() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | Ok(v) => return Ok(SoName(v)), [INFO] [stdout] 221 | Err(e) => Box::new(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | }; [INFO] [stdout] 223 | Err(Error::NoSoName { [INFO] [stdout] | _____________^ [INFO] [stdout] 224 | | program_headers, [INFO] [stdout] 225 | | section, [INFO] [stdout] 226 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/module_reader.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn new(mut module_memory: ProcessMemory<'buf>) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 247 | | module_memory, [INFO] [stdout] 248 | | header, [INFO] [stdout] 249 | | context, [INFO] [stdout] 250 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/module_reader.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | Err(Error::NoSoNameEntry) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/module_reader.rs:343:13 [INFO] [stdout] | [INFO] [stdout] 343 | Err(Error::NoProgramHeaderNote) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/module_reader.rs:358:15 [INFO] [stdout] | [INFO] [stdout] 358 | match self.find_build_id_note(header.sh_offset, header.sh_size, header.sh_addralign) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/ptrace_dumper.rs:216:33 [INFO] [stdout] | [INFO] [stdout] 216 | self.threads.retain(|x| Self::suspend_thread(x.tid).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/ptrace_dumper.rs:324:30 [INFO] [stdout] | [INFO] [stdout] 324 | .and_then(|maps| MappingInfo::aggregate(maps, linux_gate_loc).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minidump-writer` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4c03a2fecfb43953959d55fc67c9ad0d00e7a2476073999f84bed745659fe297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c03a2fecfb43953959d55fc67c9ad0d00e7a2476073999f84bed745659fe297", kill_on_drop: false }` [INFO] [stdout] 4c03a2fecfb43953959d55fc67c9ad0d00e7a2476073999f84bed745659fe297