[INFO] fetching crate minidsp-protocol 0.1.4... [INFO] checking minidsp-protocol-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate minidsp-protocol 0.1.4 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate minidsp-protocol 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minidsp-protocol 0.1.4 [INFO] finished tweaking crates.io crate minidsp-protocol 0.1.4 [INFO] tweaked toml for crates.io crate minidsp-protocol 0.1.4 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding strum v0.23.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.23.1 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3642215b434954afdb936857727e65ad69579ffe428e5a0d1a96c5a18c78cb1 [INFO] running `Command { std: "docker" "start" "-a" "b3642215b434954afdb936857727e65ad69579ffe428e5a0d1a96c5a18c78cb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3642215b434954afdb936857727e65ad69579ffe428e5a0d1a96c5a18c78cb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3642215b434954afdb936857727e65ad69579ffe428e5a0d1a96c5a18c78cb1", kill_on_drop: false }` [INFO] [stdout] b3642215b434954afdb936857727e65ad69579ffe428e5a0d1a96c5a18c78cb1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b9932c468acb2a89c21ce8523bcae30d61e7300127992a83a0a5f4a469d7e513 [INFO] running `Command { std: "docker" "start" "-a" "b9932c468acb2a89c21ce8523bcae30d61e7300127992a83a0a5f4a469d7e513", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking minidsp-protocol v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/util/try_buf.rs:37:14 [INFO] [stdout] | [INFO] [stdout] 35 | pub trait TryBuf { [INFO] [stdout] | ------ methods in this trait [INFO] [stdout] 36 | try_def!(try_get_u8, u8); [INFO] [stdout] 37 | try_def!(try_get_i8, i8); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | try_def!(try_get_i16, i16); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 42 | try_def!(try_get_i16_le, i16); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 43 | [INFO] [stdout] 44 | try_def!(try_get_u32, u32); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 45 | try_def!(try_get_u32_le, u32); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 46 | try_def!(try_get_i32, i32); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 47 | try_def!(try_get_i32_le, i32); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 48 | [INFO] [stdout] 49 | try_def!(try_get_u64, u64); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 50 | try_def!(try_get_u64_le, u64); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 51 | try_def!(try_get_i64, i64); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 52 | try_def!(try_get_i64_le, i64); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 53 | [INFO] [stdout] 54 | try_def!(try_get_f32, f32); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | try_def!(try_get_f64, f64); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 58 | try_def!(try_get_f64_le, f64); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] = note: this warning originates in the macro `try_def` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn from_bytes(mut b: Bytes) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Ok( [INFO] [stdout] 122 | / if b.len() == 4 && ((b[0] != 0 || b[1] != 0) && b[2] == 0 && b[3] == 0) { [INFO] [stdout] 123 | | Value::Int(b.try_get_u16_le()?) [INFO] [stdout] 124 | | } else { [INFO] [stdout] 125 | | Value::Unknown(b) [INFO] [stdout] 126 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 397 | pub fn from_bytes(mut frame: Bytes) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | Ok(match frame.try_get_u8()? { [INFO] [stdout] | ____________^ [INFO] [stdout] 399 | | 0x02 => Commands::Read { [INFO] [stdout] 400 | | addr: { [INFO] [stdout] 401 | | let len = if frame.len() >= 3 { 3 } else { 2 }; [INFO] [stdout] ... | [INFO] [stdout] 505 | | }, [INFO] [stdout] 506 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:714:12 [INFO] [stdout] | [INFO] [stdout] 709 | pub fn from_bytes(mut frame: Bytes) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 714 | Ok(match frame[0] { [INFO] [stdout] | ____________^ [INFO] [stdout] 715 | | 0x02 => Responses::Read { [INFO] [stdout] 716 | | addr: { [INFO] [stdout] 717 | | frame.try_get_u8()?; [INFO] [stdout] ... | [INFO] [stdout] 745 | | }, [INFO] [stdout] 746 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:723:41 [INFO] [stdout] | [INFO] [stdout] 723 | .filter_map(|x| Value::from_bytes(Bytes::copy_from_slice(x)).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:996:12 [INFO] [stdout] | [INFO] [stdout] 992 | fn from_packet(mut packet: Bytes) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 996 | Ok(MemoryView { base, data: packet }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minidsp-protocol` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/util/try_buf.rs:37:14 [INFO] [stdout] | [INFO] [stdout] 35 | pub trait TryBuf { [INFO] [stdout] | ------ methods in this trait [INFO] [stdout] 36 | try_def!(try_get_u8, u8); [INFO] [stdout] 37 | try_def!(try_get_i8, i8); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | try_def!(try_get_i16, i16); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 42 | try_def!(try_get_i16_le, i16); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 43 | [INFO] [stdout] 44 | try_def!(try_get_u32, u32); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 45 | try_def!(try_get_u32_le, u32); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 46 | try_def!(try_get_i32, i32); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 47 | try_def!(try_get_i32_le, i32); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 48 | [INFO] [stdout] 49 | try_def!(try_get_u64, u64); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 50 | try_def!(try_get_u64_le, u64); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 51 | try_def!(try_get_i64, i64); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 52 | try_def!(try_get_i64_le, i64); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 53 | [INFO] [stdout] 54 | try_def!(try_get_f32, f32); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | try_def!(try_get_f64, f64); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 58 | try_def!(try_get_f64_le, f64); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] = note: this warning originates in the macro `try_def` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn from_bytes(mut b: Bytes) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Ok( [INFO] [stdout] 122 | / if b.len() == 4 && ((b[0] != 0 || b[1] != 0) && b[2] == 0 && b[3] == 0) { [INFO] [stdout] 123 | | Value::Int(b.try_get_u16_le()?) [INFO] [stdout] 124 | | } else { [INFO] [stdout] 125 | | Value::Unknown(b) [INFO] [stdout] 126 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 397 | pub fn from_bytes(mut frame: Bytes) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | Ok(match frame.try_get_u8()? { [INFO] [stdout] | ____________^ [INFO] [stdout] 399 | | 0x02 => Commands::Read { [INFO] [stdout] 400 | | addr: { [INFO] [stdout] 401 | | let len = if frame.len() >= 3 { 3 } else { 2 }; [INFO] [stdout] ... | [INFO] [stdout] 505 | | }, [INFO] [stdout] 506 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:714:12 [INFO] [stdout] | [INFO] [stdout] 709 | pub fn from_bytes(mut frame: Bytes) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 714 | Ok(match frame[0] { [INFO] [stdout] | ____________^ [INFO] [stdout] 715 | | 0x02 => Responses::Read { [INFO] [stdout] 716 | | addr: { [INFO] [stdout] 717 | | frame.try_get_u8()?; [INFO] [stdout] ... | [INFO] [stdout] 745 | | }, [INFO] [stdout] 746 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:723:41 [INFO] [stdout] | [INFO] [stdout] 723 | .filter_map(|x| Value::from_bytes(Bytes::copy_from_slice(x)).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:996:12 [INFO] [stdout] | [INFO] [stdout] 992 | fn from_packet(mut packet: Bytes) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 996 | Ok(MemoryView { base, data: packet }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minidsp-protocol` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b9932c468acb2a89c21ce8523bcae30d61e7300127992a83a0a5f4a469d7e513", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9932c468acb2a89c21ce8523bcae30d61e7300127992a83a0a5f4a469d7e513", kill_on_drop: false }` [INFO] [stdout] b9932c468acb2a89c21ce8523bcae30d61e7300127992a83a0a5f4a469d7e513