[INFO] fetching crate miniball 0.5.0... [INFO] checking miniball-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate miniball 0.5.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate miniball 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate miniball 0.5.0 [INFO] finished tweaking crates.io crate miniball 0.5.0 [INFO] tweaked toml for crates.io crate miniball 0.5.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate miniball 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1efdafcebd2b5a2b17093c5246344ffbeee4bde676b5f411f5cb1f2de804c499 [INFO] running `Command { std: "docker" "start" "-a" "1efdafcebd2b5a2b17093c5246344ffbeee4bde676b5f411f5cb1f2de804c499", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1efdafcebd2b5a2b17093c5246344ffbeee4bde676b5f411f5cb1f2de804c499", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1efdafcebd2b5a2b17093c5246344ffbeee4bde676b5f411f5cb1f2de804c499", kill_on_drop: false }` [INFO] [stdout] 1efdafcebd2b5a2b17093c5246344ffbeee4bde676b5f411f5cb1f2de804c499 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 602a64c631f190a6f22ceba86d0757e5fa4c86f35f8b59b28a1ce1124c66e08a [INFO] running `Command { std: "docker" "start" "-a" "602a64c631f190a6f22ceba86d0757e5fa4c86f35f8b59b28a1ce1124c66e08a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling cc v1.0.92 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking wide v0.7.15 [INFO] [stderr] Compiling psm v0.1.21 [INFO] [stderr] Compiling stacker v0.1.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Compiling nalgebra-macros v0.2.1 [INFO] [stderr] Checking nalgebra v0.32.5 [INFO] [stderr] Checking miniball v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ball.rs:75:3 [INFO] [stdout] | [INFO] [stdout] 73 | let norm_squared = (point - &self.center).norm_squared(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | assert!(norm_squared.is_finite(), "infinite point"); [INFO] [stdout] 75 | self.radius_squared.clone() / norm_squared >= T::one() - T::default_epsilon().sqrt() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ball.rs:75:49 [INFO] [stdout] | [INFO] [stdout] 73 | let norm_squared = (point - &self.center).norm_squared(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | assert!(norm_squared.is_finite(), "infinite point"); [INFO] [stdout] 75 | self.radius_squared.clone() / norm_squared >= T::one() - T::default_epsilon().sqrt() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ball.rs:106:3 [INFO] [stdout] | [INFO] [stdout] 82 | let points = OMatrix::::from_fn(|row, column| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let matrix = OMatrix::::from_fn(|row, column| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let vector = OVector::::from_fn(|row, _column| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | matrix.try_inverse().and_then(|matrix| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ball.rs:114:36 [INFO] [stdout] | [INFO] [stdout] 106 | matrix.try_inverse().and_then(|matrix| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let vector = matrix * vector; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let mut center = OVector::::zeros(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let radius_squared = center.norm_squared(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let center = &bounds[0] + ¢er; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | radius_squared.is_finite().then(|| Self { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 115 | | center, [INFO] [stdout] 116 | | radius_squared, [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enclosing.rs:159:3 [INFO] [stdout] | [INFO] [stdout] 158 | let mut bounds = OVec::, DimNameSum>::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | / (0..bounds.capacity()) [INFO] [stdout] 160 | | .find_map(|_| { [INFO] [stdout] 161 | | maybe_grow(Self::RED_ZONE, Self::STACK_SIZE, || { [INFO] [stdout] 162 | | Self::enclosing_points_with_bounds(points, &mut bounds) [INFO] [stdout] 163 | | }) [INFO] [stdout] 164 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ball.rs:75:3 [INFO] [stdout] | [INFO] [stdout] 73 | let norm_squared = (point - &self.center).norm_squared(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | assert!(norm_squared.is_finite(), "infinite point"); [INFO] [stdout] 75 | self.radius_squared.clone() / norm_squared >= T::one() - T::default_epsilon().sqrt() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ball.rs:75:49 [INFO] [stdout] | [INFO] [stdout] 73 | let norm_squared = (point - &self.center).norm_squared(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | assert!(norm_squared.is_finite(), "infinite point"); [INFO] [stdout] 75 | self.radius_squared.clone() / norm_squared >= T::one() - T::default_epsilon().sqrt() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ball.rs:106:3 [INFO] [stdout] | [INFO] [stdout] 82 | let points = OMatrix::::from_fn(|row, column| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let matrix = OMatrix::::from_fn(|row, column| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let vector = OVector::::from_fn(|row, _column| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | matrix.try_inverse().and_then(|matrix| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ball.rs:114:36 [INFO] [stdout] | [INFO] [stdout] 106 | matrix.try_inverse().and_then(|matrix| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let vector = matrix * vector; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let mut center = OVector::::zeros(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let radius_squared = center.norm_squared(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let center = &bounds[0] + ¢er; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | radius_squared.is_finite().then(|| Self { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 115 | | center, [INFO] [stdout] 116 | | radius_squared, [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enclosing.rs:159:3 [INFO] [stdout] | [INFO] [stdout] 158 | let mut bounds = OVec::, DimNameSum>::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | / (0..bounds.capacity()) [INFO] [stdout] 160 | | .find_map(|_| { [INFO] [stdout] 161 | | maybe_grow(Self::RED_ZONE, Self::STACK_SIZE, || { [INFO] [stdout] 162 | | Self::enclosing_points_with_bounds(points, &mut bounds) [INFO] [stdout] 163 | | }) [INFO] [stdout] 164 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `miniball` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `miniball` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "602a64c631f190a6f22ceba86d0757e5fa4c86f35f8b59b28a1ce1124c66e08a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "602a64c631f190a6f22ceba86d0757e5fa4c86f35f8b59b28a1ce1124c66e08a", kill_on_drop: false }` [INFO] [stdout] 602a64c631f190a6f22ceba86d0757e5fa4c86f35f8b59b28a1ce1124c66e08a